You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "NickVStepin (via GitHub)" <gi...@apache.org> on 2024/04/16 08:04:17 UTC
[PR] Patch add russian keyboard [guacamole-server]
NickVStepin opened a new pull request, #507:
URL: https://github.com/apache/guacamole-server/pull/507
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-925: Patch add russian keyboard [guacamole-server]
Posted by "NickVStepin (via GitHub)" <gi...@apache.org>.
NickVStepin commented on code in PR #507:
URL: https://github.com/apache/guacamole-server/pull/507#discussion_r1567245255
##########
src/protocols/rdp/Makefile.am:
##########
@@ -252,7 +252,8 @@ rdp_keymaps = \
$(srcdir)/keymaps/ro_ro_qwerty.keymap \
$(srcdir)/keymaps/sv_se_qwerty.keymap \
$(srcdir)/keymaps/da_dk_qwerty.keymap \
- $(srcdir)/keymaps/tr_tr_qwerty.keymap
+ $(srcdir)/keymaps/tr_tr_qwerty.keymap \
+ $(srcdir)/keymaps/ru_ru_qwerty.keymap
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Patch add russian keyboard [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on code in PR #507:
URL: https://github.com/apache/guacamole-server/pull/507#discussion_r1567177555
##########
src/protocols/rdp/keymaps/ru_ru_qwerty.keymap:
##########
@@ -0,0 +1,59 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+parent "base"
+name "ru-ru-qwerty"
+# We use the "KBD_US" layout because we switch the language, not the layout
+freerdp "KBD_US"
+
+# Let's define the scan codes of the main Latin keys
+#
+map -caps -shift 0x10..0x19 ~ "qwertyuiop"
+map -caps -shift 0x1E..0x26 ~ "asdfghjkl"
+map -caps -shift 0x2C..0x32 ~ "zxcvbnm"
+
+map -caps +shift 0x10..0x19 ~ "QWERTYUIOP"
+map -caps +shift 0x1E..0x26 ~ "ASDFGHJKL"
+map -caps +shift 0x2C..0x32 ~ "ZXCVBNM"
+
+map -caps +shift 0x10..0x19 ~ "QWERTYUIOP"
+map -caps +shift 0x1E..0x26 ~ "ASDFGHJKL"
+map -caps +shift 0x2C..0x32 ~ "ZXCVBNM"
+
+map +caps +shift 0x10..0x19 ~ "qwertyuiop"
+map +caps +shift 0x1E..0x26 ~ "asdfghjkl"
+map +caps +shift 0x2C..0x32 ~ "zxcvbnm"
Review Comment:
If this is exactly the same as the `base` layout, does it even need to be (re)defined, here? Or should the layout just have the items that change relative to the base, which would be the Russian keys (below)? @mike-jumper?
##########
src/protocols/rdp/Makefile.am:
##########
@@ -252,7 +252,8 @@ rdp_keymaps = \
$(srcdir)/keymaps/ro_ro_qwerty.keymap \
$(srcdir)/keymaps/sv_se_qwerty.keymap \
$(srcdir)/keymaps/da_dk_qwerty.keymap \
- $(srcdir)/keymaps/tr_tr_qwerty.keymap
+ $(srcdir)/keymaps/tr_tr_qwerty.keymap \
+ $(srcdir)/keymaps/ru_ru_qwerty.keymap
Review Comment:
This should be placed alphabetically in this list, just below the `ro_ro` layout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-925: Patch add russian keyboard [guacamole-server]
Posted by "NickVStepin (via GitHub)" <gi...@apache.org>.
NickVStepin commented on code in PR #507:
URL: https://github.com/apache/guacamole-server/pull/507#discussion_r1567255418
##########
src/protocols/rdp/keymaps/ru_ru_qwerty.keymap:
##########
@@ -0,0 +1,59 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+parent "base"
+name "ru-ru-qwerty"
+# We use the "KBD_US" layout because we switch the language, not the layout
+freerdp "KBD_US"
+
+# Let's define the scan codes of the main Latin keys
+#
+map -caps -shift 0x10..0x19 ~ "qwertyuiop"
+map -caps -shift 0x1E..0x26 ~ "asdfghjkl"
+map -caps -shift 0x2C..0x32 ~ "zxcvbnm"
+
+map -caps +shift 0x10..0x19 ~ "QWERTYUIOP"
+map -caps +shift 0x1E..0x26 ~ "ASDFGHJKL"
+map -caps +shift 0x2C..0x32 ~ "ZXCVBNM"
+
+map -caps +shift 0x10..0x19 ~ "QWERTYUIOP"
+map -caps +shift 0x1E..0x26 ~ "ASDFGHJKL"
+map -caps +shift 0x2C..0x32 ~ "ZXCVBNM"
+
+map +caps +shift 0x10..0x19 ~ "qwertyuiop"
+map +caps +shift 0x1E..0x26 ~ "asdfghjkl"
+map +caps +shift 0x2C..0x32 ~ "zxcvbnm"
Review Comment:
It's not exactly the same thing.
Scan codes for ~!@#$%^&*()_+[]\;'',./ have been removed from "en" base keymap and хъ\жэбю. for "ru" keymap. For example, if set "map 0x34 ~ "." (as base "en" keymap) then i press "."-key to "ru" layout RDP-session "type" - "ю"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-925: Patch add russian keyboard [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #507:
URL: https://github.com/apache/guacamole-server/pull/507#issuecomment-2080461492
@NickVStepin : You can do the following:
* Use "git log" to find the commit ID of the commit *before* your first commit.
* Use "git rebase -i <commit id>" to start an interactive rebase.
* Use the "reword" option on each of the commits.
* Change the commit messages.
* Force-push the changes, which will automatically update this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-925: Patch add russian keyboard [guacamole-server]
Posted by "NickVStepin (via GitHub)" <gi...@apache.org>.
NickVStepin commented on PR #507:
URL: https://github.com/apache/guacamole-server/pull/507#issuecomment-2080375158
> Thanks @NickVStepin! A couple of minor updates requested, here, and one thing that I'd like Mike's feedback on.
>
> Also, the title of the Pull Request, as well as the commit message(s) should contain the `GUACAMOLE-925:` prefix - see the other PRs for examples of that.
Thanks @necouchman.
Sorry, i don't change prefix my commit messages. :(
Should I create new commit messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-925: Patch add russian keyboard [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on code in PR #507:
URL: https://github.com/apache/guacamole-server/pull/507#discussion_r1581053599
##########
src/protocols/rdp/keymaps/ru_ru_qwerty.keymap:
##########
@@ -0,0 +1,59 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+parent "base"
+name "ru-ru-qwerty"
+# We use the "KBD_US" layout because we switch the language, not the layout
+freerdp "KBD_US"
+
+# Let's define the scan codes of the main Latin keys
+#
+map -caps -shift 0x10..0x19 ~ "qwertyuiop"
+map -caps -shift 0x1E..0x26 ~ "asdfghjkl"
+map -caps -shift 0x2C..0x32 ~ "zxcvbnm"
+
+map -caps +shift 0x10..0x19 ~ "QWERTYUIOP"
+map -caps +shift 0x1E..0x26 ~ "ASDFGHJKL"
+map -caps +shift 0x2C..0x32 ~ "ZXCVBNM"
+
+map -caps +shift 0x10..0x19 ~ "QWERTYUIOP"
+map -caps +shift 0x1E..0x26 ~ "ASDFGHJKL"
+map -caps +shift 0x2C..0x32 ~ "ZXCVBNM"
+
+map +caps +shift 0x10..0x19 ~ "qwertyuiop"
+map +caps +shift 0x1E..0x26 ~ "asdfghjkl"
+map +caps +shift 0x2C..0x32 ~ "zxcvbnm"
Review Comment:
Okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-925: Patch add russian keyboard [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #507:
URL: https://github.com/apache/guacamole-server/pull/507#issuecomment-2079419998
@NickVStepin I see you updated pull request title, but commit messages also need to be 1) updated to include "GUACAMOLE-925:" prefix, and 2) should be descriptive of the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org