[Bug 59065] catalina.sh should check for colon _after_ cygwin path sanitization

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=59065

Christopher Schultz <ch...@christopherschultz.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #1 from Christopher Schultz <ch...@christopherschultz.net> ---
I'm curious, what is the result of using this patch? If Cygwin is being used on
Windows with CATALINA_BASE or CATALINA_HOME (or both) starting with a drive
letter (this is presumably the use-case, here), then the CLASSPATH will be
built with an embedded colon character.

Under this environment, how does the JVM interpret the CLASSPATH environment
variable? Does it use the UNIX-style path separator (colon) or does it use the
Windows-style path separator (semicolon)? I would imagine that Windows-based
JVMs /always/ use semicolons as the path separator, regardless of the use of
Cygwin or any other UNIX-like environment running inside of it.

In that case, shouldn't the colon-checking be replaced with semicolon-checking
for Windows? The real issue is that a .sh file is being used on Windows instead
of the .bat file (which is exclusively for Windows).

I have only looked at the raw diff and not yet in context, but it sounds like
moving the check is not appropriate for Cygwin-on-Windows. Changing the check
to look for semicolon is the right fix.

Have I misunderstood?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org