You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/22 23:41:34 UTC

[GitHub] [spark] gengliangwang commented on a change in pull request #24327: [WIP][SPARK-27418][SQL] Migrate Parquet to File Data Source V2

gengliangwang commented on a change in pull request #24327: [WIP][SPARK-27418][SQL] Migrate Parquet to File Data Source V2
URL: https://github.com/apache/spark/pull/24327#discussion_r277474611
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
 ##########
 @@ -238,7 +240,8 @@ case class AlterTableAddColumnsCommand(
         // TextFileFormat only default to one column "value"
         // Hive type is already considered as hive serde table, so the logic will not
         // come in here.
-        case _: JsonFileFormat | _: CSVDataSourceV2 | _: ParquetFileFormat | _: OrcDataSourceV2 =>
+        case _: JsonFileFormat | _: CSVFileFormat | _: ParquetFileFormat =>
 
 Review comment:
   We should handle the V1 here as well, which was ignore in the previous migration PRs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org