You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/10 11:17:03 UTC
[GitHub] [incubator-nuttx] jlaitine opened a new pull request, #7270: arch/risc-v/src/mpfs: Add a config option for enabling L2 cache
jlaitine opened a new pull request, #7270:
URL: https://github.com/apache/incubator-nuttx/pull/7270
Make a separate config flag for enabling L2 cache. This is on by default when compiling a standalone/bootloader configuration, but can also be disabled for special cases, such as memory testing
Signed-off-by: Jukka Laitinen <ju...@ssrc.tii.ae>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7270: arch/risc-v/src/mpfs: Add a config option for enabling L2 cache
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #7270:
URL: https://github.com/apache/incubator-nuttx/pull/7270#discussion_r991301357
##########
arch/risc-v/src/mpfs/Kconfig:
##########
@@ -157,6 +157,13 @@ config MPFS_DDR_TYPE
default 3 if MPFS_DDR_TYPE_LPDDR3
default 4 if MPFS_DDR_TYPE_LPDDR4
+config MPFS_ENABLE_CACHE
+ bool "Enable L2 cache"
+ depends on MPFS_BOOTLOADER
Review Comment:
@jlaitine why does it depend on MPFS_BOOTLOADER ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jlaitine commented on a diff in pull request #7270: arch/risc-v/src/mpfs: Add a config option for enabling L2 cache
Posted by GitBox <gi...@apache.org>.
jlaitine commented on code in PR #7270:
URL: https://github.com/apache/incubator-nuttx/pull/7270#discussion_r991332701
##########
arch/risc-v/src/mpfs/Kconfig:
##########
@@ -157,6 +157,13 @@ config MPFS_DDR_TYPE
default 3 if MPFS_DDR_TYPE_LPDDR3
default 4 if MPFS_DDR_TYPE_LPDDR4
+config MPFS_ENABLE_CACHE
+ bool "Enable L2 cache"
+ depends on MPFS_BOOTLOADER
Review Comment:
The MPFS_BOOTLOADER option is used when building a nuttx image which does memory and clock configuration (i.e. boots stand alone from power on reset). If one uses some external bootloader (HSS, another nuttx instance or such), the cache enablement needs to be done in that one. Especially if running multiple OS's in parallel, it only makes sense to configure the cache in the boot. Also, cache enablement can only be done on the E51 hart, and not from anything running on U54's. Original code enabled the L2 cache always with MPFS_BOOTLOADER. This change only makes it possible to also disable the cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7270: arch/risc-v/src/mpfs: Add a config option for enabling L2 cache
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7270:
URL: https://github.com/apache/incubator-nuttx/pull/7270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org