You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by persiaAziz <gi...@git.apache.org> on 2015/07/21 16:22:38 UTC
[GitHub] trafficserver pull request: Coverity issues: making the sanity che...
GitHub user persiaAziz opened a pull request:
https://github.com/apache/trafficserver/pull/259
Coverity issues: making the sanity check calls useful!
asserting sanity check
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/persiaAziz/trafficserver Coverity_Fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #259
----
commit e8df681ca5783deea42d76cf681dd78b4218176f
Author: Syeda Persia Aziz <pe...@yahoo.com>
Date: 2015-07-20T23:16:17Z
Coverity issues: making the sanity check calls useful!
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Coverity issues:
Posted by persiaAziz <gi...@git.apache.org>.
Github user persiaAziz closed the pull request at:
https://github.com/apache/trafficserver/pull/259
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: Coverity issues:
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/259#discussion_r35712793
--- Diff: mgmt/Alarms.cc ---
@@ -413,6 +413,7 @@ Alarms::constructAlarmMessage(const AppVersionInfo &version, char *ip, char *mes
if (max >= 1) {
message[0] = '\0';
}
+ ink_mutex_release(&mutex);
--- End diff --
I think this would be better done with SCOPED_MUTEX_LOCK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---