You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by yi...@apache.org on 2022/10/31 11:51:25 UTC

[royale-asjs] branch d_and_d_improvemets created (now c68c7825de)

This is an automated email from the ASF dual-hosted git repository.

yishayw pushed a change to branch d_and_d_improvemets
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


      at c68c7825de Drag image - Basic container hides nested elements, so make them visible.

This branch includes the following new commits:

     new 5ef0a42bbc Play with different beads for multi-selection
     new c68c7825de Drag image - Basic container hides nested elements, so make them visible.

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[royale-asjs] 01/02: Play with different beads for multi-selection

Posted by yi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

yishayw pushed a commit to branch d_and_d_improvemets
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit 5ef0a42bbc70cb827cd530df60b0e9df5b958ebc
Author: Yishay Weiss <yi...@hotmail.com>
AuthorDate: Wed Oct 26 13:07:52 2022 +0300

    Play with different beads for multi-selection
---
 .../projects/MXRoyale/src/main/royale/mx/controls/Tree.as     | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/Tree.as b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/Tree.as
index da009f1063..554db2024c 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/Tree.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/Tree.as
@@ -89,6 +89,9 @@ import org.apache.royale.html.beads.SingleSelectionDragImageBead;
 import mx.controls.beads.XMLTreeSingleSelectionDragSourceBead;
 import mx.controls.beads.TreeSingleSelectionDropTargetBead;
 import mx.controls.beads.XMLTreeSingleSelectionDropTargetBead;
+import org.apache.royale.html.beads.MultiSelectionTreeDragSourceBead;
+import org.apache.royale.html.beads.MultiSelectionDragImageBead;
+import org.apache.royale.html.beads.SensitiveMultiSelectionDropTargetBead;
 
 //--------------------------------------
 //  Events
@@ -3736,8 +3739,7 @@ public class Tree extends List
     override protected function setDropEnabled():void
     {
         getOrAddBeadByType(DataGridDrawingLayerBead, this);
-        getOrAddBeadByType(TreeSingleSelectionDropTargetBead, this);
-        getOrAddBeadByType(XMLTreeSingleSelectionDropTargetBead, this);
+        getOrAddBeadByType(SensitiveMultiSelectionDropTargetBead, this);
         getOrAddBeadByType(SingleSelectionDropIndicatorBead, this);
     }
 
@@ -3747,9 +3749,8 @@ public class Tree extends List
     override protected function setDragEnabled():void
     {
         // getOrAddBeadByType(TreeSingleSelectionDragSourceBead, this);
-        getOrAddBeadByType(TreeSingleSelectionDragSourceBead, this);
-        getOrAddBeadByType(XMLTreeSingleSelectionDragSourceBead, this);
-        getOrAddBeadByType(SingleSelectionDragImageBead, this);
+        getOrAddBeadByType(MultiSelectionTreeDragSourceBead, this);
+        getOrAddBeadByType(MultiSelectionDragImageBead, this);
     }
 }
 


[royale-asjs] 02/02: Drag image - Basic container hides nested elements, so make them visible.

Posted by yi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

yishayw pushed a commit to branch d_and_d_improvemets
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git

commit c68c7825de12eecc39eb9c2c437dd9502cc61a41
Author: Yishay Weiss <yi...@hotmail.com>
AuthorDate: Mon Oct 31 10:41:16 2022 +0200

    Drag image - Basic container hides nested elements, so make them visible.
---
 .../royale/org/apache/royale/html/beads/MultiSelectionDragImageBead.as  | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/frameworks/projects/DragDrop/src/main/royale/org/apache/royale/html/beads/MultiSelectionDragImageBead.as b/frameworks/projects/DragDrop/src/main/royale/org/apache/royale/html/beads/MultiSelectionDragImageBead.as
index c97986cf50..cd1d519a1b 100644
--- a/frameworks/projects/DragDrop/src/main/royale/org/apache/royale/html/beads/MultiSelectionDragImageBead.as
+++ b/frameworks/projects/DragDrop/src/main/royale/org/apache/royale/html/beads/MultiSelectionDragImageBead.as
@@ -44,6 +44,7 @@ package org.apache.royale.html.beads
 	COMPILE::JS
 	{
 		import org.apache.royale.core.WrappedHTMLElement;
+		import org.apache.royale.html.supportClasses.OverflowViewport;
 	}
 
 
@@ -113,6 +114,7 @@ package org.apache.royale.html.beads
 			{
 				dragImage.addBead(new HorizontalLayout())
 			}
+			dragImage.addBead(new OverflowViewport); // make sure inner elements are visible even if outer size is not correct
 			var itemRendererOwnerView:IItemRendererOwnerView = (_strand.getBeadByType(IBeadView) as IListView).dataGroup as IItemRendererOwnerView;
 			var selectedIndices:Array = model.selectedIndices;
 			for (var i:int = 0; i < selectedIndices.length; i++)