You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/10 21:00:21 UTC

[GitHub] [arrow-datafusion] ozankabak commented on pull request #4168: Improve Error Handling and Readibility for downcasting `Decimal128Array`

ozankabak commented on PR #4168:
URL: https://github.com/apache/arrow-datafusion/pull/4168#issuecomment-1310887015

   > Thanks for review @ozankabak. These recommendations are great for improving code quality. I will change the suggested pieces.
   Great, happy to help!
   
   > ... (but he suggested a few functions unlike my one function per PR) ...
   This is basically what I meant as well. This kind of grouping makes sense for PRs like this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org