[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #415: Expand the diagnostic message for dfdl:checkConstraints(.)

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #415:
URL: https://github.com/apache/incubator-daffodil/pull/415#discussion_r489685258



##########
File path: daffodil-core/src/main/scala/org/apache/daffodil/dpath/Conversions.scala
##########
@@ -273,7 +273,7 @@ object Conversion {
           polymorphicExpressionDiagnostics(st, tt, context)
         context.SDE(
           "In expression %s, the type %s cannot be converted to %s.%s",
-          relevantExpr.text,
+          relevantExpr.wholeExpressionText,

Review comment:
       It looks like there are some other places where we reference ``.text`` an an Expression in a diagnostic in Expression.scala and Conversions.scala. Did you look at these and determine if a similar change to wholeExpressionText is needed to improve the diagnostics?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org