You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/09/30 08:31:50 UTC

[GitHub] [sling-parent] raducotescu commented on a change in pull request #11: SLING-9775 - Improve JaCoCo code coverage setup

raducotescu commented on a change in pull request #11:
URL: https://github.com/apache/sling-parent/pull/11#discussion_r497334990



##########
File path: sling-parent/pom.xml
##########
@@ -555,6 +558,27 @@
                             </execution>
                         </executions>
                     </plugin>
+                    <plugin>

Review comment:
       Yes, but that's in the `<pluginManagement>` section. The reports are generated only in the `jacoco-report` profile, so I didn't want to add the `jacoco.command` property in the generic config, since then the property will be empty and could lead to issues when running ITs.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org