You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2015/02/26 20:06:18 UTC
Review Request 31490: RU change for correctness - reduce the slave
percentage to 20 percent and provide host info to the task
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31490/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Bugs: AMBARI-9820
https://issues.apache.org/jira/browse/AMBARI-9820
Repository: ambari
Description
-------
Change the CORE_SLAVES message to indicate the components upgraded and provide the host info to the Task, in structuredOut, that provides the hosts and components. It will be up to the UI to decide what to do with that structured out.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 55a6aa4
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ced9271
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 7e6047b
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml a9b1cad
Diff: https://reviews.apache.org/r/31490/diff/
Testing
-------
Tests run: 2739, Failures: 0, Errors: 0, Skipped: 15
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:15.252s
[INFO] Finished at: Thu Feb 26 14:01:51 EST 2015
[INFO] Final Memory: 34M/398M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 31490: RU change for correctness - reduce the slave
percentage to 20 percent and provide host info to the task
Posted by Nate Cole <nc...@hortonworks.com>.
> On Feb. 26, 2015, 2:14 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml, line 117
> > <https://reviews.apache.org/r/31490/diff/1/?file=878596#file878596line117>
> >
> > I assume we will do the rounding here.
> > E.g., max(1, (numhosts * percent / 100))
Rounding testing is already done.
> On Feb. 26, 2015, 2:14 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java, line 267
> > <https://reviews.apache.org/r/31490/diff/1/?file=878595#file878595line267>
> >
> > If compNames.size == 0, this will throw an exception.
I can add that, but this function doesn't get called since it gets invoked in a check that is !befores.isEmpty(), so it can't be 0.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31490/#review74333
-----------------------------------------------------------
On Feb. 26, 2015, 2:06 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31490/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 2:06 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-9820
> https://issues.apache.org/jira/browse/AMBARI-9820
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change the CORE_SLAVES message to indicate the components upgraded and provide the host info to the Task, in structuredOut, that provides the hosts and components. It will be up to the UI to decide what to do with that structured out.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 55a6aa4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ced9271
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 7e6047b
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml a9b1cad
>
> Diff: https://reviews.apache.org/r/31490/diff/
>
>
> Testing
> -------
>
> Tests run: 2739, Failures: 0, Errors: 0, Skipped: 15
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:15.252s
> [INFO] Finished at: Thu Feb 26 14:01:51 EST 2015
> [INFO] Final Memory: 34M/398M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 31490: RU change for correctness - reduce the slave
percentage to 20 percent and provide host info to the task
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31490/#review74333
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java
<https://reviews.apache.org/r/31490/#comment120900>
If compNames.size == 0, this will throw an exception.
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml
<https://reviews.apache.org/r/31490/#comment120902>
I assume we will do the rounding here.
E.g., max(1, (numhosts * percent / 100))
- Alejandro Fernandez
On Feb. 26, 2015, 7:06 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31490/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 7:06 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-9820
> https://issues.apache.org/jira/browse/AMBARI-9820
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change the CORE_SLAVES message to indicate the components upgraded and provide the host info to the Task, in structuredOut, that provides the hosts and components. It will be up to the UI to decide what to do with that structured out.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 55a6aa4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ced9271
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 7e6047b
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml a9b1cad
>
> Diff: https://reviews.apache.org/r/31490/diff/
>
>
> Testing
> -------
>
> Tests run: 2739, Failures: 0, Errors: 0, Skipped: 15
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:15.252s
> [INFO] Finished at: Thu Feb 26 14:01:51 EST 2015
> [INFO] Final Memory: 34M/398M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 31490: RU change for correctness - reduce the slave
percentage to 20 percent and provide host info to the task
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31490/#review74341
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Feb. 26, 2015, 2:29 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31490/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 2:29 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-9820
> https://issues.apache.org/jira/browse/AMBARI-9820
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change the CORE_SLAVES message to indicate the components upgraded and provide the host info to the Task, in structuredOut, that provides the hosts and components. It will be up to the UI to decide what to do with that structured out.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 55a6aa4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ced9271
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 7e6047b
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml a9b1cad
>
> Diff: https://reviews.apache.org/r/31490/diff/
>
>
> Testing
> -------
>
> Tests run: 2739, Failures: 0, Errors: 0, Skipped: 15
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:15.252s
> [INFO] Finished at: Thu Feb 26 14:01:51 EST 2015
> [INFO] Final Memory: 34M/398M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 31490: RU change for correctness - reduce the slave
percentage to 20 percent and provide host info to the task
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31490/#review74358
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 26, 2015, 7:29 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31490/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2015, 7:29 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
>
>
> Bugs: AMBARI-9820
> https://issues.apache.org/jira/browse/AMBARI-9820
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change the CORE_SLAVES message to indicate the components upgraded and provide the host info to the Task, in structuredOut, that provides the hosts and components. It will be up to the UI to decide what to do with that structured out.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 55a6aa4
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ced9271
> ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 7e6047b
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml a9b1cad
>
> Diff: https://reviews.apache.org/r/31490/diff/
>
>
> Testing
> -------
>
> Tests run: 2739, Failures: 0, Errors: 0, Skipped: 15
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:15.252s
> [INFO] Finished at: Thu Feb 26 14:01:51 EST 2015
> [INFO] Final Memory: 34M/398M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 31490: RU change for correctness - reduce the slave
percentage to 20 percent and provide host info to the task
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31490/
-----------------------------------------------------------
(Updated Feb. 26, 2015, 2:29 p.m.)
Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
Changes
-------
Updated diff with extra safety check.
Bugs: AMBARI-9820
https://issues.apache.org/jira/browse/AMBARI-9820
Repository: ambari
Description
-------
Change the CORE_SLAVES message to indicate the components upgraded and provide the host info to the Task, in structuredOut, that provides the hosts and components. It will be up to the UI to decide what to do with that structured out.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java 55a6aa4
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml ced9271
ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java 7e6047b
ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml a9b1cad
Diff: https://reviews.apache.org/r/31490/diff/
Testing
-------
Tests run: 2739, Failures: 0, Errors: 0, Skipped: 15
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:15.252s
[INFO] Finished at: Thu Feb 26 14:01:51 EST 2015
[INFO] Final Memory: 34M/398M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole