You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/18 14:50:24 UTC

[GitHub] [flink] xintongsong edited a comment on issue #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance.

xintongsong edited a comment on issue #9105: [FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory size into wrong configuration instance.
URL: https://github.com/apache/flink/pull/9105#issuecomment-512848694
 
 
   @GJL @azagrebin @StephanEwen 
   Just pushed an update moving `updateTaskManagerConfigAndCreateWorkerSlotProfiles()` and `testCreateSlotsPerWorker()` to `ResourceManager` and `ResourceManagerTest` respectively. I did moved some other properties needed by `updateTaskManagerConfigAndCreateWorkerSlotProfiles()` to `ResourceManager` as well (`flinkConfig`, `numberOfTaskSlots`, and `slotsPerWorker`), and I think it makes sense to move them for a common usage for Yarn/Mesos/K8s. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services