You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/09/21 23:07:06 UTC
[kudu-CR] hybrid clock: restore SleepFor in WaitUntilAfterLocally
Hello David Ribeiro Alves, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11495
to review the following change.
Change subject: hybrid_clock: restore SleepFor in WaitUntilAfterLocally
......................................................................
hybrid_clock: restore SleepFor in WaitUntilAfterLocally
This seems to have gone missing from commit f2d96437c. The end result is a
busy loop, which was probably unintentional. I also removed the loop, which
seemed unnecessary with the SleepFor.
To test, I wrote a small program that scanned a table at Now() + 10s, after
setting --scanner_max_wait_ms to 10000 (default is 1000). Although the wall
clock time was the same, the cycle count was far higher per perf stat.
Change-Id: Iecbb077b1f88293dcb0ab53e40ff3862f772694e
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 16 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/11495/1
--
To view, visit http://gerrit.cloudera.org:8080/11495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecbb077b1f88293dcb0ab53e40ff3862f772694e
Gerrit-Change-Number: 11495
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
[kudu-CR] hybrid clock: restore SleepFor in WaitUntilAfterLocally
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/11495 )
Change subject: hybrid_clock: restore SleepFor in WaitUntilAfterLocally
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecbb077b1f88293dcb0ab53e40ff3862f772694e
Gerrit-Change-Number: 11495
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 24 Sep 2018 15:03:37 +0000
Gerrit-HasComments: No
[kudu-CR] hybrid clock: restore SleepFor in WaitUntilAfterLocally
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/11495 )
Change subject: hybrid_clock: restore SleepFor in WaitUntilAfterLocally
......................................................................
Patch Set 2:
I guess I should have +2 before the push :)
--
To view, visit http://gerrit.cloudera.org:8080/11495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecbb077b1f88293dcb0ab53e40ff3862f772694e
Gerrit-Change-Number: 11495
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 24 Sep 2018 15:04:19 +0000
Gerrit-HasComments: No
[kudu-CR] hybrid clock: restore SleepFor in WaitUntilAfterLocally
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11495 )
Change subject: hybrid_clock: restore SleepFor in WaitUntilAfterLocally
......................................................................
Patch Set 1: Code-Review+2
LGTM, but would be nice to get a review from David.
--
To view, visit http://gerrit.cloudera.org:8080/11495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecbb077b1f88293dcb0ab53e40ff3862f772694e
Gerrit-Change-Number: 11495
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 22 Sep 2018 00:20:12 +0000
Gerrit-HasComments: No
[kudu-CR] hybrid clock: restore SleepFor in WaitUntilAfterLocally
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11495 )
Change subject: hybrid_clock: restore SleepFor in WaitUntilAfterLocally
......................................................................
hybrid_clock: restore SleepFor in WaitUntilAfterLocally
This seems to have gone missing from commit f2d96437c. The end result is a
busy loop, which was probably unintentional. I also removed the loop, which
seemed unnecessary with the SleepFor.
To test, I wrote a small program that scanned a table at Now() + 10s, after
setting --scanner_max_wait_ms to 10000 (default is 1000). Although the wall
clock time was the same, the cycle count was far higher per perf stat.
Change-Id: Iecbb077b1f88293dcb0ab53e40ff3862f772694e
Reviewed-on: http://gerrit.cloudera.org:8080/11495
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/clock/hybrid_clock.cc
1 file changed, 16 insertions(+), 16 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11495
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecbb077b1f88293dcb0ab53e40ff3862f772694e
Gerrit-Change-Number: 11495
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins