[jira] [Comment Edited] (OFBIZ-4931) Proposal to remove catalog's "Template Path Prefix" and "Content Path Prefix"

["Wai (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-4931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334295#comment-16334295 ] 

Wai edited comment on OFBIZ-4931 at 1/22/18 2:14 PM:
-----------------------------------------------------

It's been awhile since I logged this one. What do you mean by "...it's useful in the standard context...".  What is a standard context?  Things work fine as long as you don't enter any value for this field. But you'll get an exception if you do. Which implies that this field is useless.

 From a multitenant perspective, a tenant should not have to know that a resource belongs to another tenant. It assumes that all resources belong to itself.


was (Author: wt):
It's been awhile since I logged this one. What do you mean by "...it's useful in the standard context...".  What is a standard context?  Things work fine as long as you don't enter any value for this field. But you'll get an exception if you do. Which implies that this field is useless.

 

> Proposal to remove catalog's "Template Path Prefix" and "Content Path Prefix"
> -----------------------------------------------------------------------------
>
>                 Key: OFBIZ-4931
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4931
>             Project: OFBiz
>          Issue Type: Bug
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Wai
>            Priority: Major
>         Attachments: OFBIZ-4931.patch
>
>
> In reference to the posting, http://ofbiz.135035.n4.nabble.com/Proposal-to-remove-catalog-s-quot-Template-Path-Prefix-quot-field-from-user-interface-td4633296.html
> http://demo-trunk.ofbiz.apache.org/catalog/control/EditProdCatalog?prodCatalogId=DemoCatalog
> It seems that the code blindly prepends the "Template Path Prefix" value to the category's "Detail Screen" field resulting in a file path format that would cause an exception.
> Hence, if a catalog's "Template Path Prefix" is "zzz" and a category's "Detail Screen" is "somedetailscreen", the resulting screen that ofbiz looks for is "/zzzsomedetailscreen".  Which ofbiz would not be able to locate based on the format of the screen location.  Hence, cause an exception.
> If a catalog's "Template Path Prefix" is "zzz" and a category's "Detail Screen" is "component://ecommerce/widget/CatalogScreens.xml#somedetailscreen", the resulting screen that ofbiz looks for is "/zzzcomponent://ecommerce/widget/CatalogScreens.xml#somedetailscreen".  Which ofbiz would not be able to located due to the improper format. Hence cause an exception.
> Since this code never worked since 2006 when it was first placed into the svn repository.  I don't think anyone has made use of it since.
> Regarding a catalog's "Content Path Prefix" field, it also exhibits the same flaw. That of blindly prepending this field.  This field is generally used to specify the product images to be shown in the ecommerce component.
> When this field is empty, the generated image url in ecommerce is shown below (note that it is using "image" webapp context):
> /images/products/ENCHILADAS/small.png
> If you were to specify "/zzz" for "Content Path Prefix", the resulting url for the generated image tag is shown below (note that it is using "zzz" webapp context):
> /zzz/images/products/ENCHILADAS/small.png
> As you can see.  "Content Path Prefix" specifies a "zzz" webapp context with a subdirectory "image".  I doubt this was the intent of the field.  The question is, where exactly are you supposed to place this field value? 
> I propose to remove the catalog's "Template Path Prefix" field from the catalog's user interface and assoc code to reduce the confusion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)