[GitHub] [commons-net] SteveOswald commented on pull request #127: Fixing proxy-problems in _parsePassiveModeReply

[GitBox <gi...@apache.org>]

SteveOswald commented on PR #127:
URL: https://github.com/apache/commons-net/pull/127#issuecomment-1339277659

   Hi @garydgregory ,
   
   we have tested it in our test environment as well as in our production environment. It works with and without proxy.
   
   Also, it does not comply with the RFC to simply have the pasvHost overwritten with the socket address every time (as is currently the case). The server specifies an address in the PASV response to connect to. This address should also be used. The only exception should be if the server sends an invalid address ala "0,0,0,0". This case is already covered in the code, so it is not necessary to always use the socket address - as is currently the case.
   
   A test case for this is factually hard, as it would require a working HTTP proxy. However, it follows from pure logic that the current behavior is wrong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org