You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/22 18:52:25 UTC
[jira] [Commented] (SOLR-7729) ConcurrentUpdateSolrClient ignoring
the collection parameter in some methods
[ https://issues.apache.org/jira/browse/SOLR-7729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206885#comment-15206885 ]
ASF GitHub Bot commented on SOLR-7729:
--------------------------------------
GitHub user nicolasgavalda opened a pull request:
https://github.com/apache/lucene-solr/pull/24
SOLR-7729: ConcurrentUpdateSolrClient ignoring the collection parameter in some methods
This is a fix for SOLR-7729.
I submitted a similar patch on JIRA for the 5.2.1 version, this is an updated version for the master branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nicolasgavalda/lucene-solr SOLR-7729
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
----
commit c9c14eb96525b90271ce6acc4594db12d6799bf3
Author: Nicolas Gavalda <ni...@ametys.org>
Date: 2016-03-22T16:11:55Z
SOLR-7729: ConcurrentUpdateSolrClient ignoring the collection parameter
in some methods.
----
> ConcurrentUpdateSolrClient ignoring the collection parameter in some methods
> ----------------------------------------------------------------------------
>
> Key: SOLR-7729
> URL: https://issues.apache.org/jira/browse/SOLR-7729
> Project: Solr
> Issue Type: Bug
> Components: SolrJ
> Affects Versions: 5.1
> Reporter: Jorge Luis Betancourt Gonzalez
> Labels: client, solrj
> Attachments: SOLR-7729-ConcurrentUpdateSolrClient-collection.patch
>
>
> Some of the methods in {{ConcurrentUpdateSolrClient}} accept an aditional {{collection}} parameter, some of this methods are: {{add(String collection, SolrInputDocument doc)}} and {{request(SolrRequest, String collection)}}.
> This collection parameter is being ignored in this cases but works for others like {{commit(String collection)}}.
> [~elyograg] noted that:
> {quote}
> Looking into how an update request actually gets added to the background
> queue in ConcurrentUpdateSolrClient, it appears that the "collection"
> information is ignored before the request is added to the queue.
> {quote}
> From the source, when a commit is issued or the {{UpdateParams.WAIT_SEARCHER}} is set in the request params the collection parameter is used, otherwise the request {{UpdateRequest req}} is queued without any regarding of the collection.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org