You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/12/09 18:52:22 UTC
[kudu-CR] Make TabletCopyITest subclass ExternalMiniClusterITestBase
Hello Dinesh Bhat, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5440
to review the following change.
Change subject: Make TabletCopyITest subclass ExternalMiniClusterITestBase
......................................................................
Make TabletCopyITest subclass ExternalMiniClusterITestBase
No functional changes, just deleting duplicated code.
Change-Id: I8d8928406ba15c5d69aab8850abed30b48826415
---
M src/kudu/integration-tests/tablet_copy-itest.cc
1 file changed, 3 insertions(+), 57 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/5440/1
--
To view, visit http://gerrit.cloudera.org:8080/5440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8d8928406ba15c5d69aab8850abed30b48826415
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Make TabletCopyITest subclass ExternalMiniClusterITestBase
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Make TabletCopyITest subclass ExternalMiniClusterITestBase
......................................................................
Make TabletCopyITest subclass ExternalMiniClusterITestBase
No functional changes, just deleting duplicated code.
Change-Id: I8d8928406ba15c5d69aab8850abed30b48826415
Reviewed-on: http://gerrit.cloudera.org:8080/5440
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/integration-tests/tablet_copy-itest.cc
1 file changed, 3 insertions(+), 57 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d8928406ba15c5d69aab8850abed30b48826415
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Make TabletCopyITest subclass ExternalMiniClusterITestBase
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Make TabletCopyITest subclass ExternalMiniClusterITestBase
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5440
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d8928406ba15c5d69aab8850abed30b48826415
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No