[jira] [Commented] (LOG4J2-1121) LoggerConfig performance improvement: remove waitForCompletion and associated fields

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194806#comment-17194806 ] 

ASF subversion and git services commented on LOG4J2-1121:
---------------------------------------------------------

Commit 0e2ad68dc0b9dad07194a6b61142135375a4ec64 in logging-log4j2's branch refs/heads/master from Matt Sicker
[ https://gitbox.apache.org/repos/asf?p=logging-log4j2.git;h=0e2ad68 ]

Add tests for LOG4J2-1121 and LOG4J2-2919

Signed-off-by: Matt Sicker <bo...@gmail.com>


> LoggerConfig performance improvement: remove waitForCompletion and associated fields
> ------------------------------------------------------------------------------------
>
>                 Key: LOG4J2-1121
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-1121
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.3
>            Reporter: Remko Popma
>            Assignee: Remko Popma
>            Priority: Major
>             Fix For: 2.4
>
>
> This ticket follows up on LOG4J2-1120. Out of the three changes identified in LOG4J2-1120, only two could be implemented in time for the 2.4 release.
> This ticket tracks the remaining work for the third change:
> * Since {{clearAppenders()}} is only called after all appenders have been stopped, {{waitForCompletion()}} may no longer be necessary (unless I am missing something here). If so, the {{shutdownLock}}, {{shutdown}} and {{counter}} fields can be removed. Not incrementing the atomic counters with every event in the hot path should give better performance.
> LOG4J2-1120 shows benchmark results that support this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)