You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/06 11:06:46 UTC

[GitHub] [flink] StephanEwen commented on issue #8290: [FLINK-12070] [network] Implement new bounded blocking subpartitions

StephanEwen commented on issue #8290: [FLINK-12070] [network] Implement new bounded blocking subpartitions
URL: https://github.com/apache/flink/pull/8290#issuecomment-489583266
 
 
   Some comment on thread-safety and synchronization:
   
   We don't assume arbitrary concurrent access, there is a single writer thread for the `BoundedBlockingSubpartition` and one thread that operates the reader. If that happens nonetheless (bug in the system), exceptions occur. That is preferable to the performance overhead of locks everywhere.
   
   The only concurrency is concurrent reader creation and concurrent release() calls. We need to guard those to avoid segfaults due to accessing unmapped memory. That's what the implementation does.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services