(maven-artifact-plugin) branch master updated: URL-encode coordinate segments in reproducible-central report URLs (#256)

[hb...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

hboutemy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-artifact-plugin.git


The following commit(s) were added to refs/heads/master by this push:
     new b804778  URL-encode coordinate segments in reproducible-central report URLs (#256)
b804778 is described below

commit b8047783f2ffea1694b2963509b8a2300d8971d2
Author: Elliotte Rusty Harold <el...@users.noreply.github.com>
AuthorDate: Sat Oct 17 23:05:17 2026 +0000

    URL-encode coordinate segments in reproducible-central report URLs (#256)
    
    URL-encode coordinates in reproducible-central report URLs (#249)
---
 .../buildinfo/ReproducibleCentralReport.java       | 29 +++++++++++----
 .../buildinfo/ReproducibleCentralReportTest.java   | 42 ++++++++++++++++++++++
 2 files changed, 65 insertions(+), 6 deletions(-)

diff --git a/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReproducibleCentralReport.java b/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReproducibleCentralReport.java
index 2d8eeed..a327d63 100644
--- a/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReproducibleCentralReport.java
+++ b/src/main/java/org/apache/maven/plugins/artifact/buildinfo/ReproducibleCentralReport.java
@@ -18,6 +18,9 @@
  */
 package org.apache.maven.plugins.artifact.buildinfo;
 
+import java.io.UnsupportedEncodingException;
+import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Locale;
@@ -167,12 +170,8 @@ public class ReproducibleCentralReport extends AbstractMavenReport {
 
     private void renderReproducibleCentralArtifact(
             Sink sink, String groupId, String artifactId, String version, String scope) {
-        String url = "https://jvm-repo-rebuild.github.io/reproducible-central/badge/artifact/"
-                + groupId.replace('.', '/') + '/' + artifactId + ".html";
-        String badge = "https://img.shields.io/reproducible-central/artifact/" + groupId + '/' + artifactId + '/'
-                + version + "?labelColor=1e5b96";
-        sink.link(url);
-        sink.figureGraphics(badge);
+        sink.link(reproducibleCentralArtifactUrl(groupId, artifactId));
+        sink.figureGraphics(reproducibleCentralArtifactBadgeUrl(groupId, artifactId, version));
         sink.link_();
         sink.text(' ' + groupId + ':' + artifactId + ':' + version);
         if (scope != null) {
@@ -180,6 +179,24 @@ public class ReproducibleCentralReport extends AbstractMavenReport {
         }
     }
 
+    static String reproducibleCentralArtifactUrl(String groupId, String artifactId) {
+        return "https://jvm-repo-rebuild.github.io/reproducible-central/badge/artifact/"
+                + encode(groupId).replace('.', '/') + '/' + encode(artifactId) + ".html";
+    }
+
+    static String reproducibleCentralArtifactBadgeUrl(String groupId, String artifactId, String version) {
+        return "https://img.shields.io/reproducible-central/artifact/" + encode(groupId) + '/' + encode(artifactId)
+                + '/' + encode(version) + "?labelColor=1e5b96";
+    }
+
+    private static String encode(String s) {
+        try {
+            return URLEncoder.encode(s, StandardCharsets.UTF_8.name()).replace("+", "%20");
+        } catch (UnsupportedEncodingException e) {
+            throw new IllegalStateException("UTF-8 encoding is not supported", e);
+        }
+    }
+
     /**
      * @deprecated use {@link #getOutputPath()} instead
      */
diff --git a/src/test/java/org/apache/maven/plugins/artifact/buildinfo/ReproducibleCentralReportTest.java b/src/test/java/org/apache/maven/plugins/artifact/buildinfo/ReproducibleCentralReportTest.java
new file mode 100644
index 0000000..c60f103
--- /dev/null
+++ b/src/test/java/org/apache/maven/plugins/artifact/buildinfo/ReproducibleCentralReportTest.java
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.artifact.buildinfo;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+class ReproducibleCentralReportTest {
+    @Test
+    void artifactUrlEncodesCoordinates() {
+        assertEquals(
+                "https://jvm-repo-rebuild.github.io/reproducible-central/badge/artifact/"
+                        + "com%26pany/example/my%24artifact.html",
+                ReproducibleCentralReport.reproducibleCentralArtifactUrl("com&pany.example", "my$artifact"));
+    }
+
+    @Test
+    void artifactBadgeUrlEncodesCoordinates() {
+        assertEquals(
+                "https://img.shields.io/reproducible-central/artifact/com%26pany/my%24artifact/"
+                        + "1.0%2FRC%3F1%23x%22%26?labelColor=1e5b96",
+                ReproducibleCentralReport.reproducibleCentralArtifactBadgeUrl(
+                        "com&pany", "my$artifact", "1.0/RC?1#x\"&"));
+    }
+}