You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/30 22:11:49 UTC
[GitHub] [kafka] vvcephei opened a new pull request #8595: KAFKA-8410: Revert Part 1: processor context bounds (#8414)
vvcephei opened a new pull request #8595:
URL: https://github.com/apache/kafka/pull/8595
This reverts commit 29e08fd2c2d3349ba5cbd8fe5a9d35a0cea02b85.
There turned out to be more than expected problems with adding the parameter list.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #8595: KAFKA-8410: Revert Part 1: processor context bounds (#8414)
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8595:
URL: https://github.com/apache/kafka/pull/8595#issuecomment-622145483
Oh, also note that I used `git revert` on the original commit and then searched the codebase for the strings `ProcessorContext<` and `ProcessorContext[` to find any other usages of the parameter list in Java or in Scala.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #8595: KAFKA-8410: Revert Part 1: processor context bounds (#8414)
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8595:
URL: https://github.com/apache/kafka/pull/8595#issuecomment-622527480
Thanks, @mjsax !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei edited a comment on pull request #8595: KAFKA-8410: Revert Part 1: processor context bounds (#8414)
Posted by GitBox <gi...@apache.org>.
vvcephei edited a comment on pull request #8595:
URL: https://github.com/apache/kafka/pull/8595#issuecomment-622221495
11:
* org.apache.kafka.streams.integration.GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin
14:
* org.apache.kafka.streams.integration.StandbyTaskEOSIntegrationTest.surviveWithOneTaskAsStandby[exactly_once]
8:
* kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete
* kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete
* org.apache.kafka.streams.integration.QueryableStateIntegrationTest.shouldAllowConcurrentAccesses
I don't think any of those are related, and each build had different failures.
Nevertheless,
restest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #8595: KAFKA-8410: Revert Part 1: processor context bounds (#8414)
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8595:
URL: https://github.com/apache/kafka/pull/8595#issuecomment-622221495
11:
* org.apache.kafka.streams.integration.GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin
14:
* org.apache.kafka.streams.integration.StandbyTaskEOSIntegrationTest.surviveWithOneTaskAsStandby[exactly_once]
8:
* kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete
* kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete
* org.apache.kafka.streams.integration.QueryableStateIntegrationTest.shouldAllowConcurrentAccesses
I don't think any of those are related, and each build had different failures.
Nevertheless,
restest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #8595: KAFKA-8410: Revert Part 1: processor context bounds (#8414)
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8595:
URL: https://github.com/apache/kafka/pull/8595#issuecomment-622422628
The only failing test this time was org.apache.kafka.streams.integration.GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin, which is already under investigation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] apurvam commented on pull request #8595: KAFKA-8410: Revert Part 1: processor context bounds (#8414)
Posted by GitBox <gi...@apache.org>.
apurvam commented on pull request #8595:
URL: https://github.com/apache/kafka/pull/8595#issuecomment-622239713
I'd favor a quick revert.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vvcephei commented on pull request #8595: KAFKA-8410: Revert Part 1: processor context bounds (#8414)
Posted by GitBox <gi...@apache.org>.
vvcephei commented on pull request #8595:
URL: https://github.com/apache/kafka/pull/8595#issuecomment-622144173
Hey @mjsax @cadonna @apurvam ,
Due to https://github.com/confluentinc/kafka-streams-examples/pull/330, it seems wise just to pull this change while we consider alternatives, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org