You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/12/07 03:44:00 UTC
[jira] [Commented] (SOLR-8975) SolrClient setters should be deprecated in favor of Solr Client Builder methods
[ https://issues.apache.org/jira/browse/SOLR-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644121#comment-17644121 ]
ASF subversion and git services commented on SOLR-8975:
-------------------------------------------------------
Commit 8e00c9c181a54f1ce456221073ed2665a1c6f34e in solr's branch refs/heads/jira/SOLR_16575_createnodeset_in_splitshard from Eric Pugh
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=8e00c9c181a ]
SOLR-8975: Use Builder Pattern with all Solr Clients where possible (#1211)
Introduce Builder setters for setters that exist on SolrClients for responseParser, requestWriter. Deprecated these SolrClient setters useMultiPartPost, and followRedirects. Update corresponding tests to use these changes. Migrate to try/with resources for Solr Clients where possible in tests. Closes SOLR-10455 and SOLR-10459.
> SolrClient setters should be deprecated in favor of Solr Client Builder methods
> -------------------------------------------------------------------------------
>
> Key: SOLR-8975
> URL: https://issues.apache.org/jira/browse/SOLR-8975
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Reporter: Jason Gerlowski
> Priority: Minor
> Attachments: SOLR-8975.patch
>
> Time Spent: 7h 40m
> Remaining Estimate: 0h
>
> SOLR-8097 added a builder layer on top of each {{SolrClient}} implementation.
> Now that builders are in place for SolrClients, the setters used in each SolrClient can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:
> - unifies SolrClient configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak SolrClients available in a single place (the Builders).
> - reduces SolrClient thread-safety concerns. Currently, clients are mutable. Using some SolrClient setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org