You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Alwaysgaurav1 (via GitHub)" <gi...@apache.org> on 2026/08/31 06:13:36 UTC

[PR] fix(core): remove unreachable and bug-prone null guards in Attribute.equals [texera]

Alwaysgaurav1 opened a new pull request, #8267:
URL: https://github.com/apache/texera/pull/8267

   ### What changes were proposed in this PR?
   
   In `Attribute.java` (`common/workflow-core/src/main/scala/org/apache/texera/amber/core/tuple/Attribute.java`), `Attribute.equals()` contained two unreachable null guards:
   ```java
   if (this.attributeName == null) {
       return that.attributeName == null;
   }
   if (this.attributeType == null) {
       return that.attributeType == null; // ignores attribute name comparison!
   }


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(core): remove unreachable and bug-prone null guards in Attribute.equals [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8267:
URL: https://github.com/apache/texera/pull/8267#issuecomment-5474483831

   <!-- texera:welcome-first-time-contributor -->
   👋 Thanks for your first contribution to Texera, @Alwaysgaurav1!
   
   If you're looking for a good place to start, browse issues labeled [`starter-task`](https://github.com/apache/texera/issues?q=is%3Aissue+is%3Aopen+label%3Astarter-task); they're scoped to be approachable for newcomers.
   
   You can drive common housekeeping yourself by commenting one of these commands on its own line:
   
   - **Issues.** Comment `/take` to assign an open issue to yourself, or `/untake` to release it. You can find unclaimed work with the search filter `is:issue is:open no:assignee`.
   - **Sub-issues.** To link issues into a parent/child hierarchy, comment `/sub-issue #5166 #5222` on the parent to attach those children (or `/unsub-issue #5166 #5222` to detach them). From a child issue, comment `/parent-issue #5166` to set its parent, or `/unparent-issue` to clear it (the current parent is detected automatically). References may be written as `#5166` or as a bare `5166`; cross-repository references are not supported.
   - **Pull requests (author only).** Comment `/request-review @user` to request a review from someone, or `/unrequest-review @user` to withdraw that request.
   
   Each command must match exactly: `/take this` will not work, only `/take` does. For the full contribution flow, see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(core): remove unreachable and bug-prone null guards in Attribute.equals [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8267:
URL: https://github.com/apache/texera/pull/8267#issuecomment-5474483959

   <!-- texera:template-compliance -->
   👋 Thanks for opening this pull request, @Alwaysgaurav1!
   
   It looks like the pull request description doesn't quite follow our template yet:
   
   - The **How was this PR tested?** section is missing; please keep the template's headings.
   - The **Was this PR authored or co-authored using generative AI tooling?** section is missing; please keep the template's headings.
   
   Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
   
   You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(core): remove unreachable null guards in Attribute.equals [texera]

Posted by "Alwaysgaurav1 (via GitHub)" <gi...@apache.org>.
Alwaysgaurav1 commented on PR #8267:
URL: https://github.com/apache/texera/pull/8267#issuecomment-5652111313

   Thanks for the guidance, @xuang7 
   I've updated the PR title to `refactor(core): ...`, filled out all sections of the pull request template, and marked the PR as ready for review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(core): remove unreachable null guards in Attribute.equals [texera]

Posted by "Alwaysgaurav1 (via GitHub)" <gi...@apache.org>.
Alwaysgaurav1 commented on PR #8267:
URL: https://github.com/apache/texera/pull/8267#issuecomment-5764484539

   @xuang7, could you pls merge it?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(core): remove unreachable null guards in Attribute.equals [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8267:
URL: https://github.com/apache/texera/pull/8267#issuecomment-5754126009

   <!-- texera-benchmarks-comment -->
   ## ⚠️ Benchmark changes need a look
   
   🟢 0 better · 🔴 8 worse · ⚪ 7 noise (<±5%) · 0 without baseline
   
   > Compared against main `957b6c9` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
   
   [Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/35423953952)
   
   | | config | throughput | MB/s | latency | max Δ latest / 7d |
   |---|---|---:|---:|---:|---:|
   | 🔴 | bs=10 sw=10 sl=64 | 376 | 0.23 | 25,634/34,880/34,880 us | 🔴 -7.6% / 🔴 +120.8% |
   | 🔴 | bs=100 sw=10 sl=64 | 797 | 0.486 | 122,735/148,721/148,721 us | 🔴 +8.9% / 🔴 +36.8% |
   | 🔴 | bs=1000 sw=10 sl=64 | 947 | 0.578 | 1,048,262/1,175,286/1,175,286 us | 🔴 +7.8% / 🔴 +13.3% |
   
   <details><summary>Baseline details</summary>
   
   Latest main `957b6c9` from same runner
   
   | config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
   |---|---|---:|---:|---:|---:|---:|
   | bs=10 sw=10 sl=64 | throughput | 376 tuples/sec | 407 tuples/sec | 767.43 tuples/sec | -7.6% | -51.0% |
   | bs=10 sw=10 sl=64 | MB/s | 0.23 MB/s | 0.249 MB/s | 0.468 MB/s | -7.6% | -50.9% |
   | bs=10 sw=10 sl=64 | p50 | 25,634 us | 23,976 us | 12,880 us | +6.9% | +99.0% |
   | bs=10 sw=10 sl=64 | p95 | 34,880 us | 34,574 us | 15,801 us | +0.9% | +120.8% |
   | bs=10 sw=10 sl=64 | p99 | 34,880 us | 34,574 us | 19,767 us | +0.9% | +76.5% |
   | bs=100 sw=10 sl=64 | throughput | 797 tuples/sec | 868 tuples/sec | 988.73 tuples/sec | -8.2% | -19.4% |
   | bs=100 sw=10 sl=64 | MB/s | 0.486 MB/s | 0.53 MB/s | 0.603 MB/s | -8.3% | -19.5% |
   | bs=100 sw=10 sl=64 | p50 | 122,735 us | 112,716 us | 102,684 us | +8.9% | +19.5% |
   | bs=100 sw=10 sl=64 | p95 | 148,721 us | 141,913 us | 108,712 us | +4.8% | +36.8% |
   | bs=100 sw=10 sl=64 | p99 | 148,721 us | 141,913 us | 118,731 us | +4.8% | +25.3% |
   | bs=1000 sw=10 sl=64 | throughput | 947 tuples/sec | 958 tuples/sec | 1,022 tuples/sec | -1.1% | -7.4% |
   | bs=1000 sw=10 sl=64 | MB/s | 0.578 MB/s | 0.585 MB/s | 0.624 MB/s | -1.2% | -7.4% |
   | bs=1000 sw=10 sl=64 | p50 | 1,048,262 us | 1,043,667 us | 999,086 us | +0.4% | +4.9% |
   | bs=1000 sw=10 sl=64 | p95 | 1,175,286 us | 1,089,997 us | 1,037,033 us | +7.8% | +13.3% |
   | bs=1000 sw=10 sl=64 | p99 | 1,175,286 us | 1,089,997 us | 1,066,123 us | +7.8% | +10.2% |
   
   </details>
   
   <details><summary>Raw CSV</summary>
   
   ```csv
   config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
   0,10,10,64,20,531.32,200,128000,376,0.230,25633.68,34880.10,34880.10
   1,100,10,64,20,2510.39,2000,1280000,797,0.486,122735.02,148721.32,148721.32
   2,1000,10,64,20,21122.52,20000,12800000,947,0.578,1048262.12,1175286.26,1175286.26
   ```
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(core): remove unreachable null guards in Attribute.equals [texera]

Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #8267:
URL: https://github.com/apache/texera/pull/8267#issuecomment-5736877665

   @Alwaysgaurav1 please use the following template and fill it in to satisfy the PR description at the top (these are the format and requirements for a PR to be reviewed and merged):
   ```{markdown}
   ### What changes were proposed in this PR?
   
   ### Any related issues, documentation, discussions?
   Closes #XXXX
   
   ### How was this PR tested?
   
   ### Was this PR authored or co-authored using generative AI tooling?
   Generated-by: <Agent_here> or N/A
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(core): remove unreachable null guards in Attribute.equals [texera]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8267:
URL: https://github.com/apache/texera/pull/8267#issuecomment-5839507062

   ## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8267?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 92.74%. Comparing base ([`9ead3ac`](https://app.codecov.io/gh/apache/texera/commit/9ead3ac13a3f11a70457f0159c8f7a11cb2c4535?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6a9f9a7`](https://app.codecov.io/gh/apache/texera/commit/6a9f9a74f1d9d8d1229db931a7780e5343b8326c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff            @@
   ##               main    #8267   +/-   ##
   =========================================
     Coverage     92.74%   92.74%           
     Complexity     4925     4925           
   =========================================
     Files          1241     1241           
     Lines         52454    52454           
     Branches       6480     6480           
   =========================================
     Hits          48648    48648           
     Misses         2204     2204           
     Partials       1602     1602           
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/texera/pull/8267/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
   |---|---|---|---|
   | [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8267/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.38% <0.00%> (ø)` | | Carriedforward from [9ead3ac](https://app.codecov.io/gh/apache/texera/commit/9ead3ac13a3f11a70457f0159c8f7a11cb2c4535?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [agent-service](https://app.codecov.io/gh/apache/texera/pull/8267/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.16% <0.00%> (ø)` | | Carriedforward from [9ead3ac](https://app.codecov.io/gh/apache/texera/commit/9ead3ac13a3f11a70457f0159c8f7a11cb2c4535?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [amber](https://app.codecov.io/gh/apache/texera/pull/8267/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.46% <0.00%> (ø)` | | Carriedforward from [9ead3ac](https://app.codecov.io/gh/apache/texera/commit/9ead3ac13a3f11a70457f0159c8f7a11cb2c4535?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8267/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.24% <0.00%> (ø)` | | Carriedforward from [9ead3ac](https://app.codecov.io/gh/apache/texera/commit/9ead3ac13a3f11a70457f0159c8f7a11cb2c4535?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [config-service](https://app.codecov.io/gh/apache/texera/pull/8267/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.37% <0.00%> (ø)` | | |
   | [file-service](https://app.codecov.io/gh/apache/texera/pull/8267/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.53% <0.00%> (ø)` | | Carriedforward from [9ead3ac](https://app.codecov.io/gh/apache/texera/commit/9ead3ac13a3f11a70457f0159c8f7a11cb2c4535?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [frontend](https://app.codecov.io/gh/apache/texera/pull/8267/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.52% <0.00%> (ø)` | | Carriedforward from [9ead3ac](https://app.codecov.io/gh/apache/texera/commit/9ead3ac13a3f11a70457f0159c8f7a11cb2c4535?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8267/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <0.00%> (ø)` | | |
   | [pyamber](https://app.codecov.io/gh/apache/texera/pull/8267/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.56% <0.00%> (ø)` | | Carriedforward from [9ead3ac](https://app.codecov.io/gh/apache/texera/commit/9ead3ac13a3f11a70457f0159c8f7a11cb2c4535?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8267/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.09% <0.00%> (ø)` | | Carriedforward from [9ead3ac](https://app.codecov.io/gh/apache/texera/commit/9ead3ac13a3f11a70457f0159c8f7a11cb2c4535?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8267?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(core): remove unreachable null guards in Attribute.equals [texera]

Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 merged PR #8267:
URL: https://github.com/apache/texera/pull/8267


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(core): remove unreachable and bug-prone null guards in Attribute.equals [texera]

Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on PR #8267:
URL: https://github.com/apache/texera/pull/8267#issuecomment-5649889615

   Thanks for the PR. Please follow the pull request template. Also, since this is not a bug fix, you may want to rename the PR title to use refactor. Temporarily marked it as a draft. Please feel free to mark it as ready for review once the PR is ready.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(core): remove unreachable null guards in Attribute.equals [texera]

Posted by "Alwaysgaurav1 (via GitHub)" <gi...@apache.org>.
Alwaysgaurav1 commented on PR #8267:
URL: https://github.com/apache/texera/pull/8267#issuecomment-5739691975

   Thanks @Ma77Ball! I have updated the PR description at the top to follow the exact template with all required sections filled in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(core): remove unreachable and bug-prone null guards in Attribute.equals [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8267:
URL: https://github.com/apache/texera/pull/8267#issuecomment-5474483985

   <!-- backport-auto-label-report -->
   ### Backport auto-label report
   
   This `fix:` PR was checked against each actively-supported release branch. `release/*` labels drive the post-merge backport, so add or remove one to change where this fix lands.
   
   | Release branch | Analysis |
   | --- | --- |
   | ⚠️ `release/v1.3` | Not labeled automatically — none of the files this PR modifies exist on this branch (`common/workflow-core/src/main/scala/org/apache/texera/amber/core/tuple/Attribute.java`). The fix may target code that isn't on this release, or the files were moved/renamed after the branch was cut. **Please check and add `release/v1.3` by hand if this fix should be backported here.** |
   | ✅ `release/v1.2` | Change detected on this branch — label added; this fix is queued to backport here. Requested review from @xuang7. |
   
   _[Auto-label run](https://github.com/apache/texera/actions/runs/33363335300)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(core): remove unreachable null guards in Attribute.equals [texera]

Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #8267:
URL: https://github.com/apache/texera/pull/8267#issuecomment-5839413670

   @Alwaysgaurav1, I'm sorry, this was my fault. You claimed #8149 and fixed it properly, but I merged the same change in #8339 without checking who was assigned. I'll assign myself to issues I plan to fix from now on, and I'm updating `AGENTS.md` (#8675) so agents check for existing claims first. If you'd like another issue, I'm happy to help you find one.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(core): remove unreachable and bug-prone null guards in Attribute.equals [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8267:
URL: https://github.com/apache/texera/pull/8267#issuecomment-5474484538

   <!-- texera-reviewer-suggestion -->
   ### Automated Reviewer Suggestions
   
   Based on the `git blame` history of the changed files, we recommend the following reviewers:
   
   - **Contributors with relevant context:** `@carloea2`
     You can notify them by mentioning `@carloea2` in a comment.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] refactor(core): remove unreachable null guards in Attribute.equals [texera]

Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on PR #8267:
URL: https://github.com/apache/texera/pull/8267#issuecomment-5657082834

   > Thanks for the guidance, @xuang7 I've updated the PR title to `refactor(core): ...`, filled out all sections of the pull request template, and marked the PR as ready for review.
   
   The description is still incomplete. You may refer to other PRs as examples.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org