You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "TyrantLucifer (via GitHub)" <gi...@apache.org> on 2023/03/20 07:11:31 UTC

[GitHub] [incubator-paimon] TyrantLucifer opened a new pull request, #662: [ci] Add code style check step in all workflows

TyrantLucifer opened a new pull request, #662:
URL: https://github.com/apache/incubator-paimon/pull/662

   *(Please specify the module before the PR name: [core] ... or [flink] ...)*
   
   ### Purpose
   
   Add code style check step in all workflows
   
   ### Tests
   
   *(List UT and IT cases to verify this change)*
   
   ### API and Format 
   
   *(Does this change affect API or storage format)*
   
   ### Documentation
   
   *(Does this change introduce a new feature)*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] TyrantLucifer commented on pull request #662: [ci] Add code style check step in all workflows

Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #662:
URL: https://github.com/apache/incubator-paimon/pull/662#issuecomment-1475822989

   > Thanks @TyrantLucifer for the contribution. Why we need to style check? `mvn clean install` already did this.
   
   Thank you for your reply. If the code style of this pr not right, it will stop the build step. This can reduce the time and resource of all CI/CD process and tip the developer check their code style first. If you think this pr is uesless, I will close it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] TyrantLucifer closed pull request #662: [ci] Add code style check step in all workflows

Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer closed pull request #662: [ci] Add code style check step in all workflows
URL: https://github.com/apache/incubator-paimon/pull/662


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-paimon] JingsongLi commented on pull request #662: [ci] Add code style check step in all workflows

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #662:
URL: https://github.com/apache/incubator-paimon/pull/662#issuecomment-1475812780

   Thanks @TyrantLucifer for the contribution.
   Why we need to style check? `mvn clean install` already did this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org