You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/02/14 15:34:56 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3718: Deprecate old JSON reader (#3610)

tustvold commented on code in PR #3718:
URL: https://github.com/apache/arrow-rs/pull/3718#discussion_r1105990039


##########
parquet/src/arrow/arrow_writer/levels.rs:
##########
@@ -1121,7 +1121,7 @@ mod tests {
         // Note: we are using the JSON Arrow reader for brevity
         let json_content = r#"
         {"stocks":{"long": "$AAA", "short": "$BBB"}}
-        {"stocks":{"long": null, "long": "$CCC", "short": null}}
+        {"stocks":{"long": "$CCC", "short": null}}

Review Comment:
   This wasn't actually valid JSON, it contained a duplicate key - the RawReader handles this differently than the old JSON reader



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org