You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by adoron <gi...@git.apache.org> on 2018/11/19 17:18:31 UTC

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Platf...

Github user adoron commented on the issue:

    https://github.com/apache/spark/pull/23043
  
    @kiszk is there a use case where the preliminary RDD isn't created with UnsafeRows? If not then the data will already be corrected on reading.
    
    Anyway, looking at all different implementations of InternalRow.setDouble I found the following places that aren't handled:
    ```
    OnHeapColumnVector.putDouble
    MutableDouble.update
    GenericInternalRow.update
    SpecificInternalRow.setDouble
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org