You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/01/30 13:21:00 UTC

[jira] [Commented] (IMPALA-8135) Bump maven-surefire-plugin version to at least 2.19 to support running a single parameterized test

    [ https://issues.apache.org/jira/browse/IMPALA-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756089#comment-16756089 ] 

ASF subversion and git services commented on IMPALA-8135:
---------------------------------------------------------

Commit efb333d5c4dc790f15cb07d203a497a149432050 in impala's branch refs/heads/master from stiga-huang
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=efb333d ]

IMPALA-8135: Bump maven-surefire-plugin version to 2.20

Bump maven-surefire-plugin version from 2.18 to 2.20 to support running
specific methods in a parametized junit test class. Impala has some
parameterized JUnit test classes, e.g. AuthorizationTest. It supports
testing on file based authz policy and sentry based authz policy by
parameterizing the TestContext. With our current maven-surefire-plugin
version we can't run a single test method in such kind of classes.

This patch bumps maven-surefire-plugin version to 2.20 so we can run
spercific testMethod of a parameterized class like:
  mvn test -Dtest=AuthorizationTest#TestShowTableResultsFiltered[0]
or
  mvn test -Dtest=AuthorizationTest#TestShowTableResultsFiltered[*]

Test:
 - run FE tests locally.

Change-Id: Ib1d85e181d1e9a15ab5b5d0d6744b6cbf7d5b5b8
Reviewed-on: http://gerrit.cloudera.org:8080/12295
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Bump maven-surefire-plugin version to at least 2.19 to support running a single parameterized test
> --------------------------------------------------------------------------------------------------
>
>                 Key: IMPALA-8135
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8135
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Frontend
>            Reporter: Quanlong Huang
>            Assignee: Quanlong Huang
>            Priority: Major
>             Fix For: Impala 3.2.0
>
>
> Our current version of maven-surefire-plugin is 2.18 which does not support running a single parameterized test. For example, AuthorizationTest is a parameterized test class to support tests on file based auth and sentry based auth together. Currently, we can't run a single test method like:
> {code:java}
> (pushd fe && mvn test -Dtest=AuthorizationTest#TestDescribeTableResults[*]){code}
> I'm in branch-2.x. My head is e288128ba and I'm cherry-picking 9282fa3ba. AuthorizationTest#TestDescribeTableResults is the only test failures needed to fix.
> We need to upgrade maven-surefire-plugin to at least 2.19 to support this: http://maven.apache.org/surefire/maven-surefire-plugin/examples/single-test.html#Multiple_Formats_in_One



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org