You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by sc...@apache.org on 2007/05/25 16:16:48 UTC
svn commit: r541666 -
/incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSClassRegistry.java
Author: schor
Date: Fri May 25 07:16:47 2007
New Revision: 541666
URL: http://svn.apache.org/viewvc?view=rev&rev=541666
Log:
no Jira - improve gc potential by null-ing out vars after use.
Modified:
incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSClassRegistry.java
Modified: incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSClassRegistry.java
URL: http://svn.apache.org/viewvc/incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSClassRegistry.java?view=diff&rev=541666&r1=541665&r2=541666
==============================================================================
--- incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSClassRegistry.java (original)
+++ incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSClassRegistry.java Fri May 25 07:16:47 2007
@@ -102,6 +102,7 @@
}
jcasView.putJfsFromCaddr(addr, fs);
}
+ initargs[0] = initargs[1] = null; // better gc
return fs;
}
Re: svn commit: r541666 - /incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSClassRegistry.java
Posted by Thilo Goetz <tw...@gmx.de>.
schor@apache.org wrote:
> Author: schor
> Date: Fri May 25 07:16:47 2007
> New Revision: 541666
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=541666
> Log:
> no Jira - improve gc potential by null-ing out vars after use.
>
> Modified:
> incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSClassRegistry.java
>
> Modified: incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSClassRegistry.java
> URL: http://svn.apache.org/viewvc/incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSClassRegistry.java?view=diff&rev=541666&r1=541665&r2=541666
> ==============================================================================
> --- incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSClassRegistry.java (original)
> +++ incubator/uima/uimaj/trunk/uimaj-core/src/main/java/org/apache/uima/cas/impl/FSClassRegistry.java Fri May 25 07:16:47 2007
> @@ -102,6 +102,7 @@
> }
> jcasView.putJfsFromCaddr(addr, fs);
> }
> + initargs[0] = initargs[1] = null; // better gc
> return fs;
> }
>
>
Better gc, but bad coding practice ;-) From the Java coding conventions:
Avoid assigning several variables to the same value in a single
statement. It is hard to read. Example:
fooBar.fChar = barFoo.lchar = 'c'; // AVOID!
--Thilo