[jira] [Commented] (ARROW-1543) row_wise_conversion example doesn't correspond to ListBuilder constructor arguments

["Wes McKinney (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-1543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167862#comment-16167862 ] 

Wes McKinney commented on ARROW-1543:
-------------------------------------

Sorry about that, this example has bit-rotted due to some API changes (i.e. shared to unique ptr) in the last 6 months. It should not be happening again very soon, but we'll need to conform this to the current API

> row_wise_conversion example doesn't correspond to ListBuilder constructor arguments
> -----------------------------------------------------------------------------------
>
>                 Key: ARROW-1543
>                 URL: https://issues.apache.org/jira/browse/ARROW-1543
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>    Affects Versions: 0.7.0
>            Reporter: Johan Peltenburg
>            Priority: Trivial
>             Fix For: 0.8.0
>
>
> In the row_wise_conversion code example we find:
> {code}
>     std::shared_ptr<DoubleBuilder> components_values_builder =
>         std::make_shared<DoubleBuilder>(arrow::default_memory_pool());
>     arrow::ListBuilder components_builder(arrow::default_memory_pool(),
>         components_values_builder);
> {code}
> This generates some compile time errors since the second argument of the ListBuilder constructor expects a unique pointer.
> However, I guess the example shows the correct case, where we want to still be able to use the DoubleBuilder after constructing the ListBuilder, so I probably shouldn't std::move it to the constructor as a unique_ptr.
> I'm not sure how to fix this as I don't know which functionality is desired.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)