You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by hi...@apache.org on 2006/10/04 12:24:30 UTC
svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk:
depends/libs/build/ depends/libs/windows.x86/ make/depends.properties
make/depends.xml
Author: hindessm
Date: Wed Oct 4 03:24:29 2006
New Revision: 452826
URL: http://svn.apache.org/viewvc?view=rev&rev=452826
Log:
Update check/fetch depends targets to handle the awt dependencies.
Modified:
incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ (props changed)
incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/ (props changed)
incubator/harmony/enhanced/classlib/trunk/make/depends.properties
incubator/harmony/enhanced/classlib/trunk/make/depends.xml
Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
------------------------------------------------------------------------------
--- svn:ignore (original)
+++ svn:ignore Wed Oct 4 03:24:29 2006
@@ -1,3 +1,4 @@
jpeg
lcms
png
+winxp_2006-09-28.txt
Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/
------------------------------------------------------------------------------
--- svn:ignore (original)
+++ svn:ignore Wed Oct 4 03:24:29 2006
@@ -1 +1,2 @@
msvcr71.dll
+swing_awt_deps_winxp_2006-09-28.tgz
Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.properties
URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/make/depends.properties?view=diff&rev=452826&r1=452825&r2=452826
==============================================================================
--- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (original)
+++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed Oct 4 03:24:29 2006
@@ -98,3 +98,11 @@
servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar
+
+people.apache.base=http://people.apache.org/~geirm/harmony/
+awtdeps.dir=${depends.dir}/libs/windows.x86
+awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
+awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
+awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
+awtdeps.extract.dir=${depends.dir}/libs/build
+awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/make/depends.xml?view=diff&rev=452826&r1=452825&r2=452826
==============================================================================
--- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
+++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct 4 03:24:29 2006
@@ -72,17 +72,22 @@
</target>
- <target name="-check-win" if="is.windows">
+ <target name="-check-win" if="is.windows"
+ depends="-really-check-win,-awt-tar-extract" />
+
+ <target name="-really-check-win" if="is.windows">
<check-one-file src="${msvcr71.url}" dest="${msvcr71.dll}" />
- </target>
+ <check-one-file src="${awtdeps.url}" dest="${awtdeps.tar}" />
+
+ <uptodate property="awtdeps.uptodate"
+ srcfile="${awtdeps.tar}"
+ targetfile="${awtdeps.testfile}" />
- <target name="-check-unix" if="with.awt.swing">
- <antcall target="--check-unix" />
</target>
- <target name="--check-unix" if="is.unix">
+ <target name="-check-unix" if="is.unix">
<property name="lcms.msg"
value="liblcms development package not installed
@@ -214,6 +219,10 @@
<download-one-file src="${msvcr71.url}" dest="${msvcr71.dll}"
md5="${msvcr71.md5}" />
+ <mkdir dir="${awtdeps.dir}" />
+ <download-one-file src="${awtdeps.url}" dest="${awtdeps.tar}"
+ md5="${awtdeps.md5}" />
+
</target>
<macrodef name="download-one-file">
@@ -298,6 +307,14 @@
<jar destfile="${bcprov.jar}" basedir="${bcprov.dir}/temp"
manifest="${bcprov.dir}/temp/META-INF/MANIFEST.MF" />
<delete dir="${bcprov.dir}/temp" />
+ </target>
+
+ <target name="-awt-tar-extract" unless="awtdeps.uptodate">
+ <echo>Extracting awt dependencies</echo>
+ <untar src="${awtdeps.tar}" dest="${awtdeps.extract.dir}"
+ compression="gzip" />
+ <echo file="${awtdeps.testfile}"
+ message="${awtdeps.tar} extracted${line.separator}" />
</target>
<macrodef name="check-one-link">
Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk:
depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Mark Hindess wrote:
> Since most (all?) distributions provide versions of these libraries (and
> maintain them - "regular" security fixes for example) why would we want
> to maintain them ourselves? It's not a job I'd want.
I'm not advocating maintenance, but simply defining the set that we
build and test with.
I'm not a fan of having certified builds be dependent on whatever random
stuff the user downloads to /usr/lib
>
> Really the same is true for zlib and to an extent icu. If someone
> else is doing the work maintaining them, we should use what they are a
> providing not make more work for ourselves. We should also try to use
> the dynamic libraries if possible.
Yes, on the first sentence, not so sure on the last, simply because
there's value in testing a fixed set of versions of stuff.
>
> With the exception of icu, most of these libraries change very little
> over time so there should be few if any interoperability issues.
>
> I can only really see a good argument for maintaining icu binaries since
> it is changing more frequently and many distributions seem to have
> rather old versions.
>
> Regards,
> Mark.
>
> On 4 October 2006 at 10:40, "Geir Magnusson Jr." <ge...@pobox.com> wrote:
>> Any reason why we couldn't do the same thing for linux that we're doing
>> for windows in terms of having these libraries pre-compiled and easy to
>> drop in?
>>
>> geir
>>
>> Mark Hindess wrote:
>>> With this change, the awt dependencies should now be automated for
>>> windows and at least fairly trivial (installing a few packages on
>>> Linux[0]). I think it is time we removed the with.awt.swing flag.
>>> Anyone object?
>>>
>>> Please test the current setup with -Dwith.awt.swing=true and report any
>>> problems.
>>>
>>> Regards,
>>> Mark.
>>>
>>> [0] Details of the required packages for distributions other than
>>> Debian/Ubuntu would be welcome.
>>>
>>> On 4 October 2006 at 10:24, hindessm@apache.org wrote:
>>>> Author: hindessm
>>>> Date: Wed Oct 4 03:24:29 2006
>>>> New Revision: 452826
>>>>
>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=452826
>>>> Log:
>>>> Update check/fetch depends targets to handle the awt dependencies.
>>>>
>>>> Modified:
>>>> incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ (props
>> ch
>>>> anged)
>>>> incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/
>> (pr
>>>> ops changed)
>>>> incubator/harmony/enhanced/classlib/trunk/make/depends.properties
>>>> incubator/harmony/enhanced/classlib/trunk/make/depends.xml
>>>>
>>>> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
>>>> --------------------------------------------------------------------------
>> ---
>>>> -
>>>> --- svn:ignore (original)
>>>> +++ svn:ignore Wed Oct 4 03:24:29 2006
>>>> @@ -1,3 +1,4 @@
>>>> jpeg
>>>> lcms
>>>> png
>>>> +winxp_2006-09-28.txt
>>>>
>>>> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows
>> .x8
>>>> 6/
>>>> --------------------------------------------------------------------------
>> ---
>>>> -
>>>> --- svn:ignore (original)
>>>> +++ svn:ignore Wed Oct 4 03:24:29 2006
>>>> @@ -1 +1,2 @@
>>>> msvcr71.dll
>>>> +swing_awt_deps_winxp_2006-09-28.tgz
>>>>
>>>> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.propertie
>> s
>>>> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
>> k/m
>>>> ake/depends.properties?view=diff&rev=452826&r1=452825&r2=452826
>>>> ==========================================================================
>> ===
>>>> =
>>>> --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (ori
>> gin
>>>> al)
>>>> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed
>> Oct
>>>> 4 03:24:29 2006
>>>> @@ -98,3 +98,11 @@
>>>> servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
>>>> servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
>>>> servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servle
>> t-a
>>>> pi-2.5-6.0.0.jar
>>>> +
>>>> +people.apache.base=http://people.apache.org/~geirm/harmony/
>>>> +awtdeps.dir=${depends.dir}/libs/windows.x86
>>>> +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
>>>> +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
>>>> +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
>>>> +awtdeps.extract.dir=${depends.dir}/libs/build
>>>> +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
>>>>
>>>> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
>>>> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
>> k/m
>>>> ake/depends.xml?view=diff&rev=452826&r1=452825&r2=452826
>>>> ==========================================================================
>> ===
>>>> =
>>>> --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
>>>> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct 4
>> 03:
>>>> 24:29 2006
>>>> @@ -72,17 +72,22 @@
>>>>
>>>> </target>
>>>>
>>>> - <target name="-check-win" if="is.windows">
>>>> + <target name="-check-win" if="is.windows"
>>>> + depends="-really-check-win,-awt-tar-extract" />
>>>> +
>>>> + <target name="-really-check-win" if="is.windows">
>>>>
>>>> <check-one-file src="${msvcr71.url}" dest="${msvcr71.dll}" />
>>>>
>>>> - </target>
>>>> + <check-one-file src="${awtdeps.url}" dest="${awtdeps.tar}" />
>>>> +
>>>> + <uptodate property="awtdeps.uptodate"
>>>> + srcfile="${awtdeps.tar}"
>>>> + targetfile="${awtdeps.testfile}" />
>>>>
>>>> - <target name="-check-unix" if="with.awt.swing">
>>>> - <antcall target="--check-unix" />
>>>> </target>
>>>>
>>>> - <target name="--check-unix" if="is.unix">
>>>> + <target name="-check-unix" if="is.unix">
>>>>
>>>> <property name="lcms.msg"
>>>> value="liblcms development package not installed
>>>> @@ -214,6 +219,10 @@
>>>> <download-one-file src="${msvcr71.url}" dest="${msvcr71.dll}"
>>>> md5="${msvcr71.md5}" />
>>>>
>>>> + <mkdir dir="${awtdeps.dir}" />
>>>> + <download-one-file src="${awtdeps.url}" dest="${awtdeps.tar}"
>>>> + md5="${awtdeps.md5}" />
>>>> +
>>>> </target>
>>>>
>>>> <macrodef name="download-one-file">
>>>> @@ -298,6 +307,14 @@
>>>> <jar destfile="${bcprov.jar}" basedir="${bcprov.dir}/temp"
>>>> manifest="${bcprov.dir}/temp/META-INF/MANIFEST.MF" />
>>>> <delete dir="${bcprov.dir}/temp" />
>>>> + </target>
>>>> +
>>>> + <target name="-awt-tar-extract" unless="awtdeps.uptodate">
>>>> + <echo>Extracting awt dependencies</echo>
>>>> + <untar src="${awtdeps.tar}" dest="${awtdeps.extract.dir}"
>>>> + compression="gzip" />
>>>> + <echo file="${awtdeps.testfile}"
>>>> + message="${awtdeps.tar} extracted${line.separator}" />
>>>> </target>
>>>>
>>>> <macrodef name="check-one-link">
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml
Posted by Mark Hindess <ma...@googlemail.com>.
Since most (all?) distributions provide versions of these libraries (and
maintain them - "regular" security fixes for example) why would we want
to maintain them ourselves? It's not a job I'd want.
Really the same is true for zlib and to an extent icu. If someone
else is doing the work maintaining them, we should use what they are a
providing not make more work for ourselves. We should also try to use
the dynamic libraries if possible.
With the exception of icu, most of these libraries change very little
over time so there should be few if any interoperability issues.
I can only really see a good argument for maintaining icu binaries since
it is changing more frequently and many distributions seem to have
rather old versions.
Regards,
Mark.
On 4 October 2006 at 10:40, "Geir Magnusson Jr." <ge...@pobox.com> wrote:
> Any reason why we couldn't do the same thing for linux that we're doing
> for windows in terms of having these libraries pre-compiled and easy to
> drop in?
>
> geir
>
> Mark Hindess wrote:
> > With this change, the awt dependencies should now be automated for
> > windows and at least fairly trivial (installing a few packages on
> > Linux[0]). I think it is time we removed the with.awt.swing flag.
> > Anyone object?
> >
> > Please test the current setup with -Dwith.awt.swing=true and report any
> > problems.
> >
> > Regards,
> > Mark.
> >
> > [0] Details of the required packages for distributions other than
> > Debian/Ubuntu would be welcome.
> >
> > On 4 October 2006 at 10:24, hindessm@apache.org wrote:
> >> Author: hindessm
> >> Date: Wed Oct 4 03:24:29 2006
> >> New Revision: 452826
> >>
> >> URL: http://svn.apache.org/viewvc?view=rev&rev=452826
> >> Log:
> >> Update check/fetch depends targets to handle the awt dependencies.
> >>
> >> Modified:
> >> incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ (props
> ch
> >> anged)
> >> incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/
> (pr
> >> ops changed)
> >> incubator/harmony/enhanced/classlib/trunk/make/depends.properties
> >> incubator/harmony/enhanced/classlib/trunk/make/depends.xml
> >>
> >> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
> >> --------------------------------------------------------------------------
> ---
> >> -
> >> --- svn:ignore (original)
> >> +++ svn:ignore Wed Oct 4 03:24:29 2006
> >> @@ -1,3 +1,4 @@
> >> jpeg
> >> lcms
> >> png
> >> +winxp_2006-09-28.txt
> >>
> >> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows
> .x8
> >> 6/
> >> --------------------------------------------------------------------------
> ---
> >> -
> >> --- svn:ignore (original)
> >> +++ svn:ignore Wed Oct 4 03:24:29 2006
> >> @@ -1 +1,2 @@
> >> msvcr71.dll
> >> +swing_awt_deps_winxp_2006-09-28.tgz
> >>
> >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.propertie
> s
> >> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
> k/m
> >> ake/depends.properties?view=diff&rev=452826&r1=452825&r2=452826
> >> ==========================================================================
> ===
> >> =
> >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (ori
> gin
> >> al)
> >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed
> Oct
> >> 4 03:24:29 2006
> >> @@ -98,3 +98,11 @@
> >> servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
> >> servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
> >> servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servle
> t-a
> >> pi-2.5-6.0.0.jar
> >> +
> >> +people.apache.base=http://people.apache.org/~geirm/harmony/
> >> +awtdeps.dir=${depends.dir}/libs/windows.x86
> >> +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
> >> +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
> >> +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
> >> +awtdeps.extract.dir=${depends.dir}/libs/build
> >> +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
> >>
> >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
> >> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
> k/m
> >> ake/depends.xml?view=diff&rev=452826&r1=452825&r2=452826
> >> ==========================================================================
> ===
> >> =
> >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
> >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct 4
> 03:
> >> 24:29 2006
> >> @@ -72,17 +72,22 @@
> >>
> >> </target>
> >>
> >> - <target name="-check-win" if="is.windows">
> >> + <target name="-check-win" if="is.windows"
> >> + depends="-really-check-win,-awt-tar-extract" />
> >> +
> >> + <target name="-really-check-win" if="is.windows">
> >>
> >> <check-one-file src="${msvcr71.url}" dest="${msvcr71.dll}" />
> >>
> >> - </target>
> >> + <check-one-file src="${awtdeps.url}" dest="${awtdeps.tar}" />
> >> +
> >> + <uptodate property="awtdeps.uptodate"
> >> + srcfile="${awtdeps.tar}"
> >> + targetfile="${awtdeps.testfile}" />
> >>
> >> - <target name="-check-unix" if="with.awt.swing">
> >> - <antcall target="--check-unix" />
> >> </target>
> >>
> >> - <target name="--check-unix" if="is.unix">
> >> + <target name="-check-unix" if="is.unix">
> >>
> >> <property name="lcms.msg"
> >> value="liblcms development package not installed
> >> @@ -214,6 +219,10 @@
> >> <download-one-file src="${msvcr71.url}" dest="${msvcr71.dll}"
> >> md5="${msvcr71.md5}" />
> >>
> >> + <mkdir dir="${awtdeps.dir}" />
> >> + <download-one-file src="${awtdeps.url}" dest="${awtdeps.tar}"
> >> + md5="${awtdeps.md5}" />
> >> +
> >> </target>
> >>
> >> <macrodef name="download-one-file">
> >> @@ -298,6 +307,14 @@
> >> <jar destfile="${bcprov.jar}" basedir="${bcprov.dir}/temp"
> >> manifest="${bcprov.dir}/temp/META-INF/MANIFEST.MF" />
> >> <delete dir="${bcprov.dir}/temp" />
> >> + </target>
> >> +
> >> + <target name="-awt-tar-extract" unless="awtdeps.uptodate">
> >> + <echo>Extracting awt dependencies</echo>
> >> + <untar src="${awtdeps.tar}" dest="${awtdeps.extract.dir}"
> >> + compression="gzip" />
> >> + <echo file="${awtdeps.testfile}"
> >> + message="${awtdeps.tar} extracted${line.separator}" />
> >> </target>
> >>
> >> <macrodef name="check-one-link">
> >>
> >
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk:
depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Any reason why we couldn't do the same thing for linux that we're doing
for windows in terms of having these libraries pre-compiled and easy to
drop in?
geir
Mark Hindess wrote:
> With this change, the awt dependencies should now be automated for
> windows and at least fairly trivial (installing a few packages on
> Linux[0]). I think it is time we removed the with.awt.swing flag.
> Anyone object?
>
> Please test the current setup with -Dwith.awt.swing=true and report any
> problems.
>
> Regards,
> Mark.
>
> [0] Details of the required packages for distributions other than
> Debian/Ubuntu would be welcome.
>
> On 4 October 2006 at 10:24, hindessm@apache.org wrote:
>> Author: hindessm
>> Date: Wed Oct 4 03:24:29 2006
>> New Revision: 452826
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=452826
>> Log:
>> Update check/fetch depends targets to handle the awt dependencies.
>>
>> Modified:
>> incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ (props ch
>> anged)
>> incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/ (pr
>> ops changed)
>> incubator/harmony/enhanced/classlib/trunk/make/depends.properties
>> incubator/harmony/enhanced/classlib/trunk/make/depends.xml
>>
>> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
>> -----------------------------------------------------------------------------
>> -
>> --- svn:ignore (original)
>> +++ svn:ignore Wed Oct 4 03:24:29 2006
>> @@ -1,3 +1,4 @@
>> jpeg
>> lcms
>> png
>> +winxp_2006-09-28.txt
>>
>> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x8
>> 6/
>> -----------------------------------------------------------------------------
>> -
>> --- svn:ignore (original)
>> +++ svn:ignore Wed Oct 4 03:24:29 2006
>> @@ -1 +1,2 @@
>> msvcr71.dll
>> +swing_awt_deps_winxp_2006-09-28.tgz
>>
>> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.properties
>> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
>> ake/depends.properties?view=diff&rev=452826&r1=452825&r2=452826
>> =============================================================================
>> =
>> --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (origin
>> al)
>> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed Oct
>> 4 03:24:29 2006
>> @@ -98,3 +98,11 @@
>> servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
>> servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
>> servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servlet-a
>> pi-2.5-6.0.0.jar
>> +
>> +people.apache.base=http://people.apache.org/~geirm/harmony/
>> +awtdeps.dir=${depends.dir}/libs/windows.x86
>> +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
>> +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
>> +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
>> +awtdeps.extract.dir=${depends.dir}/libs/build
>> +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
>>
>> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
>> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
>> ake/depends.xml?view=diff&rev=452826&r1=452825&r2=452826
>> =============================================================================
>> =
>> --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
>> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct 4 03:
>> 24:29 2006
>> @@ -72,17 +72,22 @@
>>
>> </target>
>>
>> - <target name="-check-win" if="is.windows">
>> + <target name="-check-win" if="is.windows"
>> + depends="-really-check-win,-awt-tar-extract" />
>> +
>> + <target name="-really-check-win" if="is.windows">
>>
>> <check-one-file src="${msvcr71.url}" dest="${msvcr71.dll}" />
>>
>> - </target>
>> + <check-one-file src="${awtdeps.url}" dest="${awtdeps.tar}" />
>> +
>> + <uptodate property="awtdeps.uptodate"
>> + srcfile="${awtdeps.tar}"
>> + targetfile="${awtdeps.testfile}" />
>>
>> - <target name="-check-unix" if="with.awt.swing">
>> - <antcall target="--check-unix" />
>> </target>
>>
>> - <target name="--check-unix" if="is.unix">
>> + <target name="-check-unix" if="is.unix">
>>
>> <property name="lcms.msg"
>> value="liblcms development package not installed
>> @@ -214,6 +219,10 @@
>> <download-one-file src="${msvcr71.url}" dest="${msvcr71.dll}"
>> md5="${msvcr71.md5}" />
>>
>> + <mkdir dir="${awtdeps.dir}" />
>> + <download-one-file src="${awtdeps.url}" dest="${awtdeps.tar}"
>> + md5="${awtdeps.md5}" />
>> +
>> </target>
>>
>> <macrodef name="download-one-file">
>> @@ -298,6 +307,14 @@
>> <jar destfile="${bcprov.jar}" basedir="${bcprov.dir}/temp"
>> manifest="${bcprov.dir}/temp/META-INF/MANIFEST.MF" />
>> <delete dir="${bcprov.dir}/temp" />
>> + </target>
>> +
>> + <target name="-awt-tar-extract" unless="awtdeps.uptodate">
>> + <echo>Extracting awt dependencies</echo>
>> + <untar src="${awtdeps.tar}" dest="${awtdeps.extract.dir}"
>> + compression="gzip" />
>> + <echo file="${awtdeps.testfile}"
>> + message="${awtdeps.tar} extracted${line.separator}" />
>> </target>
>>
>> <macrodef name="check-one-link">
>>
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml)
Posted by Oleg Khaschansky <ol...@gmail.com>.
Patch for the TransferHandlerTest failure is here:
http://issues.apache.org/jira/browse/HARMONY-1723
On 10/5/06, Mikhail Loenko <ml...@gmail.com> wrote:
> 2006/10/5, Oleg Khaschansky <ol...@gmail.com>:
> > I found the reason of this failure. It is an IntrospectionException
> > while executing a following method from the TransferHandler class:
> >
> > private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
> > PropertyDescriptor result = null;
> > try {
> > result = new PropertyDescriptor(propertyName, c.getClass());
> > } catch (IntrospectionException e) {
> >
> > }
> > return result;
> > }
> > It tries to get the PropertyDescriptor for the class JButton and
> > property name "insets", but fails because there's no setInsets method.
> > So, flavors array stays uninitialized and getTransferDataFlavors
> > method returns null which is a cause of a NPE.
> >
> > The quick fix for this issue could be changing this method to the following:
> >
> > private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
> > PropertyDescriptor result = null;
> > try {
> > return result = new PropertyDescriptor(propertyName, c.getClass());
> > } catch (IntrospectionException e) {
> > }
> > try {
> > return result = new PropertyDescriptor(propertyName,
> > c.getClass(), "1", null);
> > } catch (IntrospectionException e) {
> > }
> > return result;
> > }
> >
> > + we need to fix in beans the fact that the following code:
> >
> > new PropertyDescriptor(propertyName, c.getClass(), "1", null);
> >
> > will throw IntrospectionException on Harmony, but will return the
> > valid property descriptor with the getter method on RI.
> >
> > Any thoughts on this? Or should I proceed with a patch for the both issues?
>
> Yes, please. When you submit a patch people will have a chance
> to review and comment
>
> Thanks,
> Mikhail
>
>
> >
> > Thanks,
> > Oleg
> >
> > On 10/4/06, Mikhail Loenko <ml...@gmail.com> wrote:
> > > 2006/10/4, Mark Hindess <ma...@googlemail.com>:
> > > >
> > > > On 4 October 2006 at 15:41, Tim Ellison <t....@gmail.com> wrote:
> > > > > Excuse the change in subject line...
> > > >
> > > > No problem. I was just cursing myself for having forgotten to change
> > > > it.
> > > >
> > > > > Mark Hindess wrote:
> > > > > > With this change, the awt dependencies should now be automated for
> > > > > > windows and at least fairly trivial (installing a few packages on
> > > > > > Linux[0]). I think it is time we removed the with.awt.swing flag.
> > > > > > Anyone object?
> > > > >
> > > > > To the contrary, ditch it.
> > > > >
> > > > > > Please test the current setup with -Dwith.awt.swing=true and report any
> > > > > > problems.
> > > > >
> > > > > Problem 1: My machine is too slow running all these tests.
> > > >
> > > > Mine too. And I have wondered if the hourly builds will finish within
> > > > the hour now. We really should see if we can avoid the need to fork
> > > > for every test.
> > >
> > > I've run the tests on my XP machine, 1 failed
> > >
> > > javax.swing.TransferHandlerTest#testCreateTransferable
> > >
> > > java.lang.NullPointerException at
> > > javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
> > > at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> > > at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
> > > at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
> > > java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
> > > at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
> > > java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
> > > java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
> > > java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
> > > at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)
> > >
> > > Thanks,
> > > Mikhail
> > >
> > >
> > > >
> > > > Regards,
> > > > Mark.
> > > >
> > > > > Regards,
> > > > > Tim
> > > > >
> > > > > > [0] Details of the required packages for distributions other than
> > > > > > Debian/Ubuntu would be welcome.
> > > > > >
> > > > > > On 4 October 2006 at 10:24, hindessm@apache.org wrote:
> > > > > >> Author: hindessm
> > > > > >> Date: Wed Oct 4 03:24:29 2006
> > > > > >> New Revision: 452826
> > > > > >>
> > > > > >> URL: http://svn.apache.org/viewvc?view=rev&rev=452826
> > > > > >> Log:
> > > > > >> Update check/fetch depends targets to handle the awt dependencies.
> > > > > >>
> > > > > >> Modified:
> > > > > >> incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ (props
> > > > > ch
> > > > > >> anged)
> > > > > >> incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/
> > > > > (pr
> > > > > >> ops changed)
> > > > > >> incubator/harmony/enhanced/classlib/trunk/make/depends.properties
> > > > > >> incubator/harmony/enhanced/classlib/trunk/make/depends.xml
> > > > > >>
> > > > > >> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
> > > > > >> --------------------------------------------------------------------------
> > > > > ---
> > > > > >> -
> > > > > >> --- svn:ignore (original)
> > > > > >> +++ svn:ignore Wed Oct 4 03:24:29 2006
> > > > > >> @@ -1,3 +1,4 @@
> > > > > >> jpeg
> > > > > >> lcms
> > > > > >> png
> > > > > >> +winxp_2006-09-28.txt
> > > > > >>
> > > > > >> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows
> > > > > .x8
> > > > > >> 6/
> > > > > >> --------------------------------------------------------------------------
> > > > > ---
> > > > > >> -
> > > > > >> --- svn:ignore (original)
> > > > > >> +++ svn:ignore Wed Oct 4 03:24:29 2006
> > > > > >> @@ -1 +1,2 @@
> > > > > >> msvcr71.dll
> > > > > >> +swing_awt_deps_winxp_2006-09-28.tgz
> > > > > >>
> > > > > >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.propertie
> > > > > s
> > > > > >> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
> > > > > k/m
> > > > > >> ake/depends.properties?view=diff&rev=452826&r1=452825&r2=452826
> > > > > >> ==========================================================================
> > > > > ===
> > > > > >> =
> > > > > >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (ori
> > > > > gin
> > > > > >> al)
> > > > > >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed
> > > > > Oct
> > > > > >> 4 03:24:29 2006
> > > > > >> @@ -98,3 +98,11 @@
> > > > > >> servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
> > > > > >> servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
> > > > > >> servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servle
> > > > > t-a
> > > > > >> pi-2.5-6.0.0.jar
> > > > > >> +
> > > > > >> +people.apache.base=http://people.apache.org/~geirm/harmony/
> > > > > >> +awtdeps.dir=${depends.dir}/libs/windows.x86
> > > > > >> +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
> > > > > >> +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
> > > > > >> +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
> > > > > >> +awtdeps.extract.dir=${depends.dir}/libs/build
> > > > > >> +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
> > > > > >>
> > > > > >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
> > > > > >> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
> > > > > k/m
> > > > > >> ake/depends.xml?view=diff&rev=452826&r1=452825&r2=452826
> > > > > >> ==========================================================================
> > > > > ===
> > > > > >> =
> > > > > >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
> > > > > >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct 4
> > > > > 03:
> > > > > >> 24:29 2006
> > > > > >> @@ -72,17 +72,22 @@
> > > > > >>
> > > > > >> </target>
> > > > > >>
> > > > > >> - <target name="-check-win" if="is.windows">
> > > > > >> + <target name="-check-win" if="is.windows"
> > > > > >> + depends="-really-check-win,-awt-tar-extract" />
> > > > > >> +
> > > > > >> + <target name="-really-check-win" if="is.windows">
> > > > > >>
> > > > > >> <check-one-file src="${msvcr71.url}" dest="${msvcr71.dll}" />
> > > > > >>
> > > > > >> - </target>
> > > > > >> + <check-one-file src="${awtdeps.url}" dest="${awtdeps.tar}" />
> > > > > >> +
> > > > > >> + <uptodate property="awtdeps.uptodate"
> > > > > >> + srcfile="${awtdeps.tar}"
> > > > > >> + targetfile="${awtdeps.testfile}" />
> > > > > >>
> > > > > >> - <target name="-check-unix" if="with.awt.swing">
> > > > > >> - <antcall target="--check-unix" />
> > > > > >> </target>
> > > > > >>
> > > > > >> - <target name="--check-unix" if="is.unix">
> > > > > >> + <target name="-check-unix" if="is.unix">
> > > > > >>
> > > > > >> <property name="lcms.msg"
> > > > > >> value="liblcms development package not installed
> > > > > >> @@ -214,6 +219,10 @@
> > > > > >> <download-one-file src="${msvcr71.url}" dest="${msvcr71.dll}"
> > > > > >> md5="${msvcr71.md5}" />
> > > > > >>
> > > > > >> + <mkdir dir="${awtdeps.dir}" />
> > > > > >> + <download-one-file src="${awtdeps.url}" dest="${awtdeps.tar}"
> > > > > >> + md5="${awtdeps.md5}" />
> > > > > >> +
> > > > > >> </target>
> > > > > >>
> > > > > >> <macrodef name="download-one-file">
> > > > > >> @@ -298,6 +307,14 @@
> > > > > >> <jar destfile="${bcprov.jar}" basedir="${bcprov.dir}/temp"
> > > > > >> manifest="${bcprov.dir}/temp/META-INF/MANIFEST.MF" />
> > > > > >> <delete dir="${bcprov.dir}/temp" />
> > > > > >> + </target>
> > > > > >> +
> > > > > >> + <target name="-awt-tar-extract" unless="awtdeps.uptodate">
> > > > > >> + <echo>Extracting awt dependencies</echo>
> > > > > >> + <untar src="${awtdeps.tar}" dest="${awtdeps.extract.dir}"
> > > > > >> + compression="gzip" />
> > > > > >> + <echo file="${awtdeps.testfile}"
> > > > > >> + message="${awtdeps.tar} extracted${line.separator}" />
> > > > > >> </target>
> > > > > >>
> > > > > >> <macrodef name="check-one-link">
> > > > > >>
> > > > > >
> > > > > >
> > > > > >
> > > > > > ---------------------------------------------------------------------
> > > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > > > >
> > > > > >
> > > > >
> > > > > --
> > > > >
> > > > > Tim Ellison (t.p.ellison@gmail.com)
> > > > > IBM Java technology centre, UK.
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > > >
> > > >
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default
Posted by Oleg Khaschansky <ol...@gmail.com>.
Sure. Now I am running the tests on the patch to ensure that
modifications in beans are safe. Will submit when the tests will pass.
On 10/5/06, Tim Ellison <t....@gmail.com> wrote:
> Mikhail Loenko wrote:
> > Yes, please. When you submit a patch people will have a chance
> > to review and comment
>
> Agreed - and please submit it via JIRA. Feel free to point to it on the
> list.
>
> Regards,
> Tim
>
> --
>
> Tim Ellison (t.p.ellison@gmail.com)
> IBM Java technology centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default
Posted by Tim Ellison <t....@gmail.com>.
Mikhail Loenko wrote:
> Yes, please. When you submit a patch people will have a chance
> to review and comment
Agreed - and please submit it via JIRA. Feel free to point to it on the
list.
Regards,
Tim
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml)
Posted by Mikhail Loenko <ml...@gmail.com>.
2006/10/5, Oleg Khaschansky <ol...@gmail.com>:
> I found the reason of this failure. It is an IntrospectionException
> while executing a following method from the TransferHandler class:
>
> private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
> PropertyDescriptor result = null;
> try {
> result = new PropertyDescriptor(propertyName, c.getClass());
> } catch (IntrospectionException e) {
>
> }
> return result;
> }
> It tries to get the PropertyDescriptor for the class JButton and
> property name "insets", but fails because there's no setInsets method.
> So, flavors array stays uninitialized and getTransferDataFlavors
> method returns null which is a cause of a NPE.
>
> The quick fix for this issue could be changing this method to the following:
>
> private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
> PropertyDescriptor result = null;
> try {
> return result = new PropertyDescriptor(propertyName, c.getClass());
> } catch (IntrospectionException e) {
> }
> try {
> return result = new PropertyDescriptor(propertyName,
> c.getClass(), "1", null);
> } catch (IntrospectionException e) {
> }
> return result;
> }
>
> + we need to fix in beans the fact that the following code:
>
> new PropertyDescriptor(propertyName, c.getClass(), "1", null);
>
> will throw IntrospectionException on Harmony, but will return the
> valid property descriptor with the getter method on RI.
>
> Any thoughts on this? Or should I proceed with a patch for the both issues?
Yes, please. When you submit a patch people will have a chance
to review and comment
Thanks,
Mikhail
>
> Thanks,
> Oleg
>
> On 10/4/06, Mikhail Loenko <ml...@gmail.com> wrote:
> > 2006/10/4, Mark Hindess <ma...@googlemail.com>:
> > >
> > > On 4 October 2006 at 15:41, Tim Ellison <t....@gmail.com> wrote:
> > > > Excuse the change in subject line...
> > >
> > > No problem. I was just cursing myself for having forgotten to change
> > > it.
> > >
> > > > Mark Hindess wrote:
> > > > > With this change, the awt dependencies should now be automated for
> > > > > windows and at least fairly trivial (installing a few packages on
> > > > > Linux[0]). I think it is time we removed the with.awt.swing flag.
> > > > > Anyone object?
> > > >
> > > > To the contrary, ditch it.
> > > >
> > > > > Please test the current setup with -Dwith.awt.swing=true and report any
> > > > > problems.
> > > >
> > > > Problem 1: My machine is too slow running all these tests.
> > >
> > > Mine too. And I have wondered if the hourly builds will finish within
> > > the hour now. We really should see if we can avoid the need to fork
> > > for every test.
> >
> > I've run the tests on my XP machine, 1 failed
> >
> > javax.swing.TransferHandlerTest#testCreateTransferable
> >
> > java.lang.NullPointerException at
> > javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
> > at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> > at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
> > at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
> > java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
> > at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
> > java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
> > java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
> > java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
> > at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)
> >
> > Thanks,
> > Mikhail
> >
> >
> > >
> > > Regards,
> > > Mark.
> > >
> > > > Regards,
> > > > Tim
> > > >
> > > > > [0] Details of the required packages for distributions other than
> > > > > Debian/Ubuntu would be welcome.
> > > > >
> > > > > On 4 October 2006 at 10:24, hindessm@apache.org wrote:
> > > > >> Author: hindessm
> > > > >> Date: Wed Oct 4 03:24:29 2006
> > > > >> New Revision: 452826
> > > > >>
> > > > >> URL: http://svn.apache.org/viewvc?view=rev&rev=452826
> > > > >> Log:
> > > > >> Update check/fetch depends targets to handle the awt dependencies.
> > > > >>
> > > > >> Modified:
> > > > >> incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ (props
> > > > ch
> > > > >> anged)
> > > > >> incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/
> > > > (pr
> > > > >> ops changed)
> > > > >> incubator/harmony/enhanced/classlib/trunk/make/depends.properties
> > > > >> incubator/harmony/enhanced/classlib/trunk/make/depends.xml
> > > > >>
> > > > >> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
> > > > >> --------------------------------------------------------------------------
> > > > ---
> > > > >> -
> > > > >> --- svn:ignore (original)
> > > > >> +++ svn:ignore Wed Oct 4 03:24:29 2006
> > > > >> @@ -1,3 +1,4 @@
> > > > >> jpeg
> > > > >> lcms
> > > > >> png
> > > > >> +winxp_2006-09-28.txt
> > > > >>
> > > > >> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows
> > > > .x8
> > > > >> 6/
> > > > >> --------------------------------------------------------------------------
> > > > ---
> > > > >> -
> > > > >> --- svn:ignore (original)
> > > > >> +++ svn:ignore Wed Oct 4 03:24:29 2006
> > > > >> @@ -1 +1,2 @@
> > > > >> msvcr71.dll
> > > > >> +swing_awt_deps_winxp_2006-09-28.tgz
> > > > >>
> > > > >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.propertie
> > > > s
> > > > >> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
> > > > k/m
> > > > >> ake/depends.properties?view=diff&rev=452826&r1=452825&r2=452826
> > > > >> ==========================================================================
> > > > ===
> > > > >> =
> > > > >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (ori
> > > > gin
> > > > >> al)
> > > > >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed
> > > > Oct
> > > > >> 4 03:24:29 2006
> > > > >> @@ -98,3 +98,11 @@
> > > > >> servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
> > > > >> servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
> > > > >> servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servle
> > > > t-a
> > > > >> pi-2.5-6.0.0.jar
> > > > >> +
> > > > >> +people.apache.base=http://people.apache.org/~geirm/harmony/
> > > > >> +awtdeps.dir=${depends.dir}/libs/windows.x86
> > > > >> +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
> > > > >> +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
> > > > >> +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
> > > > >> +awtdeps.extract.dir=${depends.dir}/libs/build
> > > > >> +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
> > > > >>
> > > > >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
> > > > >> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
> > > > k/m
> > > > >> ake/depends.xml?view=diff&rev=452826&r1=452825&r2=452826
> > > > >> ==========================================================================
> > > > ===
> > > > >> =
> > > > >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
> > > > >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct 4
> > > > 03:
> > > > >> 24:29 2006
> > > > >> @@ -72,17 +72,22 @@
> > > > >>
> > > > >> </target>
> > > > >>
> > > > >> - <target name="-check-win" if="is.windows">
> > > > >> + <target name="-check-win" if="is.windows"
> > > > >> + depends="-really-check-win,-awt-tar-extract" />
> > > > >> +
> > > > >> + <target name="-really-check-win" if="is.windows">
> > > > >>
> > > > >> <check-one-file src="${msvcr71.url}" dest="${msvcr71.dll}" />
> > > > >>
> > > > >> - </target>
> > > > >> + <check-one-file src="${awtdeps.url}" dest="${awtdeps.tar}" />
> > > > >> +
> > > > >> + <uptodate property="awtdeps.uptodate"
> > > > >> + srcfile="${awtdeps.tar}"
> > > > >> + targetfile="${awtdeps.testfile}" />
> > > > >>
> > > > >> - <target name="-check-unix" if="with.awt.swing">
> > > > >> - <antcall target="--check-unix" />
> > > > >> </target>
> > > > >>
> > > > >> - <target name="--check-unix" if="is.unix">
> > > > >> + <target name="-check-unix" if="is.unix">
> > > > >>
> > > > >> <property name="lcms.msg"
> > > > >> value="liblcms development package not installed
> > > > >> @@ -214,6 +219,10 @@
> > > > >> <download-one-file src="${msvcr71.url}" dest="${msvcr71.dll}"
> > > > >> md5="${msvcr71.md5}" />
> > > > >>
> > > > >> + <mkdir dir="${awtdeps.dir}" />
> > > > >> + <download-one-file src="${awtdeps.url}" dest="${awtdeps.tar}"
> > > > >> + md5="${awtdeps.md5}" />
> > > > >> +
> > > > >> </target>
> > > > >>
> > > > >> <macrodef name="download-one-file">
> > > > >> @@ -298,6 +307,14 @@
> > > > >> <jar destfile="${bcprov.jar}" basedir="${bcprov.dir}/temp"
> > > > >> manifest="${bcprov.dir}/temp/META-INF/MANIFEST.MF" />
> > > > >> <delete dir="${bcprov.dir}/temp" />
> > > > >> + </target>
> > > > >> +
> > > > >> + <target name="-awt-tar-extract" unless="awtdeps.uptodate">
> > > > >> + <echo>Extracting awt dependencies</echo>
> > > > >> + <untar src="${awtdeps.tar}" dest="${awtdeps.extract.dir}"
> > > > >> + compression="gzip" />
> > > > >> + <echo file="${awtdeps.testfile}"
> > > > >> + message="${awtdeps.tar} extracted${line.separator}" />
> > > > >> </target>
> > > > >>
> > > > >> <macrodef name="check-one-link">
> > > > >>
> > > > >
> > > > >
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > > >
> > > > >
> > > >
> > > > --
> > > >
> > > > Tim Ellison (t.p.ellison@gmail.com)
> > > > IBM Java technology centre, UK.
> > > >
> > > > ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > >
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml)
Posted by Oleg Khaschansky <ol...@gmail.com>.
Ok. I am testing another patch for the TransferHandler which won't affect beans.
On 10/6/06, Alexei Zakharov <al...@gmail.com> wrote:
> Hi Oleg,
>
> > On the other hand, why don't we allow Harmony to accept invalid names
> > and provide a default replacements for them if there is a set/get/is
> > method for the specified property? It seems to me more user-friendly
> > then throw IntrospectionException in this situation. It looks like the
> > specification doesn't require PropertyDescriptor to throw an exception
> > in this case.
>
> Well, the specification states here:
>
> <==
> public PropertyDescriptor(String propertyName,
> Class<?> beanClass,
> String readMethodName,
> String writeMethodName)
> throws IntrospectionException
> ...
> Parameters:
> ...
> readMethodName - The name of the method used for reading the
> property value. May be null if the property is write-only.
> writeMethodName - The name of the method used for writing the
> property value. May be null if the property is read-only.
> Throws:
> IntrospectionException - if an exception occurs during introspection.
> <==
>
> So we have the description of the valid parameter case, null parameter
> case and the exception that can be thrown. IMHO the natural conclusion
> from that is that the exception will be thrown in case of invalid
> parameter. Moreover, if the implementation does not validate method
> names it will never throw IntrospectionException. But it is described
> by the spec.
> BTW, PropertyDescriptor(String, Method, Method) validates both methods
> and throws IntrospectionException if something is wrong.
>
> > This will also prevent us from breaking applications
> > that uses this RI behavior.
>
> Actually I don't belive they exist in our world. :) May be we can
> leave the current functionality for now and get back to this if
> encounter one of such apps?
>
> Regards,
>
> 2006/10/5, Oleg Khaschansky <ol...@gmail.com>:
> > Alexey,
> >
> > Agree. I haven't noticed that RI doesn't accept invalid write method.
> > Then its behavior looks illogical. Actually, I asked about comments
> > especially because I expected a feedback from beans authors. Thank
> > you.
> >
> > On the other hand, why don't we allow Harmony to accept invalid names
> > and provide a default replacements for them if there is a set/get/is
> > method for the specified property? It seems to me more user-friendly
> > then throw IntrospectionException in this situation. It looks like the
> > specification doesn't require PropertyDescriptor to throw an exception
> > in this case. This will also prevent us from breaking applications
> > that uses this RI behavior.
> > What is your opinion?
> >
> > On 10/5/06, Alexei Zakharov <al...@gmail.com> wrote:
> > > Oleg,
> > >
> > > > + we need to fix in beans the fact that the following code:
> > > > new PropertyDescriptor(propertyName, c.getClass(), "1", null);
> > > > will throw IntrospectionException on Harmony, but will return the
> > > > valid property descriptor with the getter method on RI.
> > > > Any thoughts on this? Or should I proceed with a patch for the both issues?
> > >
> > > I've already written my thoughts about this issue in [1]. In short: I
> > > don't think we should follow the RI behavior since it is inconsistent.
> > > Why it accepts invalid read method and throws exception on invalid
> > > write method? No logic.
> > >
> > > [1] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200609.mbox/%3c2c9597b90609190451g74fec356k2270f515dc5e7ef6@mail.gmail.com%3e
> > >
> > > Thanks,
> > >
> > > 2006/10/4, Oleg Khaschansky <ol...@gmail.com>:
> > > > I found the reason of this failure. It is an IntrospectionException
> > > > while executing a following method from the TransferHandler class:
> > > >
> > > > private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
> > > > PropertyDescriptor result = null;
> > > > try {
> > > > result = new PropertyDescriptor(propertyName, c.getClass());
> > > > } catch (IntrospectionException e) {
> > > >
> > > > }
> > > > return result;
> > > > }
> > > > It tries to get the PropertyDescriptor for the class JButton and
> > > > property name "insets", but fails because there's no setInsets method.
> > > > So, flavors array stays uninitialized and getTransferDataFlavors
> > > > method returns null which is a cause of a NPE.
> > > >
> > > > The quick fix for this issue could be changing this method to the following:
> > > >
> > > > private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
> > > > PropertyDescriptor result = null;
> > > > try {
> > > > return result = new PropertyDescriptor(propertyName, c.getClass());
> > > > } catch (IntrospectionException e) {
> > > > }
> > > > try {
> > > > return result = new PropertyDescriptor(propertyName,
> > > > c.getClass(), "1", null);
> > > > } catch (IntrospectionException e) {
> > > > }
> > > > return result;
> > > > }
> > > >
> > > > + we need to fix in beans the fact that the following code:
> > > >
> > > > new PropertyDescriptor(propertyName, c.getClass(), "1", null);
> > > >
> > > > will throw IntrospectionException on Harmony, but will return the
> > > > valid property descriptor with the getter method on RI.
> > > >
> > > > Any thoughts on this? Or should I proceed with a patch for the both issues?
> > > >
> > > > Thanks,
> > > > Oleg
> > > >
> > > > On 10/4/06, Mikhail Loenko <ml...@gmail.com> wrote:
> > > > > 2006/10/4, Mark Hindess <ma...@googlemail.com>:
> > > > > >
> > > > > > On 4 October 2006 at 15:41, Tim Ellison <t....@gmail.com> wrote:
> > > > > > > Excuse the change in subject line...
> > > > > >
> > > > > > No problem. I was just cursing myself for having forgotten to change
> > > > > > it.
> > > > > >
> > > > > > > Mark Hindess wrote:
> > > > > > > > With this change, the awt dependencies should now be automated for
> > > > > > > > windows and at least fairly trivial (installing a few packages on
> > > > > > > > Linux[0]). I think it is time we removed the with.awt.swing flag.
> > > > > > > > Anyone object?
> > > > > > >
> > > > > > > To the contrary, ditch it.
> > > > > > >
> > > > > > > > Please test the current setup with -Dwith.awt.swing=true and report any
> > > > > > > > problems.
> > > > > > >
> > > > > > > Problem 1: My machine is too slow running all these tests.
> > > > > >
> > > > > > Mine too. And I have wondered if the hourly builds will finish within
> > > > > > the hour now. We really should see if we can avoid the need to fork
> > > > > > for every test.
> > > > >
> > > > > I've run the tests on my XP machine, 1 failed
> > > > >
> > > > > javax.swing.TransferHandlerTest#testCreateTransferable
> > > > >
> > > > > java.lang.NullPointerException at
> > > > > javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
> > > > > at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> > > > > at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
> > > > > at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
> > > > > java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
> > > > > at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
> > > > > java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
> > > > > java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
> > > > > java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
> > > > > at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)
> > > > >
> > >
> > > --
> > > Alexei Zakharov,
> > > Intel Middleware Product Division
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Alexei Zakharov,
> Intel Middleware Product Division
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml)
Posted by Alexei Zakharov <al...@gmail.com>.
Hi Oleg,
> On the other hand, why don't we allow Harmony to accept invalid names
> and provide a default replacements for them if there is a set/get/is
> method for the specified property? It seems to me more user-friendly
> then throw IntrospectionException in this situation. It looks like the
> specification doesn't require PropertyDescriptor to throw an exception
> in this case.
Well, the specification states here:
<==
public PropertyDescriptor(String propertyName,
Class<?> beanClass,
String readMethodName,
String writeMethodName)
throws IntrospectionException
...
Parameters:
...
readMethodName - The name of the method used for reading the
property value. May be null if the property is write-only.
writeMethodName - The name of the method used for writing the
property value. May be null if the property is read-only.
Throws:
IntrospectionException - if an exception occurs during introspection.
<==
So we have the description of the valid parameter case, null parameter
case and the exception that can be thrown. IMHO the natural conclusion
from that is that the exception will be thrown in case of invalid
parameter. Moreover, if the implementation does not validate method
names it will never throw IntrospectionException. But it is described
by the spec.
BTW, PropertyDescriptor(String, Method, Method) validates both methods
and throws IntrospectionException if something is wrong.
> This will also prevent us from breaking applications
> that uses this RI behavior.
Actually I don't belive they exist in our world. :) May be we can
leave the current functionality for now and get back to this if
encounter one of such apps?
Regards,
2006/10/5, Oleg Khaschansky <ol...@gmail.com>:
> Alexey,
>
> Agree. I haven't noticed that RI doesn't accept invalid write method.
> Then its behavior looks illogical. Actually, I asked about comments
> especially because I expected a feedback from beans authors. Thank
> you.
>
> On the other hand, why don't we allow Harmony to accept invalid names
> and provide a default replacements for them if there is a set/get/is
> method for the specified property? It seems to me more user-friendly
> then throw IntrospectionException in this situation. It looks like the
> specification doesn't require PropertyDescriptor to throw an exception
> in this case. This will also prevent us from breaking applications
> that uses this RI behavior.
> What is your opinion?
>
> On 10/5/06, Alexei Zakharov <al...@gmail.com> wrote:
> > Oleg,
> >
> > > + we need to fix in beans the fact that the following code:
> > > new PropertyDescriptor(propertyName, c.getClass(), "1", null);
> > > will throw IntrospectionException on Harmony, but will return the
> > > valid property descriptor with the getter method on RI.
> > > Any thoughts on this? Or should I proceed with a patch for the both issues?
> >
> > I've already written my thoughts about this issue in [1]. In short: I
> > don't think we should follow the RI behavior since it is inconsistent.
> > Why it accepts invalid read method and throws exception on invalid
> > write method? No logic.
> >
> > [1] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200609.mbox/%3c2c9597b90609190451g74fec356k2270f515dc5e7ef6@mail.gmail.com%3e
> >
> > Thanks,
> >
> > 2006/10/4, Oleg Khaschansky <ol...@gmail.com>:
> > > I found the reason of this failure. It is an IntrospectionException
> > > while executing a following method from the TransferHandler class:
> > >
> > > private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
> > > PropertyDescriptor result = null;
> > > try {
> > > result = new PropertyDescriptor(propertyName, c.getClass());
> > > } catch (IntrospectionException e) {
> > >
> > > }
> > > return result;
> > > }
> > > It tries to get the PropertyDescriptor for the class JButton and
> > > property name "insets", but fails because there's no setInsets method.
> > > So, flavors array stays uninitialized and getTransferDataFlavors
> > > method returns null which is a cause of a NPE.
> > >
> > > The quick fix for this issue could be changing this method to the following:
> > >
> > > private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
> > > PropertyDescriptor result = null;
> > > try {
> > > return result = new PropertyDescriptor(propertyName, c.getClass());
> > > } catch (IntrospectionException e) {
> > > }
> > > try {
> > > return result = new PropertyDescriptor(propertyName,
> > > c.getClass(), "1", null);
> > > } catch (IntrospectionException e) {
> > > }
> > > return result;
> > > }
> > >
> > > + we need to fix in beans the fact that the following code:
> > >
> > > new PropertyDescriptor(propertyName, c.getClass(), "1", null);
> > >
> > > will throw IntrospectionException on Harmony, but will return the
> > > valid property descriptor with the getter method on RI.
> > >
> > > Any thoughts on this? Or should I proceed with a patch for the both issues?
> > >
> > > Thanks,
> > > Oleg
> > >
> > > On 10/4/06, Mikhail Loenko <ml...@gmail.com> wrote:
> > > > 2006/10/4, Mark Hindess <ma...@googlemail.com>:
> > > > >
> > > > > On 4 October 2006 at 15:41, Tim Ellison <t....@gmail.com> wrote:
> > > > > > Excuse the change in subject line...
> > > > >
> > > > > No problem. I was just cursing myself for having forgotten to change
> > > > > it.
> > > > >
> > > > > > Mark Hindess wrote:
> > > > > > > With this change, the awt dependencies should now be automated for
> > > > > > > windows and at least fairly trivial (installing a few packages on
> > > > > > > Linux[0]). I think it is time we removed the with.awt.swing flag.
> > > > > > > Anyone object?
> > > > > >
> > > > > > To the contrary, ditch it.
> > > > > >
> > > > > > > Please test the current setup with -Dwith.awt.swing=true and report any
> > > > > > > problems.
> > > > > >
> > > > > > Problem 1: My machine is too slow running all these tests.
> > > > >
> > > > > Mine too. And I have wondered if the hourly builds will finish within
> > > > > the hour now. We really should see if we can avoid the need to fork
> > > > > for every test.
> > > >
> > > > I've run the tests on my XP machine, 1 failed
> > > >
> > > > javax.swing.TransferHandlerTest#testCreateTransferable
> > > >
> > > > java.lang.NullPointerException at
> > > > javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
> > > > at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> > > > at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
> > > > at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
> > > > java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
> > > > at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
> > > > java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
> > > > java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
> > > > java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
> > > > at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)
> > > >
> >
> > --
> > Alexei Zakharov,
> > Intel Middleware Product Division
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Alexei Zakharov,
Intel Middleware Product Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default
Posted by Alexei Zakharov <al...@gmail.com>.
No objections to this "swing-only" solution.
Thanks,
2006/10/6, Oleg Khaschansky <ol...@gmail.com>:
> Tim,
>
> I attached a patch which doesn't have side effects to HARMONY-1723 :)
>
> --
> Oleg
>
> On 10/6/06, Tim Ellison <t....@gmail.com> wrote:
> > Oleg Khaschansky wrote:
> > >> So what happens to the patch on HARMONY-1723.
> > >
> > > My opinion is that it is OK. Consider the following:
> > >
> > > 1. Applications bounded to the RI behavior (e.g. obtaining the
> > > descriptors for read-only properties without construction of getter
> > > name) won't fail.
> > > 2. Construction of the default getter/setter names could be
> > > incapsulated in the PropertyDescriptor. For now there's no possibility
> > > of getting a descriptor for one read-only/write-only property without
> > > constructing its getter/setter name outside of the PropertyDescriptor.
> > > 3. Don't think that it is bad if PropertyDescriptor would lookup for
> > > reasonable defaults if provided names are invalid.
> > >
> > > I'd like to hear another opinion. If somebody will disagree I'll make
> > > another fix for the TransferHandler, whithout touching beans.
> >
> > Me too -- I was following your logic above and agreed, but I got the
> > impression that Alexey disagreed with that approach, so was holding off.
> >
> > I have the patch applied in my workspace but will wait before committing it.
> >
> > Regards,
> > Tim
--
Alexei Zakharov,
Intel Middleware Product Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default
Posted by Oleg Khaschansky <ol...@gmail.com>.
Tim,
I attached a patch which doesn't have side effects to HARMONY-1723 :)
--
Oleg
On 10/6/06, Tim Ellison <t....@gmail.com> wrote:
> Oleg Khaschansky wrote:
> >> So what happens to the patch on HARMONY-1723.
> >
> > My opinion is that it is OK. Consider the following:
> >
> > 1. Applications bounded to the RI behavior (e.g. obtaining the
> > descriptors for read-only properties without construction of getter
> > name) won't fail.
> > 2. Construction of the default getter/setter names could be
> > incapsulated in the PropertyDescriptor. For now there's no possibility
> > of getting a descriptor for one read-only/write-only property without
> > constructing its getter/setter name outside of the PropertyDescriptor.
> > 3. Don't think that it is bad if PropertyDescriptor would lookup for
> > reasonable defaults if provided names are invalid.
> >
> > I'd like to hear another opinion. If somebody will disagree I'll make
> > another fix for the TransferHandler, whithout touching beans.
>
> Me too -- I was following your logic above and agreed, but I got the
> impression that Alexey disagreed with that approach, so was holding off.
>
> I have the patch applied in my workspace but will wait before committing it.
>
> Regards,
> Tim
>
>
> --
>
> Tim Ellison (t.p.ellison@gmail.com)
> IBM Java technology centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default
Posted by Tim Ellison <t....@gmail.com>.
Oleg Khaschansky wrote:
>> So what happens to the patch on HARMONY-1723.
>
> My opinion is that it is OK. Consider the following:
>
> 1. Applications bounded to the RI behavior (e.g. obtaining the
> descriptors for read-only properties without construction of getter
> name) won't fail.
> 2. Construction of the default getter/setter names could be
> incapsulated in the PropertyDescriptor. For now there's no possibility
> of getting a descriptor for one read-only/write-only property without
> constructing its getter/setter name outside of the PropertyDescriptor.
> 3. Don't think that it is bad if PropertyDescriptor would lookup for
> reasonable defaults if provided names are invalid.
>
> I'd like to hear another opinion. If somebody will disagree I'll make
> another fix for the TransferHandler, whithout touching beans.
Me too -- I was following your logic above and agreed, but I got the
impression that Alexey disagreed with that approach, so was holding off.
I have the patch applied in my workspace but will wait before committing it.
Regards,
Tim
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default
Posted by Oleg Khaschansky <ol...@gmail.com>.
> So what happens to the patch on HARMONY-1723.
My opinion is that it is OK. Consider the following:
1. Applications bounded to the RI behavior (e.g. obtaining the
descriptors for read-only properties without construction of getter
name) won't fail.
2. Construction of the default getter/setter names could be
incapsulated in the PropertyDescriptor. For now there's no possibility
of getting a descriptor for one read-only/write-only property without
constructing its getter/setter name outside of the PropertyDescriptor.
3. Don't think that it is bad if PropertyDescriptor would lookup for
reasonable defaults if provided names are invalid.
I'd like to hear another opinion. If somebody will disagree I'll make
another fix for the TransferHandler, whithout touching beans.
On 10/5/06, Tim Ellison <t....@gmail.com> wrote:
> So what happens to the patch on HARMONY-1723. Do you (Oleg & Alexey)
> think we should not fix it that way now?
>
> Regards,
> Tim
>
> Oleg Khaschansky wrote:
> > Alexey,
> >
> > Agree. I haven't noticed that RI doesn't accept invalid write method.
> > Then its behavior looks illogical. Actually, I asked about comments
> > especially because I expected a feedback from beans authors. Thank
> > you.
> >
> > On the other hand, why don't we allow Harmony to accept invalid names
> > and provide a default replacements for them if there is a set/get/is
> > method for the specified property? It seems to me more user-friendly
> > then throw IntrospectionException in this situation. It looks like the
> > specification doesn't require PropertyDescriptor to throw an exception
> > in this case. This will also prevent us from breaking applications
> > that uses this RI behavior.
> > What is your opinion?
> >
> > On 10/5/06, Alexei Zakharov <al...@gmail.com> wrote:
> >> Oleg,
> >>
> >> > + we need to fix in beans the fact that the following code:
> >> > new PropertyDescriptor(propertyName, c.getClass(), "1", null);
> >> > will throw IntrospectionException on Harmony, but will return the
> >> > valid property descriptor with the getter method on RI.
> >> > Any thoughts on this? Or should I proceed with a patch for the both
> >> issues?
> >>
> >> I've already written my thoughts about this issue in [1]. In short: I
> >> don't think we should follow the RI behavior since it is inconsistent.
> >> Why it accepts invalid read method and throws exception on invalid
> >> write method? No logic.
> >>
> >> [1]
> >> http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200609.mbox/%3c2c9597b90609190451g74fec356k2270f515dc5e7ef6@mail.gmail.com%3e
> >>
> >>
> >> Thanks,
> >>
> >> 2006/10/4, Oleg Khaschansky <ol...@gmail.com>:
> >> > I found the reason of this failure. It is an IntrospectionException
> >> > while executing a following method from the TransferHandler class:
> >> >
> >> > private PropertyDescriptor getPropertyDescriptor(final JComponent
> >> c) {
> >> > PropertyDescriptor result = null;
> >> > try {
> >> > result = new PropertyDescriptor(propertyName, c.getClass());
> >> > } catch (IntrospectionException e) {
> >> >
> >> > }
> >> > return result;
> >> > }
> >> > It tries to get the PropertyDescriptor for the class JButton and
> >> > property name "insets", but fails because there's no setInsets method.
> >> > So, flavors array stays uninitialized and getTransferDataFlavors
> >> > method returns null which is a cause of a NPE.
> >> >
> >> > The quick fix for this issue could be changing this method to the
> >> following:
> >> >
> >> > private PropertyDescriptor getPropertyDescriptor(final JComponent
> >> c) {
> >> > PropertyDescriptor result = null;
> >> > try {
> >> > return result = new PropertyDescriptor(propertyName,
> >> c.getClass());
> >> > } catch (IntrospectionException e) {
> >> > }
> >> > try {
> >> > return result = new PropertyDescriptor(propertyName,
> >> > c.getClass(), "1", null);
> >> > } catch (IntrospectionException e) {
> >> > }
> >> > return result;
> >> > }
> >> >
> >> > + we need to fix in beans the fact that the following code:
> >> >
> >> > new PropertyDescriptor(propertyName, c.getClass(), "1", null);
> >> >
> >> > will throw IntrospectionException on Harmony, but will return the
> >> > valid property descriptor with the getter method on RI.
> >> >
> >> > Any thoughts on this? Or should I proceed with a patch for the both
> >> issues?
> >> >
> >> > Thanks,
> >> > Oleg
> >> >
> >> > On 10/4/06, Mikhail Loenko <ml...@gmail.com> wrote:
> >> > > 2006/10/4, Mark Hindess <ma...@googlemail.com>:
> >> > > >
> >> > > > On 4 October 2006 at 15:41, Tim Ellison <t....@gmail.com>
> >> wrote:
> >> > > > > Excuse the change in subject line...
> >> > > >
> >> > > > No problem. I was just cursing myself for having forgotten to
> >> change
> >> > > > it.
> >> > > >
> >> > > > > Mark Hindess wrote:
> >> > > > > > With this change, the awt dependencies should now be
> >> automated for
> >> > > > > > windows and at least fairly trivial (installing a few
> >> packages on
> >> > > > > > Linux[0]). I think it is time we removed the with.awt.swing
> >> flag.
> >> > > > > > Anyone object?
> >> > > > >
> >> > > > > To the contrary, ditch it.
> >> > > > >
> >> > > > > > Please test the current setup with -Dwith.awt.swing=true and
> >> report any
> >> > > > > > problems.
> >> > > > >
> >> > > > > Problem 1: My machine is too slow running all these tests.
> >> > > >
> >> > > > Mine too. And I have wondered if the hourly builds will finish
> >> within
> >> > > > the hour now. We really should see if we can avoid the need to
> >> fork
> >> > > > for every test.
> >> > >
> >> > > I've run the tests on my XP machine, 1 failed
> >> > >
> >> > > javax.swing.TransferHandlerTest#testCreateTransferable
> >> > >
> >> > > java.lang.NullPointerException at
> >> > >
> >> javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
> >>
> >> > > at
> >> java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> >> > > at
> >> javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
> >> > > at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
> >> > > java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
> >> > > at
> >> java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
> >> > > java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
> >> > > java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
> >> > >
> >> java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
> >> > > at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)
> >> > >
> >>
> >> --
> >> Alexei Zakharov,
> >> Intel Middleware Product Division
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
> --
>
> Tim Ellison (t.p.ellison@gmail.com)
> IBM Java technology centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default
Posted by Tim Ellison <t....@gmail.com>.
So what happens to the patch on HARMONY-1723. Do you (Oleg & Alexey)
think we should not fix it that way now?
Regards,
Tim
Oleg Khaschansky wrote:
> Alexey,
>
> Agree. I haven't noticed that RI doesn't accept invalid write method.
> Then its behavior looks illogical. Actually, I asked about comments
> especially because I expected a feedback from beans authors. Thank
> you.
>
> On the other hand, why don't we allow Harmony to accept invalid names
> and provide a default replacements for them if there is a set/get/is
> method for the specified property? It seems to me more user-friendly
> then throw IntrospectionException in this situation. It looks like the
> specification doesn't require PropertyDescriptor to throw an exception
> in this case. This will also prevent us from breaking applications
> that uses this RI behavior.
> What is your opinion?
>
> On 10/5/06, Alexei Zakharov <al...@gmail.com> wrote:
>> Oleg,
>>
>> > + we need to fix in beans the fact that the following code:
>> > new PropertyDescriptor(propertyName, c.getClass(), "1", null);
>> > will throw IntrospectionException on Harmony, but will return the
>> > valid property descriptor with the getter method on RI.
>> > Any thoughts on this? Or should I proceed with a patch for the both
>> issues?
>>
>> I've already written my thoughts about this issue in [1]. In short: I
>> don't think we should follow the RI behavior since it is inconsistent.
>> Why it accepts invalid read method and throws exception on invalid
>> write method? No logic.
>>
>> [1]
>> http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200609.mbox/%3c2c9597b90609190451g74fec356k2270f515dc5e7ef6@mail.gmail.com%3e
>>
>>
>> Thanks,
>>
>> 2006/10/4, Oleg Khaschansky <ol...@gmail.com>:
>> > I found the reason of this failure. It is an IntrospectionException
>> > while executing a following method from the TransferHandler class:
>> >
>> > private PropertyDescriptor getPropertyDescriptor(final JComponent
>> c) {
>> > PropertyDescriptor result = null;
>> > try {
>> > result = new PropertyDescriptor(propertyName, c.getClass());
>> > } catch (IntrospectionException e) {
>> >
>> > }
>> > return result;
>> > }
>> > It tries to get the PropertyDescriptor for the class JButton and
>> > property name "insets", but fails because there's no setInsets method.
>> > So, flavors array stays uninitialized and getTransferDataFlavors
>> > method returns null which is a cause of a NPE.
>> >
>> > The quick fix for this issue could be changing this method to the
>> following:
>> >
>> > private PropertyDescriptor getPropertyDescriptor(final JComponent
>> c) {
>> > PropertyDescriptor result = null;
>> > try {
>> > return result = new PropertyDescriptor(propertyName,
>> c.getClass());
>> > } catch (IntrospectionException e) {
>> > }
>> > try {
>> > return result = new PropertyDescriptor(propertyName,
>> > c.getClass(), "1", null);
>> > } catch (IntrospectionException e) {
>> > }
>> > return result;
>> > }
>> >
>> > + we need to fix in beans the fact that the following code:
>> >
>> > new PropertyDescriptor(propertyName, c.getClass(), "1", null);
>> >
>> > will throw IntrospectionException on Harmony, but will return the
>> > valid property descriptor with the getter method on RI.
>> >
>> > Any thoughts on this? Or should I proceed with a patch for the both
>> issues?
>> >
>> > Thanks,
>> > Oleg
>> >
>> > On 10/4/06, Mikhail Loenko <ml...@gmail.com> wrote:
>> > > 2006/10/4, Mark Hindess <ma...@googlemail.com>:
>> > > >
>> > > > On 4 October 2006 at 15:41, Tim Ellison <t....@gmail.com>
>> wrote:
>> > > > > Excuse the change in subject line...
>> > > >
>> > > > No problem. I was just cursing myself for having forgotten to
>> change
>> > > > it.
>> > > >
>> > > > > Mark Hindess wrote:
>> > > > > > With this change, the awt dependencies should now be
>> automated for
>> > > > > > windows and at least fairly trivial (installing a few
>> packages on
>> > > > > > Linux[0]). I think it is time we removed the with.awt.swing
>> flag.
>> > > > > > Anyone object?
>> > > > >
>> > > > > To the contrary, ditch it.
>> > > > >
>> > > > > > Please test the current setup with -Dwith.awt.swing=true and
>> report any
>> > > > > > problems.
>> > > > >
>> > > > > Problem 1: My machine is too slow running all these tests.
>> > > >
>> > > > Mine too. And I have wondered if the hourly builds will finish
>> within
>> > > > the hour now. We really should see if we can avoid the need to
>> fork
>> > > > for every test.
>> > >
>> > > I've run the tests on my XP machine, 1 failed
>> > >
>> > > javax.swing.TransferHandlerTest#testCreateTransferable
>> > >
>> > > java.lang.NullPointerException at
>> > >
>> javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
>>
>> > > at
>> java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
>> > > at
>> javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
>> > > at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
>> > > java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
>> > > at
>> java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
>> > > java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
>> > > java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
>> > >
>> java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
>> > > at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)
>> > >
>>
>> --
>> Alexei Zakharov,
>> Intel Middleware Product Division
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml)
Posted by Oleg Khaschansky <ol...@gmail.com>.
Alexey,
Agree. I haven't noticed that RI doesn't accept invalid write method.
Then its behavior looks illogical. Actually, I asked about comments
especially because I expected a feedback from beans authors. Thank
you.
On the other hand, why don't we allow Harmony to accept invalid names
and provide a default replacements for them if there is a set/get/is
method for the specified property? It seems to me more user-friendly
then throw IntrospectionException in this situation. It looks like the
specification doesn't require PropertyDescriptor to throw an exception
in this case. This will also prevent us from breaking applications
that uses this RI behavior.
What is your opinion?
On 10/5/06, Alexei Zakharov <al...@gmail.com> wrote:
> Oleg,
>
> > + we need to fix in beans the fact that the following code:
> > new PropertyDescriptor(propertyName, c.getClass(), "1", null);
> > will throw IntrospectionException on Harmony, but will return the
> > valid property descriptor with the getter method on RI.
> > Any thoughts on this? Or should I proceed with a patch for the both issues?
>
> I've already written my thoughts about this issue in [1]. In short: I
> don't think we should follow the RI behavior since it is inconsistent.
> Why it accepts invalid read method and throws exception on invalid
> write method? No logic.
>
> [1] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200609.mbox/%3c2c9597b90609190451g74fec356k2270f515dc5e7ef6@mail.gmail.com%3e
>
> Thanks,
>
> 2006/10/4, Oleg Khaschansky <ol...@gmail.com>:
> > I found the reason of this failure. It is an IntrospectionException
> > while executing a following method from the TransferHandler class:
> >
> > private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
> > PropertyDescriptor result = null;
> > try {
> > result = new PropertyDescriptor(propertyName, c.getClass());
> > } catch (IntrospectionException e) {
> >
> > }
> > return result;
> > }
> > It tries to get the PropertyDescriptor for the class JButton and
> > property name "insets", but fails because there's no setInsets method.
> > So, flavors array stays uninitialized and getTransferDataFlavors
> > method returns null which is a cause of a NPE.
> >
> > The quick fix for this issue could be changing this method to the following:
> >
> > private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
> > PropertyDescriptor result = null;
> > try {
> > return result = new PropertyDescriptor(propertyName, c.getClass());
> > } catch (IntrospectionException e) {
> > }
> > try {
> > return result = new PropertyDescriptor(propertyName,
> > c.getClass(), "1", null);
> > } catch (IntrospectionException e) {
> > }
> > return result;
> > }
> >
> > + we need to fix in beans the fact that the following code:
> >
> > new PropertyDescriptor(propertyName, c.getClass(), "1", null);
> >
> > will throw IntrospectionException on Harmony, but will return the
> > valid property descriptor with the getter method on RI.
> >
> > Any thoughts on this? Or should I proceed with a patch for the both issues?
> >
> > Thanks,
> > Oleg
> >
> > On 10/4/06, Mikhail Loenko <ml...@gmail.com> wrote:
> > > 2006/10/4, Mark Hindess <ma...@googlemail.com>:
> > > >
> > > > On 4 October 2006 at 15:41, Tim Ellison <t....@gmail.com> wrote:
> > > > > Excuse the change in subject line...
> > > >
> > > > No problem. I was just cursing myself for having forgotten to change
> > > > it.
> > > >
> > > > > Mark Hindess wrote:
> > > > > > With this change, the awt dependencies should now be automated for
> > > > > > windows and at least fairly trivial (installing a few packages on
> > > > > > Linux[0]). I think it is time we removed the with.awt.swing flag.
> > > > > > Anyone object?
> > > > >
> > > > > To the contrary, ditch it.
> > > > >
> > > > > > Please test the current setup with -Dwith.awt.swing=true and report any
> > > > > > problems.
> > > > >
> > > > > Problem 1: My machine is too slow running all these tests.
> > > >
> > > > Mine too. And I have wondered if the hourly builds will finish within
> > > > the hour now. We really should see if we can avoid the need to fork
> > > > for every test.
> > >
> > > I've run the tests on my XP machine, 1 failed
> > >
> > > javax.swing.TransferHandlerTest#testCreateTransferable
> > >
> > > java.lang.NullPointerException at
> > > javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
> > > at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> > > at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
> > > at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
> > > java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
> > > at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
> > > java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
> > > java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
> > > java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
> > > at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)
> > >
>
> --
> Alexei Zakharov,
> Intel Middleware Product Division
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml)
Posted by Alexei Zakharov <al...@gmail.com>.
Oleg,
> + we need to fix in beans the fact that the following code:
> new PropertyDescriptor(propertyName, c.getClass(), "1", null);
> will throw IntrospectionException on Harmony, but will return the
> valid property descriptor with the getter method on RI.
> Any thoughts on this? Or should I proceed with a patch for the both issues?
I've already written my thoughts about this issue in [1]. In short: I
don't think we should follow the RI behavior since it is inconsistent.
Why it accepts invalid read method and throws exception on invalid
write method? No logic.
[1] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200609.mbox/%3c2c9597b90609190451g74fec356k2270f515dc5e7ef6@mail.gmail.com%3e
Thanks,
2006/10/4, Oleg Khaschansky <ol...@gmail.com>:
> I found the reason of this failure. It is an IntrospectionException
> while executing a following method from the TransferHandler class:
>
> private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
> PropertyDescriptor result = null;
> try {
> result = new PropertyDescriptor(propertyName, c.getClass());
> } catch (IntrospectionException e) {
>
> }
> return result;
> }
> It tries to get the PropertyDescriptor for the class JButton and
> property name "insets", but fails because there's no setInsets method.
> So, flavors array stays uninitialized and getTransferDataFlavors
> method returns null which is a cause of a NPE.
>
> The quick fix for this issue could be changing this method to the following:
>
> private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
> PropertyDescriptor result = null;
> try {
> return result = new PropertyDescriptor(propertyName, c.getClass());
> } catch (IntrospectionException e) {
> }
> try {
> return result = new PropertyDescriptor(propertyName,
> c.getClass(), "1", null);
> } catch (IntrospectionException e) {
> }
> return result;
> }
>
> + we need to fix in beans the fact that the following code:
>
> new PropertyDescriptor(propertyName, c.getClass(), "1", null);
>
> will throw IntrospectionException on Harmony, but will return the
> valid property descriptor with the getter method on RI.
>
> Any thoughts on this? Or should I proceed with a patch for the both issues?
>
> Thanks,
> Oleg
>
> On 10/4/06, Mikhail Loenko <ml...@gmail.com> wrote:
> > 2006/10/4, Mark Hindess <ma...@googlemail.com>:
> > >
> > > On 4 October 2006 at 15:41, Tim Ellison <t....@gmail.com> wrote:
> > > > Excuse the change in subject line...
> > >
> > > No problem. I was just cursing myself for having forgotten to change
> > > it.
> > >
> > > > Mark Hindess wrote:
> > > > > With this change, the awt dependencies should now be automated for
> > > > > windows and at least fairly trivial (installing a few packages on
> > > > > Linux[0]). I think it is time we removed the with.awt.swing flag.
> > > > > Anyone object?
> > > >
> > > > To the contrary, ditch it.
> > > >
> > > > > Please test the current setup with -Dwith.awt.swing=true and report any
> > > > > problems.
> > > >
> > > > Problem 1: My machine is too slow running all these tests.
> > >
> > > Mine too. And I have wondered if the hourly builds will finish within
> > > the hour now. We really should see if we can avoid the need to fork
> > > for every test.
> >
> > I've run the tests on my XP machine, 1 failed
> >
> > javax.swing.TransferHandlerTest#testCreateTransferable
> >
> > java.lang.NullPointerException at
> > javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
> > at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> > at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
> > at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
> > java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
> > at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
> > java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
> > java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
> > java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
> > at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)
> >
--
Alexei Zakharov,
Intel Middleware Product Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml)
Posted by Oleg Khaschansky <ol...@gmail.com>.
I found the reason of this failure. It is an IntrospectionException
while executing a following method from the TransferHandler class:
private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
PropertyDescriptor result = null;
try {
result = new PropertyDescriptor(propertyName, c.getClass());
} catch (IntrospectionException e) {
}
return result;
}
It tries to get the PropertyDescriptor for the class JButton and
property name "insets", but fails because there's no setInsets method.
So, flavors array stays uninitialized and getTransferDataFlavors
method returns null which is a cause of a NPE.
The quick fix for this issue could be changing this method to the following:
private PropertyDescriptor getPropertyDescriptor(final JComponent c) {
PropertyDescriptor result = null;
try {
return result = new PropertyDescriptor(propertyName, c.getClass());
} catch (IntrospectionException e) {
}
try {
return result = new PropertyDescriptor(propertyName,
c.getClass(), "1", null);
} catch (IntrospectionException e) {
}
return result;
}
+ we need to fix in beans the fact that the following code:
new PropertyDescriptor(propertyName, c.getClass(), "1", null);
will throw IntrospectionException on Harmony, but will return the
valid property descriptor with the getter method on RI.
Any thoughts on this? Or should I proceed with a patch for the both issues?
Thanks,
Oleg
On 10/4/06, Mikhail Loenko <ml...@gmail.com> wrote:
> 2006/10/4, Mark Hindess <ma...@googlemail.com>:
> >
> > On 4 October 2006 at 15:41, Tim Ellison <t....@gmail.com> wrote:
> > > Excuse the change in subject line...
> >
> > No problem. I was just cursing myself for having forgotten to change
> > it.
> >
> > > Mark Hindess wrote:
> > > > With this change, the awt dependencies should now be automated for
> > > > windows and at least fairly trivial (installing a few packages on
> > > > Linux[0]). I think it is time we removed the with.awt.swing flag.
> > > > Anyone object?
> > >
> > > To the contrary, ditch it.
> > >
> > > > Please test the current setup with -Dwith.awt.swing=true and report any
> > > > problems.
> > >
> > > Problem 1: My machine is too slow running all these tests.
> >
> > Mine too. And I have wondered if the hourly builds will finish within
> > the hour now. We really should see if we can avoid the need to fork
> > for every test.
>
> I've run the tests on my XP machine, 1 failed
>
> javax.swing.TransferHandlerTest#testCreateTransferable
>
> java.lang.NullPointerException at
> javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
> at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
> java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
> at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
> java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
> java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
> java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
> at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)
>
> Thanks,
> Mikhail
>
>
> >
> > Regards,
> > Mark.
> >
> > > Regards,
> > > Tim
> > >
> > > > [0] Details of the required packages for distributions other than
> > > > Debian/Ubuntu would be welcome.
> > > >
> > > > On 4 October 2006 at 10:24, hindessm@apache.org wrote:
> > > >> Author: hindessm
> > > >> Date: Wed Oct 4 03:24:29 2006
> > > >> New Revision: 452826
> > > >>
> > > >> URL: http://svn.apache.org/viewvc?view=rev&rev=452826
> > > >> Log:
> > > >> Update check/fetch depends targets to handle the awt dependencies.
> > > >>
> > > >> Modified:
> > > >> incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ (props
> > > ch
> > > >> anged)
> > > >> incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/
> > > (pr
> > > >> ops changed)
> > > >> incubator/harmony/enhanced/classlib/trunk/make/depends.properties
> > > >> incubator/harmony/enhanced/classlib/trunk/make/depends.xml
> > > >>
> > > >> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
> > > >> --------------------------------------------------------------------------
> > > ---
> > > >> -
> > > >> --- svn:ignore (original)
> > > >> +++ svn:ignore Wed Oct 4 03:24:29 2006
> > > >> @@ -1,3 +1,4 @@
> > > >> jpeg
> > > >> lcms
> > > >> png
> > > >> +winxp_2006-09-28.txt
> > > >>
> > > >> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows
> > > .x8
> > > >> 6/
> > > >> --------------------------------------------------------------------------
> > > ---
> > > >> -
> > > >> --- svn:ignore (original)
> > > >> +++ svn:ignore Wed Oct 4 03:24:29 2006
> > > >> @@ -1 +1,2 @@
> > > >> msvcr71.dll
> > > >> +swing_awt_deps_winxp_2006-09-28.tgz
> > > >>
> > > >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.propertie
> > > s
> > > >> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
> > > k/m
> > > >> ake/depends.properties?view=diff&rev=452826&r1=452825&r2=452826
> > > >> ==========================================================================
> > > ===
> > > >> =
> > > >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (ori
> > > gin
> > > >> al)
> > > >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed
> > > Oct
> > > >> 4 03:24:29 2006
> > > >> @@ -98,3 +98,11 @@
> > > >> servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
> > > >> servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
> > > >> servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servle
> > > t-a
> > > >> pi-2.5-6.0.0.jar
> > > >> +
> > > >> +people.apache.base=http://people.apache.org/~geirm/harmony/
> > > >> +awtdeps.dir=${depends.dir}/libs/windows.x86
> > > >> +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
> > > >> +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
> > > >> +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
> > > >> +awtdeps.extract.dir=${depends.dir}/libs/build
> > > >> +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
> > > >>
> > > >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
> > > >> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
> > > k/m
> > > >> ake/depends.xml?view=diff&rev=452826&r1=452825&r2=452826
> > > >> ==========================================================================
> > > ===
> > > >> =
> > > >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
> > > >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct 4
> > > 03:
> > > >> 24:29 2006
> > > >> @@ -72,17 +72,22 @@
> > > >>
> > > >> </target>
> > > >>
> > > >> - <target name="-check-win" if="is.windows">
> > > >> + <target name="-check-win" if="is.windows"
> > > >> + depends="-really-check-win,-awt-tar-extract" />
> > > >> +
> > > >> + <target name="-really-check-win" if="is.windows">
> > > >>
> > > >> <check-one-file src="${msvcr71.url}" dest="${msvcr71.dll}" />
> > > >>
> > > >> - </target>
> > > >> + <check-one-file src="${awtdeps.url}" dest="${awtdeps.tar}" />
> > > >> +
> > > >> + <uptodate property="awtdeps.uptodate"
> > > >> + srcfile="${awtdeps.tar}"
> > > >> + targetfile="${awtdeps.testfile}" />
> > > >>
> > > >> - <target name="-check-unix" if="with.awt.swing">
> > > >> - <antcall target="--check-unix" />
> > > >> </target>
> > > >>
> > > >> - <target name="--check-unix" if="is.unix">
> > > >> + <target name="-check-unix" if="is.unix">
> > > >>
> > > >> <property name="lcms.msg"
> > > >> value="liblcms development package not installed
> > > >> @@ -214,6 +219,10 @@
> > > >> <download-one-file src="${msvcr71.url}" dest="${msvcr71.dll}"
> > > >> md5="${msvcr71.md5}" />
> > > >>
> > > >> + <mkdir dir="${awtdeps.dir}" />
> > > >> + <download-one-file src="${awtdeps.url}" dest="${awtdeps.tar}"
> > > >> + md5="${awtdeps.md5}" />
> > > >> +
> > > >> </target>
> > > >>
> > > >> <macrodef name="download-one-file">
> > > >> @@ -298,6 +307,14 @@
> > > >> <jar destfile="${bcprov.jar}" basedir="${bcprov.dir}/temp"
> > > >> manifest="${bcprov.dir}/temp/META-INF/MANIFEST.MF" />
> > > >> <delete dir="${bcprov.dir}/temp" />
> > > >> + </target>
> > > >> +
> > > >> + <target name="-awt-tar-extract" unless="awtdeps.uptodate">
> > > >> + <echo>Extracting awt dependencies</echo>
> > > >> + <untar src="${awtdeps.tar}" dest="${awtdeps.extract.dir}"
> > > >> + compression="gzip" />
> > > >> + <echo file="${awtdeps.testfile}"
> > > >> + message="${awtdeps.tar} extracted${line.separator}" />
> > > >> </target>
> > > >>
> > > >> <macrodef name="check-one-link">
> > > >>
> > > >
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > >
> > > >
> > >
> > > --
> > >
> > > Tim Ellison (t.p.ellison@gmail.com)
> > > IBM Java technology centre, UK.
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> >
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default
Posted by Tim Ellison <t....@gmail.com>.
ah, just read this after posting the same note myself.
So yes, I see the same.
Regards,
Tim
Mikhail Loenko wrote:
> 2006/10/4, Mark Hindess <ma...@googlemail.com>:
>>
>> On 4 October 2006 at 15:41, Tim Ellison <t....@gmail.com> wrote:
>> > Excuse the change in subject line...
>>
>> No problem. I was just cursing myself for having forgotten to change
>> it.
>>
>> > Mark Hindess wrote:
>> > > With this change, the awt dependencies should now be automated for
>> > > windows and at least fairly trivial (installing a few packages on
>> > > Linux[0]). I think it is time we removed the with.awt.swing flag.
>> > > Anyone object?
>> >
>> > To the contrary, ditch it.
>> >
>> > > Please test the current setup with -Dwith.awt.swing=true and
>> report any
>> > > problems.
>> >
>> > Problem 1: My machine is too slow running all these tests.
>>
>> Mine too. And I have wondered if the hourly builds will finish within
>> the hour now. We really should see if we can avoid the need to fork
>> for every test.
>
> I've run the tests on my XP machine, 1 failed
>
> javax.swing.TransferHandlerTest#testCreateTransferable
>
> java.lang.NullPointerException at
> javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
>
> at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
> at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
> java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
> at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
> java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
> java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
> java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
> at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)
>
> Thanks,
> Mikhail
>
>
>>
>> Regards,
>> Mark.
>>
>> > Regards,
>> > Tim
>> >
>> > > [0] Details of the required packages for distributions other than
>> > > Debian/Ubuntu would be welcome.
>> > >
>> > > On 4 October 2006 at 10:24, hindessm@apache.org wrote:
>> > >> Author: hindessm
>> > >> Date: Wed Oct 4 03:24:29 2006
>> > >> New Revision: 452826
>> > >>
>> > >> URL: http://svn.apache.org/viewvc?view=rev&rev=452826
>> > >> Log:
>> > >> Update check/fetch depends targets to handle the awt dependencies.
>> > >>
>> > >> Modified:
>> > >>
>> incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ (props
>> > ch
>> > >> anged)
>> > >>
>> incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/
>> > (pr
>> > >> ops changed)
>> > >>
>> incubator/harmony/enhanced/classlib/trunk/make/depends.properties
>> > >> incubator/harmony/enhanced/classlib/trunk/make/depends.xml
>> > >>
>> > >> Propchange:
>> incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
>> > >>
>> --------------------------------------------------------------------------
>>
>> > ---
>> > >> -
>> > >> --- svn:ignore (original)
>> > >> +++ svn:ignore Wed Oct 4 03:24:29 2006
>> > >> @@ -1,3 +1,4 @@
>> > >> jpeg
>> > >> lcms
>> > >> png
>> > >> +winxp_2006-09-28.txt
>> > >>
>> > >> Propchange:
>> incubator/harmony/enhanced/classlib/trunk/depends/libs/windows
>> > .x8
>> > >> 6/
>> > >>
>> --------------------------------------------------------------------------
>>
>> > ---
>> > >> -
>> > >> --- svn:ignore (original)
>> > >> +++ svn:ignore Wed Oct 4 03:24:29 2006
>> > >> @@ -1 +1,2 @@
>> > >> msvcr71.dll
>> > >> +swing_awt_deps_winxp_2006-09-28.tgz
>> > >>
>> > >> Modified:
>> incubator/harmony/enhanced/classlib/trunk/make/depends.propertie
>> > s
>> > >> URL:
>> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
>> > k/m
>> > >> ake/depends.properties?view=diff&rev=452826&r1=452825&r2=452826
>> > >>
>> ==========================================================================
>>
>> > ===
>> > >> =
>> > >> ---
>> incubator/harmony/enhanced/classlib/trunk/make/depends.properties (ori
>> > gin
>> > >> al)
>> > >> +++
>> incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed
>> > Oct
>> > >> 4 03:24:29 2006
>> > >> @@ -98,3 +98,11 @@
>> > >> servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
>> > >> servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
>> > >>
>> servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servle
>> > t-a
>> > >> pi-2.5-6.0.0.jar
>> > >> +
>> > >> +people.apache.base=http://people.apache.org/~geirm/harmony/
>> > >> +awtdeps.dir=${depends.dir}/libs/windows.x86
>> > >> +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
>> > >>
>> +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
>> > >> +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
>> > >> +awtdeps.extract.dir=${depends.dir}/libs/build
>> > >> +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
>> > >>
>> > >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
>> > >> URL:
>> http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
>> > k/m
>> > >> ake/depends.xml?view=diff&rev=452826&r1=452825&r2=452826
>> > >>
>> ==========================================================================
>>
>> > ===
>> > >> =
>> > >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml
>> (original)
>> > >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml
>> Wed Oct 4
>> > 03:
>> > >> 24:29 2006
>> > >> @@ -72,17 +72,22 @@
>> > >>
>> > >> </target>
>> > >>
>> > >> - <target name="-check-win" if="is.windows">
>> > >> + <target name="-check-win" if="is.windows"
>> > >> + depends="-really-check-win,-awt-tar-extract" />
>> > >> +
>> > >> + <target name="-really-check-win" if="is.windows">
>> > >>
>> > >> <check-one-file src="${msvcr71.url}" dest="${msvcr71.dll}" />
>> > >>
>> > >> - </target>
>> > >> + <check-one-file src="${awtdeps.url}"
>> dest="${awtdeps.tar}" />
>> > >> +
>> > >> + <uptodate property="awtdeps.uptodate"
>> > >> + srcfile="${awtdeps.tar}"
>> > >> + targetfile="${awtdeps.testfile}" />
>> > >>
>> > >> - <target name="-check-unix" if="with.awt.swing">
>> > >> - <antcall target="--check-unix" />
>> > >> </target>
>> > >>
>> > >> - <target name="--check-unix" if="is.unix">
>> > >> + <target name="-check-unix" if="is.unix">
>> > >>
>> > >> <property name="lcms.msg"
>> > >> value="liblcms development package not installed
>> > >> @@ -214,6 +219,10 @@
>> > >> <download-one-file src="${msvcr71.url}" dest="${msvcr71.dll}"
>> > >> md5="${msvcr71.md5}" />
>> > >>
>> > >> + <mkdir dir="${awtdeps.dir}" />
>> > >> + <download-one-file src="${awtdeps.url}" dest="${awtdeps.tar}"
>> > >> + md5="${awtdeps.md5}" />
>> > >> +
>> > >> </target>
>> > >>
>> > >> <macrodef name="download-one-file">
>> > >> @@ -298,6 +307,14 @@
>> > >> <jar destfile="${bcprov.jar}" basedir="${bcprov.dir}/temp"
>> > >> manifest="${bcprov.dir}/temp/META-INF/MANIFEST.MF" />
>> > >> <delete dir="${bcprov.dir}/temp" />
>> > >> + </target>
>> > >> +
>> > >> + <target name="-awt-tar-extract" unless="awtdeps.uptodate">
>> > >> + <echo>Extracting awt dependencies</echo>
>> > >> + <untar src="${awtdeps.tar}" dest="${awtdeps.extract.dir}"
>> > >> + compression="gzip" />
>> > >> + <echo file="${awtdeps.testfile}"
>> > >> + message="${awtdeps.tar}
>> extracted${line.separator}" />
>> > >> </target>
>> > >>
>> > >> <macrodef name="check-one-link">
>> > >>
>> > >
>> > >
>> > >
>> > > ---------------------------------------------------------------------
>> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> > > For additional commands, e-mail:
>> harmony-dev-help@incubator.apache.org
>> > >
>> > >
>> >
>> > --
>> >
>> > Tim Ellison (t.p.ellison@gmail.com)
>> > IBM Java technology centre, UK.
>> >
>> > ---------------------------------------------------------------------
>> > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>> >
>>
>>
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml)
Posted by Mikhail Loenko <ml...@gmail.com>.
2006/10/4, Mark Hindess <ma...@googlemail.com>:
>
> On 4 October 2006 at 15:41, Tim Ellison <t....@gmail.com> wrote:
> > Excuse the change in subject line...
>
> No problem. I was just cursing myself for having forgotten to change
> it.
>
> > Mark Hindess wrote:
> > > With this change, the awt dependencies should now be automated for
> > > windows and at least fairly trivial (installing a few packages on
> > > Linux[0]). I think it is time we removed the with.awt.swing flag.
> > > Anyone object?
> >
> > To the contrary, ditch it.
> >
> > > Please test the current setup with -Dwith.awt.swing=true and report any
> > > problems.
> >
> > Problem 1: My machine is too slow running all these tests.
>
> Mine too. And I have wondered if the hourly builds will finish within
> the hour now. We really should see if we can avoid the need to fork
> for every test.
I've run the tests on my XP machine, 1 failed
javax.swing.TransferHandlerTest#testCreateTransferable
java.lang.NullPointerException at
javax.swing.TransferHandlerTest.testCreateTransferable(TransferHandlerTest.java:140)
at java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
at javax.swing.BasicSwingTestCase.runBareSuper(BasicSwingTestCase.java:115)
at javax.swing.SwingTestCase$1.run(SwingTestCase.java:44) at
java.awt.event.InvocationEvent.runAndNotify(InvocationEvent.java:88)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:77) at
java.awt.EventQueueCore.dispatchEventImpl(EventQueueCore.java:131) at
java.awt.EventQueue.dispatchEvent(EventQueue.java:144) at
java.awt.EventDispatchThread.runModalLoop(EventDispatchThread.java:75)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:48)
Thanks,
Mikhail
>
> Regards,
> Mark.
>
> > Regards,
> > Tim
> >
> > > [0] Details of the required packages for distributions other than
> > > Debian/Ubuntu would be welcome.
> > >
> > > On 4 October 2006 at 10:24, hindessm@apache.org wrote:
> > >> Author: hindessm
> > >> Date: Wed Oct 4 03:24:29 2006
> > >> New Revision: 452826
> > >>
> > >> URL: http://svn.apache.org/viewvc?view=rev&rev=452826
> > >> Log:
> > >> Update check/fetch depends targets to handle the awt dependencies.
> > >>
> > >> Modified:
> > >> incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ (props
> > ch
> > >> anged)
> > >> incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/
> > (pr
> > >> ops changed)
> > >> incubator/harmony/enhanced/classlib/trunk/make/depends.properties
> > >> incubator/harmony/enhanced/classlib/trunk/make/depends.xml
> > >>
> > >> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
> > >> --------------------------------------------------------------------------
> > ---
> > >> -
> > >> --- svn:ignore (original)
> > >> +++ svn:ignore Wed Oct 4 03:24:29 2006
> > >> @@ -1,3 +1,4 @@
> > >> jpeg
> > >> lcms
> > >> png
> > >> +winxp_2006-09-28.txt
> > >>
> > >> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows
> > .x8
> > >> 6/
> > >> --------------------------------------------------------------------------
> > ---
> > >> -
> > >> --- svn:ignore (original)
> > >> +++ svn:ignore Wed Oct 4 03:24:29 2006
> > >> @@ -1 +1,2 @@
> > >> msvcr71.dll
> > >> +swing_awt_deps_winxp_2006-09-28.tgz
> > >>
> > >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.propertie
> > s
> > >> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
> > k/m
> > >> ake/depends.properties?view=diff&rev=452826&r1=452825&r2=452826
> > >> ==========================================================================
> > ===
> > >> =
> > >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (ori
> > gin
> > >> al)
> > >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed
> > Oct
> > >> 4 03:24:29 2006
> > >> @@ -98,3 +98,11 @@
> > >> servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
> > >> servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
> > >> servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servle
> > t-a
> > >> pi-2.5-6.0.0.jar
> > >> +
> > >> +people.apache.base=http://people.apache.org/~geirm/harmony/
> > >> +awtdeps.dir=${depends.dir}/libs/windows.x86
> > >> +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
> > >> +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
> > >> +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
> > >> +awtdeps.extract.dir=${depends.dir}/libs/build
> > >> +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
> > >>
> > >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
> > >> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
> > k/m
> > >> ake/depends.xml?view=diff&rev=452826&r1=452825&r2=452826
> > >> ==========================================================================
> > ===
> > >> =
> > >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
> > >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct 4
> > 03:
> > >> 24:29 2006
> > >> @@ -72,17 +72,22 @@
> > >>
> > >> </target>
> > >>
> > >> - <target name="-check-win" if="is.windows">
> > >> + <target name="-check-win" if="is.windows"
> > >> + depends="-really-check-win,-awt-tar-extract" />
> > >> +
> > >> + <target name="-really-check-win" if="is.windows">
> > >>
> > >> <check-one-file src="${msvcr71.url}" dest="${msvcr71.dll}" />
> > >>
> > >> - </target>
> > >> + <check-one-file src="${awtdeps.url}" dest="${awtdeps.tar}" />
> > >> +
> > >> + <uptodate property="awtdeps.uptodate"
> > >> + srcfile="${awtdeps.tar}"
> > >> + targetfile="${awtdeps.testfile}" />
> > >>
> > >> - <target name="-check-unix" if="with.awt.swing">
> > >> - <antcall target="--check-unix" />
> > >> </target>
> > >>
> > >> - <target name="--check-unix" if="is.unix">
> > >> + <target name="-check-unix" if="is.unix">
> > >>
> > >> <property name="lcms.msg"
> > >> value="liblcms development package not installed
> > >> @@ -214,6 +219,10 @@
> > >> <download-one-file src="${msvcr71.url}" dest="${msvcr71.dll}"
> > >> md5="${msvcr71.md5}" />
> > >>
> > >> + <mkdir dir="${awtdeps.dir}" />
> > >> + <download-one-file src="${awtdeps.url}" dest="${awtdeps.tar}"
> > >> + md5="${awtdeps.md5}" />
> > >> +
> > >> </target>
> > >>
> > >> <macrodef name="download-one-file">
> > >> @@ -298,6 +307,14 @@
> > >> <jar destfile="${bcprov.jar}" basedir="${bcprov.dir}/temp"
> > >> manifest="${bcprov.dir}/temp/META-INF/MANIFEST.MF" />
> > >> <delete dir="${bcprov.dir}/temp" />
> > >> + </target>
> > >> +
> > >> + <target name="-awt-tar-extract" unless="awtdeps.uptodate">
> > >> + <echo>Extracting awt dependencies</echo>
> > >> + <untar src="${awtdeps.tar}" dest="${awtdeps.extract.dir}"
> > >> + compression="gzip" />
> > >> + <echo file="${awtdeps.testfile}"
> > >> + message="${awtdeps.tar} extracted${line.separator}" />
> > >> </target>
> > >>
> > >> <macrodef name="check-one-link">
> > >>
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> > --
> >
> > Tim Ellison (t.p.ellison@gmail.com)
> > IBM Java technology centre, UK.
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default
Posted by Mikhail Loenko <ml...@gmail.com>.
2006/10/4, Geir Magnusson Jr. <ge...@pobox.com>:
>
>
> Mark Hindess wrote:
> > On 4 October 2006 at 15:41, Tim Ellison <t....@gmail.com> wrote:
> >> Excuse the change in subject line...
> >
> > No problem. I was just cursing myself for having forgotten to change
> > it.
> >
> >> Mark Hindess wrote:
> >>> With this change, the awt dependencies should now be automated for
> >>> windows and at least fairly trivial (installing a few packages on
> >>> Linux[0]). I think it is time we removed the with.awt.swing flag.
> >>> Anyone object?
> >> To the contrary, ditch it.
> >>
> >>> Please test the current setup with -Dwith.awt.swing=true and report any
> >>> problems.
> >> Problem 1: My machine is too slow running all these tests.
> >
> > Mine too. And I have wondered if the hourly builds will finish within
> > the hour now. We really should see if we can avoid the need to fork
> > for every test.
>
> LOL. If our tests take more than an hour, so be it...
Do you place workspace on a network? I had similar problems
but once I've put everything locally the tests now run 22 minutes
(with awt&swing)
Thanks,
Mikhail
>
> Or, do a fast test set on one machine to get the earliest warning for
> the most amount of code, and a slower "do it all" machine that acts as a
> safety net
>
> geir
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Mark Hindess wrote:
> On 4 October 2006 at 15:41, Tim Ellison <t....@gmail.com> wrote:
>> Excuse the change in subject line...
>
> No problem. I was just cursing myself for having forgotten to change
> it.
>
>> Mark Hindess wrote:
>>> With this change, the awt dependencies should now be automated for
>>> windows and at least fairly trivial (installing a few packages on
>>> Linux[0]). I think it is time we removed the with.awt.swing flag.
>>> Anyone object?
>> To the contrary, ditch it.
>>
>>> Please test the current setup with -Dwith.awt.swing=true and report any
>>> problems.
>> Problem 1: My machine is too slow running all these tests.
>
> Mine too. And I have wondered if the hourly builds will finish within
> the hour now. We really should see if we can avoid the need to fork
> for every test.
LOL. If our tests take more than an hour, so be it...
Or, do a fast test set on one machine to get the earliest warning for
the most amount of code, and a slower "do it all" machine that acts as a
safety net
geir
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml)
Posted by Mark Hindess <ma...@googlemail.com>.
On 4 October 2006 at 15:41, Tim Ellison <t....@gmail.com> wrote:
> Excuse the change in subject line...
No problem. I was just cursing myself for having forgotten to change
it.
> Mark Hindess wrote:
> > With this change, the awt dependencies should now be automated for
> > windows and at least fairly trivial (installing a few packages on
> > Linux[0]). I think it is time we removed the with.awt.swing flag.
> > Anyone object?
>
> To the contrary, ditch it.
>
> > Please test the current setup with -Dwith.awt.swing=true and report any
> > problems.
>
> Problem 1: My machine is too slow running all these tests.
Mine too. And I have wondered if the hourly builds will finish within
the hour now. We really should see if we can avoid the need to fork
for every test.
Regards,
Mark.
> Regards,
> Tim
>
> > [0] Details of the required packages for distributions other than
> > Debian/Ubuntu would be welcome.
> >
> > On 4 October 2006 at 10:24, hindessm@apache.org wrote:
> >> Author: hindessm
> >> Date: Wed Oct 4 03:24:29 2006
> >> New Revision: 452826
> >>
> >> URL: http://svn.apache.org/viewvc?view=rev&rev=452826
> >> Log:
> >> Update check/fetch depends targets to handle the awt dependencies.
> >>
> >> Modified:
> >> incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ (props
> ch
> >> anged)
> >> incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/
> (pr
> >> ops changed)
> >> incubator/harmony/enhanced/classlib/trunk/make/depends.properties
> >> incubator/harmony/enhanced/classlib/trunk/make/depends.xml
> >>
> >> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
> >> --------------------------------------------------------------------------
> ---
> >> -
> >> --- svn:ignore (original)
> >> +++ svn:ignore Wed Oct 4 03:24:29 2006
> >> @@ -1,3 +1,4 @@
> >> jpeg
> >> lcms
> >> png
> >> +winxp_2006-09-28.txt
> >>
> >> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows
> .x8
> >> 6/
> >> --------------------------------------------------------------------------
> ---
> >> -
> >> --- svn:ignore (original)
> >> +++ svn:ignore Wed Oct 4 03:24:29 2006
> >> @@ -1 +1,2 @@
> >> msvcr71.dll
> >> +swing_awt_deps_winxp_2006-09-28.tgz
> >>
> >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.propertie
> s
> >> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
> k/m
> >> ake/depends.properties?view=diff&rev=452826&r1=452825&r2=452826
> >> ==========================================================================
> ===
> >> =
> >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (ori
> gin
> >> al)
> >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed
> Oct
> >> 4 03:24:29 2006
> >> @@ -98,3 +98,11 @@
> >> servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
> >> servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
> >> servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servle
> t-a
> >> pi-2.5-6.0.0.jar
> >> +
> >> +people.apache.base=http://people.apache.org/~geirm/harmony/
> >> +awtdeps.dir=${depends.dir}/libs/windows.x86
> >> +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
> >> +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
> >> +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
> >> +awtdeps.extract.dir=${depends.dir}/libs/build
> >> +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
> >>
> >> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
> >> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trun
> k/m
> >> ake/depends.xml?view=diff&rev=452826&r1=452825&r2=452826
> >> ==========================================================================
> ===
> >> =
> >> --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
> >> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct 4
> 03:
> >> 24:29 2006
> >> @@ -72,17 +72,22 @@
> >>
> >> </target>
> >>
> >> - <target name="-check-win" if="is.windows">
> >> + <target name="-check-win" if="is.windows"
> >> + depends="-really-check-win,-awt-tar-extract" />
> >> +
> >> + <target name="-really-check-win" if="is.windows">
> >>
> >> <check-one-file src="${msvcr71.url}" dest="${msvcr71.dll}" />
> >>
> >> - </target>
> >> + <check-one-file src="${awtdeps.url}" dest="${awtdeps.tar}" />
> >> +
> >> + <uptodate property="awtdeps.uptodate"
> >> + srcfile="${awtdeps.tar}"
> >> + targetfile="${awtdeps.testfile}" />
> >>
> >> - <target name="-check-unix" if="with.awt.swing">
> >> - <antcall target="--check-unix" />
> >> </target>
> >>
> >> - <target name="--check-unix" if="is.unix">
> >> + <target name="-check-unix" if="is.unix">
> >>
> >> <property name="lcms.msg"
> >> value="liblcms development package not installed
> >> @@ -214,6 +219,10 @@
> >> <download-one-file src="${msvcr71.url}" dest="${msvcr71.dll}"
> >> md5="${msvcr71.md5}" />
> >>
> >> + <mkdir dir="${awtdeps.dir}" />
> >> + <download-one-file src="${awtdeps.url}" dest="${awtdeps.tar}"
> >> + md5="${awtdeps.md5}" />
> >> +
> >> </target>
> >>
> >> <macrodef name="download-one-file">
> >> @@ -298,6 +307,14 @@
> >> <jar destfile="${bcprov.jar}" basedir="${bcprov.dir}/temp"
> >> manifest="${bcprov.dir}/temp/META-INF/MANIFEST.MF" />
> >> <delete dir="${bcprov.dir}/temp" />
> >> + </target>
> >> +
> >> + <target name="-awt-tar-extract" unless="awtdeps.uptodate">
> >> + <echo>Extracting awt dependencies</echo>
> >> + <untar src="${awtdeps.tar}" dest="${awtdeps.extract.dir}"
> >> + compression="gzip" />
> >> + <echo file="${awtdeps.testfile}"
> >> + message="${awtdeps.tar} extracted${line.separator}" />
> >> </target>
> >>
> >> <macrodef name="check-one-link">
> >>
> >
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
> --
>
> Tim Ellison (t.p.ellison@gmail.com)
> IBM Java technology centre, UK.
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [classlib] enabling AWT/Swing by default
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
Tim Ellison wrote:
> Excuse the change in subject line...
>
> Mark Hindess wrote:
>> With this change, the awt dependencies should now be automated for
>> windows and at least fairly trivial (installing a few packages on
>> Linux[0]). I think it is time we removed the with.awt.swing flag.
>> Anyone object?
>
> To the contrary, ditch it.
>
>> Please test the current setup with -Dwith.awt.swing=true and report any
>> problems.
>
> Problem 1: My machine is too slow running all these tests.
That means you probably want to have a flag to not run those tests...
geir
>
> Regards,
> Tim
>
>> [0] Details of the required packages for distributions other than
>> Debian/Ubuntu would be welcome.
>>
>> On 4 October 2006 at 10:24, hindessm@apache.org wrote:
>>> Author: hindessm
>>> Date: Wed Oct 4 03:24:29 2006
>>> New Revision: 452826
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=452826
>>> Log:
>>> Update check/fetch depends targets to handle the awt dependencies.
>>>
>>> Modified:
>>> incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ (props ch
>>> anged)
>>> incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/ (pr
>>> ops changed)
>>> incubator/harmony/enhanced/classlib/trunk/make/depends.properties
>>> incubator/harmony/enhanced/classlib/trunk/make/depends.xml
>>>
>>> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
>>> -----------------------------------------------------------------------------
>>> -
>>> --- svn:ignore (original)
>>> +++ svn:ignore Wed Oct 4 03:24:29 2006
>>> @@ -1,3 +1,4 @@
>>> jpeg
>>> lcms
>>> png
>>> +winxp_2006-09-28.txt
>>>
>>> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x8
>>> 6/
>>> -----------------------------------------------------------------------------
>>> -
>>> --- svn:ignore (original)
>>> +++ svn:ignore Wed Oct 4 03:24:29 2006
>>> @@ -1 +1,2 @@
>>> msvcr71.dll
>>> +swing_awt_deps_winxp_2006-09-28.tgz
>>>
>>> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.properties
>>> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
>>> ake/depends.properties?view=diff&rev=452826&r1=452825&r2=452826
>>> =============================================================================
>>> =
>>> --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (origin
>>> al)
>>> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed Oct
>>> 4 03:24:29 2006
>>> @@ -98,3 +98,11 @@
>>> servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
>>> servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
>>> servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servlet-a
>>> pi-2.5-6.0.0.jar
>>> +
>>> +people.apache.base=http://people.apache.org/~geirm/harmony/
>>> +awtdeps.dir=${depends.dir}/libs/windows.x86
>>> +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
>>> +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
>>> +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
>>> +awtdeps.extract.dir=${depends.dir}/libs/build
>>> +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
>>>
>>> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
>>> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
>>> ake/depends.xml?view=diff&rev=452826&r1=452825&r2=452826
>>> =============================================================================
>>> =
>>> --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
>>> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct 4 03:
>>> 24:29 2006
>>> @@ -72,17 +72,22 @@
>>>
>>> </target>
>>>
>>> - <target name="-check-win" if="is.windows">
>>> + <target name="-check-win" if="is.windows"
>>> + depends="-really-check-win,-awt-tar-extract" />
>>> +
>>> + <target name="-really-check-win" if="is.windows">
>>>
>>> <check-one-file src="${msvcr71.url}" dest="${msvcr71.dll}" />
>>>
>>> - </target>
>>> + <check-one-file src="${awtdeps.url}" dest="${awtdeps.tar}" />
>>> +
>>> + <uptodate property="awtdeps.uptodate"
>>> + srcfile="${awtdeps.tar}"
>>> + targetfile="${awtdeps.testfile}" />
>>>
>>> - <target name="-check-unix" if="with.awt.swing">
>>> - <antcall target="--check-unix" />
>>> </target>
>>>
>>> - <target name="--check-unix" if="is.unix">
>>> + <target name="-check-unix" if="is.unix">
>>>
>>> <property name="lcms.msg"
>>> value="liblcms development package not installed
>>> @@ -214,6 +219,10 @@
>>> <download-one-file src="${msvcr71.url}" dest="${msvcr71.dll}"
>>> md5="${msvcr71.md5}" />
>>>
>>> + <mkdir dir="${awtdeps.dir}" />
>>> + <download-one-file src="${awtdeps.url}" dest="${awtdeps.tar}"
>>> + md5="${awtdeps.md5}" />
>>> +
>>> </target>
>>>
>>> <macrodef name="download-one-file">
>>> @@ -298,6 +307,14 @@
>>> <jar destfile="${bcprov.jar}" basedir="${bcprov.dir}/temp"
>>> manifest="${bcprov.dir}/temp/META-INF/MANIFEST.MF" />
>>> <delete dir="${bcprov.dir}/temp" />
>>> + </target>
>>> +
>>> + <target name="-awt-tar-extract" unless="awtdeps.uptodate">
>>> + <echo>Extracting awt dependencies</echo>
>>> + <untar src="${awtdeps.tar}" dest="${awtdeps.extract.dir}"
>>> + compression="gzip" />
>>> + <echo file="${awtdeps.testfile}"
>>> + message="${awtdeps.tar} extracted${line.separator}" />
>>> </target>
>>>
>>> <macrodef name="check-one-link">
>>>
>>
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
[classlib] enabling AWT/Swing by default (was: Re: svn commit: r452826
- in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/
make/depends.properties make/depends.xml)
Posted by Tim Ellison <t....@gmail.com>.
Excuse the change in subject line...
Mark Hindess wrote:
> With this change, the awt dependencies should now be automated for
> windows and at least fairly trivial (installing a few packages on
> Linux[0]). I think it is time we removed the with.awt.swing flag.
> Anyone object?
To the contrary, ditch it.
> Please test the current setup with -Dwith.awt.swing=true and report any
> problems.
Problem 1: My machine is too slow running all these tests.
Regards,
Tim
> [0] Details of the required packages for distributions other than
> Debian/Ubuntu would be welcome.
>
> On 4 October 2006 at 10:24, hindessm@apache.org wrote:
>> Author: hindessm
>> Date: Wed Oct 4 03:24:29 2006
>> New Revision: 452826
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=452826
>> Log:
>> Update check/fetch depends targets to handle the awt dependencies.
>>
>> Modified:
>> incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ (props ch
>> anged)
>> incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/ (pr
>> ops changed)
>> incubator/harmony/enhanced/classlib/trunk/make/depends.properties
>> incubator/harmony/enhanced/classlib/trunk/make/depends.xml
>>
>> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
>> -----------------------------------------------------------------------------
>> -
>> --- svn:ignore (original)
>> +++ svn:ignore Wed Oct 4 03:24:29 2006
>> @@ -1,3 +1,4 @@
>> jpeg
>> lcms
>> png
>> +winxp_2006-09-28.txt
>>
>> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x8
>> 6/
>> -----------------------------------------------------------------------------
>> -
>> --- svn:ignore (original)
>> +++ svn:ignore Wed Oct 4 03:24:29 2006
>> @@ -1 +1,2 @@
>> msvcr71.dll
>> +swing_awt_deps_winxp_2006-09-28.tgz
>>
>> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.properties
>> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
>> ake/depends.properties?view=diff&rev=452826&r1=452825&r2=452826
>> =============================================================================
>> =
>> --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (origin
>> al)
>> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed Oct
>> 4 03:24:29 2006
>> @@ -98,3 +98,11 @@
>> servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
>> servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
>> servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servlet-a
>> pi-2.5-6.0.0.jar
>> +
>> +people.apache.base=http://people.apache.org/~geirm/harmony/
>> +awtdeps.dir=${depends.dir}/libs/windows.x86
>> +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
>> +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
>> +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
>> +awtdeps.extract.dir=${depends.dir}/libs/build
>> +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
>>
>> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
>> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
>> ake/depends.xml?view=diff&rev=452826&r1=452825&r2=452826
>> =============================================================================
>> =
>> --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
>> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct 4 03:
>> 24:29 2006
>> @@ -72,17 +72,22 @@
>>
>> </target>
>>
>> - <target name="-check-win" if="is.windows">
>> + <target name="-check-win" if="is.windows"
>> + depends="-really-check-win,-awt-tar-extract" />
>> +
>> + <target name="-really-check-win" if="is.windows">
>>
>> <check-one-file src="${msvcr71.url}" dest="${msvcr71.dll}" />
>>
>> - </target>
>> + <check-one-file src="${awtdeps.url}" dest="${awtdeps.tar}" />
>> +
>> + <uptodate property="awtdeps.uptodate"
>> + srcfile="${awtdeps.tar}"
>> + targetfile="${awtdeps.testfile}" />
>>
>> - <target name="-check-unix" if="with.awt.swing">
>> - <antcall target="--check-unix" />
>> </target>
>>
>> - <target name="--check-unix" if="is.unix">
>> + <target name="-check-unix" if="is.unix">
>>
>> <property name="lcms.msg"
>> value="liblcms development package not installed
>> @@ -214,6 +219,10 @@
>> <download-one-file src="${msvcr71.url}" dest="${msvcr71.dll}"
>> md5="${msvcr71.md5}" />
>>
>> + <mkdir dir="${awtdeps.dir}" />
>> + <download-one-file src="${awtdeps.url}" dest="${awtdeps.tar}"
>> + md5="${awtdeps.md5}" />
>> +
>> </target>
>>
>> <macrodef name="download-one-file">
>> @@ -298,6 +307,14 @@
>> <jar destfile="${bcprov.jar}" basedir="${bcprov.dir}/temp"
>> manifest="${bcprov.dir}/temp/META-INF/MANIFEST.MF" />
>> <delete dir="${bcprov.dir}/temp" />
>> + </target>
>> +
>> + <target name="-awt-tar-extract" unless="awtdeps.uptodate">
>> + <echo>Extracting awt dependencies</echo>
>> + <untar src="${awtdeps.tar}" dest="${awtdeps.extract.dir}"
>> + compression="gzip" />
>> + <echo file="${awtdeps.testfile}"
>> + message="${awtdeps.tar} extracted${line.separator}" />
>> </target>
>>
>> <macrodef name="check-one-link">
>>
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: svn commit: r452826 - in /incubator/harmony/enhanced/classlib/trunk: depends/libs/build/ depends/libs/windows.x86/ make/depends.properties make/depends.xml
Posted by Mark Hindess <ma...@googlemail.com>.
With this change, the awt dependencies should now be automated for
windows and at least fairly trivial (installing a few packages on
Linux[0]). I think it is time we removed the with.awt.swing flag.
Anyone object?
Please test the current setup with -Dwith.awt.swing=true and report any
problems.
Regards,
Mark.
[0] Details of the required packages for distributions other than
Debian/Ubuntu would be welcome.
On 4 October 2006 at 10:24, hindessm@apache.org wrote:
> Author: hindessm
> Date: Wed Oct 4 03:24:29 2006
> New Revision: 452826
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=452826
> Log:
> Update check/fetch depends targets to handle the awt dependencies.
>
> Modified:
> incubator/harmony/enhanced/classlib/trunk/depends/libs/build/ (props ch
> anged)
> incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x86/ (pr
> ops changed)
> incubator/harmony/enhanced/classlib/trunk/make/depends.properties
> incubator/harmony/enhanced/classlib/trunk/make/depends.xml
>
> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/build/
> -----------------------------------------------------------------------------
> -
> --- svn:ignore (original)
> +++ svn:ignore Wed Oct 4 03:24:29 2006
> @@ -1,3 +1,4 @@
> jpeg
> lcms
> png
> +winxp_2006-09-28.txt
>
> Propchange: incubator/harmony/enhanced/classlib/trunk/depends/libs/windows.x8
> 6/
> -----------------------------------------------------------------------------
> -
> --- svn:ignore (original)
> +++ svn:ignore Wed Oct 4 03:24:29 2006
> @@ -1 +1,2 @@
> msvcr71.dll
> +swing_awt_deps_winxp_2006-09-28.tgz
>
> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.properties
> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
> ake/depends.properties?view=diff&rev=452826&r1=452825&r2=452826
> =============================================================================
> =
> --- incubator/harmony/enhanced/classlib/trunk/make/depends.properties (origin
> al)
> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.properties Wed Oct
> 4 03:24:29 2006
> @@ -98,3 +98,11 @@
> servlet-api.jar=${jetty.dir}/servlet-api-2.5-6.0.0.jar
> servlet-api.md5=c27c02fb0a00cc3a7d05ea993a9bf56e
> servlet-api.url=${ibiblio.base}/maven2/jetty/servlet-api/2.5-6.0.0/servlet-a
> pi-2.5-6.0.0.jar
> +
> +people.apache.base=http://people.apache.org/~geirm/harmony/
> +awtdeps.dir=${depends.dir}/libs/windows.x86
> +awtdeps.tar=${awtdeps.dir}/swing_awt_deps_winxp_2006-09-28.tgz
> +awtdeps.url=${people.apache.base}swing_awt_deps_winxp_2006-09-28.tgz
> +awtdeps.md5=d61a27e4b305d9fcabaaacf34f8f534a
> +awtdeps.extract.dir=${depends.dir}/libs/build
> +awtdeps.testfile=${awtdeps.extract.dir}/winxp_2006-09-28.txt
>
> Modified: incubator/harmony/enhanced/classlib/trunk/make/depends.xml
> URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/m
> ake/depends.xml?view=diff&rev=452826&r1=452825&r2=452826
> =============================================================================
> =
> --- incubator/harmony/enhanced/classlib/trunk/make/depends.xml (original)
> +++ incubator/harmony/enhanced/classlib/trunk/make/depends.xml Wed Oct 4 03:
> 24:29 2006
> @@ -72,17 +72,22 @@
>
> </target>
>
> - <target name="-check-win" if="is.windows">
> + <target name="-check-win" if="is.windows"
> + depends="-really-check-win,-awt-tar-extract" />
> +
> + <target name="-really-check-win" if="is.windows">
>
> <check-one-file src="${msvcr71.url}" dest="${msvcr71.dll}" />
>
> - </target>
> + <check-one-file src="${awtdeps.url}" dest="${awtdeps.tar}" />
> +
> + <uptodate property="awtdeps.uptodate"
> + srcfile="${awtdeps.tar}"
> + targetfile="${awtdeps.testfile}" />
>
> - <target name="-check-unix" if="with.awt.swing">
> - <antcall target="--check-unix" />
> </target>
>
> - <target name="--check-unix" if="is.unix">
> + <target name="-check-unix" if="is.unix">
>
> <property name="lcms.msg"
> value="liblcms development package not installed
> @@ -214,6 +219,10 @@
> <download-one-file src="${msvcr71.url}" dest="${msvcr71.dll}"
> md5="${msvcr71.md5}" />
>
> + <mkdir dir="${awtdeps.dir}" />
> + <download-one-file src="${awtdeps.url}" dest="${awtdeps.tar}"
> + md5="${awtdeps.md5}" />
> +
> </target>
>
> <macrodef name="download-one-file">
> @@ -298,6 +307,14 @@
> <jar destfile="${bcprov.jar}" basedir="${bcprov.dir}/temp"
> manifest="${bcprov.dir}/temp/META-INF/MANIFEST.MF" />
> <delete dir="${bcprov.dir}/temp" />
> + </target>
> +
> + <target name="-awt-tar-extract" unless="awtdeps.uptodate">
> + <echo>Extracting awt dependencies</echo>
> + <untar src="${awtdeps.tar}" dest="${awtdeps.extract.dir}"
> + compression="gzip" />
> + <echo file="${awtdeps.testfile}"
> + message="${awtdeps.tar} extracted${line.separator}" />
> </target>
>
> <macrodef name="check-one-link">
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org