You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by "William McCusker (JIRA)" <ji...@apache.org> on 2009/08/13 19:21:14 UTC

[jira] Created: (ODE-649) Incorrect NPE check in JPA MessageDAOImpl

Incorrect NPE check in JPA MessageDAOImpl
-----------------------------------------

                 Key: ODE-649
                 URL: https://issues.apache.org/jira/browse/ODE-649
             Project: ODE
          Issue Type: Bug
    Affects Versions: 2.0
            Reporter: William McCusker
         Attachments: MessageDAOImpl.dff

In the JPA MessageDAOImpl a NPE check was added to the constructor, however the instance variable is being checked for null instead of the method argument on which the actual NPE can occur.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ODE-649) Incorrect NPE check in JPA MessageDAOImpl

Posted by "William McCusker (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ODE-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

William McCusker updated ODE-649:
---------------------------------

    Attachment: MessageDAOImpl.dff

patch for trunk

> Incorrect NPE check in JPA MessageDAOImpl
> -----------------------------------------
>
>                 Key: ODE-649
>                 URL: https://issues.apache.org/jira/browse/ODE-649
>             Project: ODE
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: William McCusker
>         Attachments: MessageDAOImpl.dff
>
>
> In the JPA MessageDAOImpl a NPE check was added to the constructor, however the instance variable is being checked for null instead of the method argument on which the actual NPE can occur.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (ODE-649) Incorrect NPE check in JPA MessageDAOImpl

Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ODE-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Boisvert resolved ODE-649.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0

Thanks.  A little code review never hurts...

Patch applied.
boisvert@sixtine:~/svn/ode/trunk$ svn commit -m "ODE-649: Incorrect NPE check in JPA MessageDAOImpl"
Sending        dao-jpa/src/main/java/org/apache/ode/dao/jpa/MessageDAOImpl.java
Transmitting file data .
Committed revision 804147.


> Incorrect NPE check in JPA MessageDAOImpl
> -----------------------------------------
>
>                 Key: ODE-649
>                 URL: https://issues.apache.org/jira/browse/ODE-649
>             Project: ODE
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: William McCusker
>             Fix For: 2.0
>
>         Attachments: MessageDAOImpl.dff
>
>
> In the JPA MessageDAOImpl a NPE check was added to the constructor, however the instance variable is being checked for null instead of the method argument on which the actual NPE can occur.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.