[jira] [Commented] (HADOOP-12198) hadoop patches that hit multiple modules need to build at the union

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-12198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636026#comment-14636026 ] 

Allen Wittenauer commented on HADOOP-12198:
-------------------------------------------

bq.  Is this something that needs improvement here, or do you expect that it's the job of each project's personality file to know about a special case like this and avoid referencing CHANGED_UNION_MODULES?

Definitely the latter.  UNION is really calculated as a convenience since I'm expecting a lot of projects to need it.  The built-in personality actually uses CHANGED_MODULES, non-union-ed for most things and root for mvn install at branch (pre-patch) work.

If we take the hive example:

bq. If we consider a patch that includes code changes in both common and itests, then the union would be calculated as the project root, but building at the root wouldn't actually build itests.

I'd expect hive's personality to know that it builds+runs common and itests and ignore the union.

Since the UNION code was moved out, I've updated the description to really better match what's happening in this patch now.

Thanks for the review! I'll commit this so hadoop tests in hadoop-12111 are actually believable. ;)

> hadoop patches that hit multiple modules need to build at the union
> -------------------------------------------------------------------
>
>                 Key: HADOOP-12198
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12198
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: yetus
>    Affects Versions: HADOOP-12111
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>         Attachments: HADOOP-12198.HADOOP-12111.00.patch, HADOOP-12198.HADOOP-12111.02.patch, HADOOP-12198.HADOOP-12111.03.patch, HADOOP-12198.HADOOP-12111.03.patch, HADOOP-12198.HADOOP-12111.04.patch, HADOOP-12198.HADOOP-12111.05.patch
>
>
> Patches that introduce dependencies on other modules (e.g., HADOOP-12180) need to effectively be built at root. 
> There is a good chance this type of logic will need to be done on a per-project basis. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)