Re: [PR] [VL] Collapse trivial projects generated by rule PushDownInputFileExpression [incubator-gluten]

["baibaichen (via GitHub)" <gi...@apache.org>]

baibaichen commented on PR #7188:
URL: https://github.com/apache/incubator-gluten/pull/7188#issuecomment-2603761856

   @zml1206  @zhztheplayer 
   
   IIUC, the following codes colud be removed, after this pr, right?
   
   ```
   GlutenWholeStageColumnarRDD::compute()
       // To support input_file_name(). According to semantic we should return
       // the exact file name a row belongs to. However in columnar engine it's
       // not easy to accomplish this. so we return a list of file(part) names
       split match {
         case FirstZippedPartitionsPartition(_, g: GlutenPartition, _) =>
           InputFileBlockHolderProxy.set(g.files.mkString(","))
         case _ =>
           InputFileBlockHolderProxy.unset()
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org