You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by id...@apache.org on 2007/11/30 13:28:44 UTC

svn commit: r599798 - /myfaces/tobago/trunk/extension/fileupload/src/main/java/org/apache/myfaces/tobago/fileupload/FileUploadFacesContextFactoryImpl.java

Author: idus
Date: Fri Nov 30 04:28:37 2007
New Revision: 599798

URL: http://svn.apache.org/viewvc?rev=599798&view=rev
Log:
minor change: close initial context in finally block

Modified:
    myfaces/tobago/trunk/extension/fileupload/src/main/java/org/apache/myfaces/tobago/fileupload/FileUploadFacesContextFactoryImpl.java

Modified: myfaces/tobago/trunk/extension/fileupload/src/main/java/org/apache/myfaces/tobago/fileupload/FileUploadFacesContextFactoryImpl.java
URL: http://svn.apache.org/viewvc/myfaces/tobago/trunk/extension/fileupload/src/main/java/org/apache/myfaces/tobago/fileupload/FileUploadFacesContextFactoryImpl.java?rev=599798&r1=599797&r2=599798&view=diff
==============================================================================
--- myfaces/tobago/trunk/extension/fileupload/src/main/java/org/apache/myfaces/tobago/fileupload/FileUploadFacesContextFactoryImpl.java (original)
+++ myfaces/tobago/trunk/extension/fileupload/src/main/java/org/apache/myfaces/tobago/fileupload/FileUploadFacesContextFactoryImpl.java Fri Nov 30 04:28:37 2007
@@ -71,8 +71,9 @@
     if (LOG.isDebugEnabled()) {
       LOG.debug("Wrap FacesContext for file upload");
     }
+    InitialContext ic = null;
     try {
-      InitialContext ic = new InitialContext();
+      ic = new InitialContext();
       Context ctx = (Context) ic.lookup("java:comp/env");
 
       try {
@@ -99,7 +100,15 @@
         // ignore
       }
     } catch (NamingException e) {
-      //ignore no naming available 
+      // ignore no naming available
+    } finally {
+      if (ic != null) {
+        try {
+          ic.close();
+        } catch (NamingException e) {
+          // ignore
+        }
+      }
     }
     LOG.info("Configure uploadMaxFileSize for "+ getClass().getName() + " to "+ this.maxSize);
     LOG.info("Configure uploadRepositryPath for "+ getClass().getName() + " to "+ this.repositoryPath);