You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "ffacs (via GitHub)" <gi...@apache.org> on 2023/03/15 13:30:39 UTC

[GitHub] [orc] ffacs opened a new pull request, #1441: ORC-1376: [C++] Add Apache 2.0 License to the new file

ffacs opened a new pull request, #1441:
URL: https://github.com/apache/orc/pull/1441

   ### What changes were proposed in this pull request?
   Add Apache 2.0 License to the SchemaEvolution.hh and SchemaEvolution.cc
   
   ### Why are the changes needed?
   The prior patch forgot it.
   
   ### How was this patch tested?
   have no need
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] wgtmac commented on pull request #1441: ORC-1376: [C++] Add Apache 2.0 License to the new file

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1441:
URL: https://github.com/apache/orc/pull/1441#issuecomment-1470298299

   @dongjoon-hyun Let me do some investigation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1441: ORC-1376: [C++] Add Apache 2.0 License to the new file

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1441:
URL: https://github.com/apache/orc/pull/1441#issuecomment-1470313481

   Thank you so much, @wgtmac !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] wgtmac commented on pull request #1441: ORC-1376: [C++] Add Apache 2.0 License to the new file

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #1441:
URL: https://github.com/apache/orc/pull/1441#issuecomment-1471214824

   Thanks for fixing this @ffacs and @dongjoon-hyun !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1441: ORC-1376: [C++] Add Apache 2.0 License to the new file

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1441:
URL: https://github.com/apache/orc/pull/1441#issuecomment-1470286403

   Also, @coderex2522 , the ASF license is mandatory. Could you double-check the previous PR if we have ASF licenses or not?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] wgtmac merged pull request #1441: ORC-1376: [C++] Add Apache 2.0 License to the new file

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac merged PR #1441:
URL: https://github.com/apache/orc/pull/1441


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] coderex2522 commented on pull request #1441: ORC-1376: [C++] Add Apache 2.0 License to the new file

Posted by "coderex2522 (via GitHub)" <gi...@apache.org>.
coderex2522 commented on PR #1441:
URL: https://github.com/apache/orc/pull/1441#issuecomment-1471202843

   @dongjoon-hyun I use the script to double check the all files in the c++ directory. There are three files 'SchemaEvolution.hh', 'SchemaEvolution.cc', 'test-orc.suppress' that do not include ASF licenses. And I'm not quite sure if the 'test-orc.suppress' file needs to include the ASF licenses.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org