You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/13 06:07:24 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #8551: Add
convert_dttm method to SnowflakeEngineSpec
villebro opened a new pull request #8551: Add convert_dttm method to SnowflakeEngineSpec
URL: https://github.com/apache/incubator-superset/pull/8551
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [x] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
With the introduction of SIP-15, temporal handling can be improved by making sure dates and datetimes are cast to their respective native SQL types. This adds correct handling of `DATE`, `DATETIME` and `TIMESTAMP` to the Snowflake spec along with tests.
While the UI seems to imply that `DATETIME` and `TIMESTAMP` are truncated to millisecond precision, it is my understanding that they are in fact stored at nanosecond precision, hence `timespec=microsecond` like other engines with micro-/nanosecond precision.
### TEST PLAN
CI + executing test expressions in Snowflake UI:
### REVIEWERS
@john-bodley
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org