[jira] Commented: (MPASPECTJ-19) Add messageHolderClass property

["Vincent Massol (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/MPASPECTJ-19?page=comments#action_38083 ]
     
Vincent Massol commented on MPASPECTJ-19:
-----------------------------------------

Thanks. Applied with several modifications:
- it was missing a patch for properties.xml
- it was missing a patch for changes.xml
- the patch was probably invalid when no maven.aspectj.messageHolder property is specified. I hope I've fixed that.

It's also missing a test to prove that it works. Could you please provide one?

Note: I've noticed that the existing plugin test does not seem to fully work so it may need to be fixed too... Thanks! ;-)


> Add messageHolderClass property
> -------------------------------
>
>          Key: MPASPECTJ-19
>          URL: http://jira.codehaus.org/browse/MPASPECTJ-19
>      Project: maven-aspectj-plugin
>         Type: Improvement
>     Versions: 3.2
>     Reporter: Matt Smith
>  Attachments: MPASPECTJ-19.txt
>
>
> from the iajc ant task documentation:
> Specify a class to use as the message holder for the compile process. The entry must be a fully-qualified name of a class resolveable from the task classpath complying with the org.aspectj.bridge.IMessageHolder interface and having a public no-argument constructor.
> Adding the ability to use a messageHolderClass requires two changes:
>   1)  add maven.aspectj.messageHolderClass property and associated attribute messageHolderClass
>   2)  add maven.dependency.classpath to the ant task def
> Please see the attached file

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org