[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30904: [SPARK-33889][SQL] Fix NPE from `SHOW PARTITIONS` on V2 tables

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #30904:
URL: https://github.com/apache/spark/pull/30904#discussion_r547819246



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/ShowPartitionsSuite.scala
##########
@@ -34,4 +34,18 @@ class ShowPartitionsSuite extends command.ShowPartitionsSuiteBase with CommandSu
         "SHOW PARTITIONS cannot run for a table which does not support partitioning"))
     }
   }
+
+  test("null and empty string as partition values") {

Review comment:
       Could you add `SPARK-33889: ` prefix please?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org