You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by bu...@apache.org on 2009/05/02 23:53:20 UTC
DO NOT REPLY [Bug 47141] New: add getCyclicBuffer() method to log4j
SMTPAppender
https://issues.apache.org/bugzilla/show_bug.cgi?id=47141
Summary: add getCyclicBuffer() method to log4j SMTPAppender
Product: Log4j
Version: 1.2
Platform: PC
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Appender
AssignedTo: log4j-dev@logging.apache.org
ReportedBy: apache-bugzilla@seansullivan.com
I am submitting a patch for log4j's SMTPAppender.
The patch has two changes:
1) new method: protected CyclicBuffer getCyclicBuffer()
2) SMTPAppender uses getCyclicBuffer() whenever it needs to access the buffer
object
This change makes it easier for third parties to subclass (extend)
SMTPAppender.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
DO NOT REPLY [Bug 47141] add getCyclicBuffer() method to log4j
SMTPAppender
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47141
Curt Arnold <ca...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #2 from Curt Arnold <ca...@apache.org> 2009-05-11 21:23:22 PST ---
I don't see how the benefit of the mod. The cb member is protected and
non-final, so if you wanted to replace the current implementation with your own
CyclicBuffer implementation, you could do it in either the constructor or
activateOptions. Could you explain the use case?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
DO NOT REPLY [Bug 47141] add getCyclicBuffer() method to log4j
SMTPAppender
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47141
--- Comment #3 from Sean C. Sullivan <ap...@seansullivan.com> 2009-05-17 16:54:43 PST ---
The use case is that I plan to maintain a CyclicBuffer per Thread.
If there were a getCyclicBuffer() method, I would be able to do this:
protected CyclicBuffer getCyclicBuffer()
{
return threadLocalCyclicBuffer.get();
}
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
DO NOT REPLY [Bug 47141] add getCyclicBuffer() method to log4j
SMTPAppender
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47141
--- Comment #1 from Sean C. Sullivan <ap...@seansullivan.com> 2009-05-02 14:54:18 PST ---
Created an attachment (id=23597)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=23597)
patch for SMTPAppender.java
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org