You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/18 12:42:45 UTC
[GitHub] [arrow] raulcd commented on a diff in pull request #13556: ARROW-17021:[C++][R][CI] Enable use of sccache in crossbow WIP
raulcd commented on code in PR #13556:
URL: https://github.com/apache/arrow/pull/13556#discussion_r923327193
##########
dev/tasks/r/github.packages.yml:
##########
@@ -82,14 +82,24 @@ jobs:
{{ macros.github_checkout_arrow()|indent }}
{{ macros.github_change_r_pkg_version(is_fork, '${{ needs.source.outputs.pkg_version }}')|indent }}
{{ macros.github_install_archery()|indent }}
+
- name: Build libarrow
shell: bash
env:
- UBUNTU: {{ '${{ matrix.config.version}}' }}
+ SCCACHE_BUCKET: {{ '${{ secrets.SCCACHE_BUCKET }}' }}
+ SCCACHE_ID: {{ '${{ secrets.AWS_ACCESS_KEY_ID }}' }}
+ SCCACHE_KEY: {{' ${{ secrets.AWS_SECRET_ACCESS_KEY }}' }}
Review Comment:
wouldn't be better to call this `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY`. I am not sure the renaming adds anything and the environment variable names used on archery are already the original ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org