You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/11/19 20:35:25 UTC
[GitHub] [iceberg] Fokko commented on a diff in pull request #6220: API: Make the PartitionSpec less lazy
Fokko commented on code in PR #6220:
URL: https://github.com/apache/iceberg/pull/6220#discussion_r1027140078
##########
api/src/main/java/org/apache/iceberg/transforms/ProjectionUtil.java:
##########
@@ -231,7 +231,9 @@ static <S, T> UnboundPredicate<T> truncateArrayStrict(
static <T> UnboundPredicate<T> projectTransformPredicate(
Transform<?, T> transform, String partitionName, BoundPredicate<?> pred) {
if (pred.term() instanceof BoundTransform
- && transform.equals(((BoundTransform<?, ?>) pred.term()).transform())) {
+ && transform
Review Comment:
I had to change this to make `testProjectionNames` pass. In the case of `hour` transform, we'll be comparing `transforms` which is an instance of `Timestamps` with `Hours`. The `toString()` both produce `hour`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org