You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by me...@apache.org on 2016/01/03 11:29:02 UTC
[2/3] mesos git commit: Cleaned up VIP comments.
Cleaned up VIP comments.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/8f4688c6
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/8f4688c6
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/8f4688c6
Branch: refs/heads/master
Commit: 8f4688c660f851375bae8e2cd92e1c4b62751655
Parents: b87e42a
Author: Adam B <ad...@mesosphere.io>
Authored: Sun Jan 3 01:38:02 2016 -0800
Committer: Adam B <ad...@mesosphere.io>
Committed: Sun Jan 3 01:50:15 2016 -0800
----------------------------------------------------------------------
include/mesos/mesos.proto | 13 ++++++-------
include/mesos/v1/mesos.proto | 13 ++++++-------
2 files changed, 12 insertions(+), 14 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/8f4688c6/include/mesos/mesos.proto
----------------------------------------------------------------------
diff --git a/include/mesos/mesos.proto b/include/mesos/mesos.proto
index 72166ef..158e087 100644
--- a/include/mesos/mesos.proto
+++ b/include/mesos/mesos.proto
@@ -1554,10 +1554,9 @@ message Port {
// This can be used to decorate the message with metadata to be
// interpreted by external applications such as firewalls.
optional Labels labels = 5;
- // This field represents the backend port on which the task is
- // running. It could potentially be different than the `number` field (1), for
- // instance, when an agent achieves network isolation between containers using
- // port (layer 4) segregation.
+ // The backend port on which the task is running. This could be different than
+ // the `number` field (1), e.g. when an agent achieves network isolation
+ // between containers using port (layer 4) segregation.
optional uint32 instance_port = 6;
}
@@ -1574,9 +1573,9 @@ message Ports {
* An IP address.
*/
message IPAddress {
- // TODO (asridharan): We are setting the positional identifier of this
- // field to 2, in order to maintain backward compatibility with the `IPAddress`
- // message definition within `NetworkInfo`. See MESOS-4243 for more details.
+ // TODO(asridharan): We skip tag number 1 in case we later want to be binary
+ // compatible with `NetworkInfo.IPAddress`. See MESOS-4243 for more details.
+ // optional Protocol protocol = 1;
optional string ip_address = 2;
}
http://git-wip-us.apache.org/repos/asf/mesos/blob/8f4688c6/include/mesos/v1/mesos.proto
----------------------------------------------------------------------
diff --git a/include/mesos/v1/mesos.proto b/include/mesos/v1/mesos.proto
index a287683..c6c5a81 100644
--- a/include/mesos/v1/mesos.proto
+++ b/include/mesos/v1/mesos.proto
@@ -1553,10 +1553,9 @@ message Port {
// This can be used to decorate the message with metadata to be
// interpreted by external applications such as firewalls.
optional Labels labels = 5;
- // This field represents the backend port on which the task is
- // running. It could potentially be different than the `number` field (1), for
- // instance, when an agent achieves network isolation between containers using
- // port (layer 4) segregation.
+ // The backend port on which the task is running. This could be different than
+ // the `number` field (1), e.g. when an agent achieves network isolation
+ // between containers using port (layer 4) segregation.
optional uint32 instance_port = 6;
}
@@ -1573,9 +1572,9 @@ message Ports {
* An IP address.
*/
message IPAddress {
- // TODO (asridharan): We are setting the positional identifier of this
- // field to 2, in order to maintain backward compatibility with the `IPAddress`
- // message definition within `NetworkInfo`. See MESOS-4243 for more details.
+ // TODO(asridharan): We skip tag number 1 in case we later want to be binary
+ // compatible with `NetworkInfo.IPAddress`. See MESOS-4243 for more details.
+ // optional Protocol protocol = 1;
optional string ip_address = 2;
}