You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2017/06/16 15:42:03 UTC
Review Request 60155: LENS-1441: CandidateTableResolver should not add
StorageCandidate if storage is not supported
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60155/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1441
https://issues.apache.org/jira/browse/LENS-1441
Repository: lens
Description
-------
An optimization.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java f530650b212633651a6def772967e20638a78935
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0ef41f37a731bbaf58ba2c02eb67344ed2bad089
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java b1654d149da8c034781f9841fed8fa56f87a659c
Diff: https://reviews.apache.org/r/60155/diff/1/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 60155: LENS-1441: CandidateTableResolver should
not add StorageCandidate if storage is not supported
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60155/
-----------------------------------------------------------
(Updated June 20, 2017, 3:17 p.m.)
Review request for lens.
Bugs: LENS-1441
https://issues.apache.org/jira/browse/LENS-1441
Repository: lens
Description
-------
An optimization.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java f530650b212633651a6def772967e20638a78935
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0ef41f37a731bbaf58ba2c02eb67344ed2bad089
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java b1654d149da8c034781f9841fed8fa56f87a659c
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 3acd7540cdf57324e85592a5faaead01ad845bc1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java ffd0dec54c62fb2b9e0b7d47bab6d0e672dfcf9c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 929fb4690aa66dd81d468806402d339c60949bb8
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5409d2169e0b9ca8a773bf4d4ea0db7bda62cc87
Diff: https://reviews.apache.org/r/60155/diff/6/
Changes: https://reviews.apache.org/r/60155/diff/5-6/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 60155: LENS-1441: CandidateTableResolver should
not add StorageCandidate if storage is not supported
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60155/
-----------------------------------------------------------
(Updated June 20, 2017, 3:13 p.m.)
Review request for lens.
Bugs: LENS-1441
https://issues.apache.org/jira/browse/LENS-1441
Repository: lens
Description
-------
An optimization.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java 1e9873f4486222f3e8c9e28f180f4bfbc4189ce5
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java f530650b212633651a6def772967e20638a78935
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0ef41f37a731bbaf58ba2c02eb67344ed2bad089
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java b1654d149da8c034781f9841fed8fa56f87a659c
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 3acd7540cdf57324e85592a5faaead01ad845bc1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java ffd0dec54c62fb2b9e0b7d47bab6d0e672dfcf9c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 929fb4690aa66dd81d468806402d339c60949bb8
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java 5409d2169e0b9ca8a773bf4d4ea0db7bda62cc87
Diff: https://reviews.apache.org/r/60155/diff/5/
Changes: https://reviews.apache.org/r/60155/diff/4-5/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 60155: LENS-1441: CandidateTableResolver should
not add StorageCandidate if storage is not supported
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60155/
-----------------------------------------------------------
(Updated June 20, 2017, 1:24 p.m.)
Review request for lens.
Bugs: LENS-1441
https://issues.apache.org/jira/browse/LENS-1441
Repository: lens
Description
-------
An optimization.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java f530650b212633651a6def772967e20638a78935
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0ef41f37a731bbaf58ba2c02eb67344ed2bad089
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java b1654d149da8c034781f9841fed8fa56f87a659c
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 3acd7540cdf57324e85592a5faaead01ad845bc1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java ffd0dec54c62fb2b9e0b7d47bab6d0e672dfcf9c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 929fb4690aa66dd81d468806402d339c60949bb8
Diff: https://reviews.apache.org/r/60155/diff/4/
Changes: https://reviews.apache.org/r/60155/diff/3-4/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 60155: LENS-1441: CandidateTableResolver should
not add StorageCandidate if storage is not supported
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60155/
-----------------------------------------------------------
(Updated June 20, 2017, 1:12 p.m.)
Review request for lens.
Bugs: LENS-1441
https://issues.apache.org/jira/browse/LENS-1441
Repository: lens
Description
-------
An optimization.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java f530650b212633651a6def772967e20638a78935
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0ef41f37a731bbaf58ba2c02eb67344ed2bad089
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java b1654d149da8c034781f9841fed8fa56f87a659c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java ffd0dec54c62fb2b9e0b7d47bab6d0e672dfcf9c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 929fb4690aa66dd81d468806402d339c60949bb8
Diff: https://reviews.apache.org/r/60155/diff/3/
Changes: https://reviews.apache.org/r/60155/diff/2-3/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 60155: LENS-1441: CandidateTableResolver should
not add StorageCandidate if storage is not supported
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60155/
-----------------------------------------------------------
(Updated June 20, 2017, 12:56 p.m.)
Review request for lens.
Bugs: LENS-1441
https://issues.apache.org/jira/browse/LENS-1441
Repository: lens
Description
-------
An optimization.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java f530650b212633651a6def772967e20638a78935
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0ef41f37a731bbaf58ba2c02eb67344ed2bad089
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java b1654d149da8c034781f9841fed8fa56f87a659c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java ffd0dec54c62fb2b9e0b7d47bab6d0e672dfcf9c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 929fb4690aa66dd81d468806402d339c60949bb8
Diff: https://reviews.apache.org/r/60155/diff/2/
Changes: https://reviews.apache.org/r/60155/diff/1-2/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 60155: LENS-1441: CandidateTableResolver should
not add StorageCandidate if storage is not supported
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60155/#review178196
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On June 16, 2017, 3:42 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60155/
> -----------------------------------------------------------
>
> (Updated June 16, 2017, 3:42 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1441
> https://issues.apache.org/jira/browse/LENS-1441
>
>
> Repository: lens
>
>
> Description
> -------
>
> An optimization.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java f530650b212633651a6def772967e20638a78935
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 0ef41f37a731bbaf58ba2c02eb67344ed2bad089
> lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java b1654d149da8c034781f9841fed8fa56f87a659c
>
>
> Diff: https://reviews.apache.org/r/60155/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>