You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/06/10 00:32:58 UTC
Review Request 35273: Removed unnecessary accessors in filter code.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35273/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Repository: mesos
Description
-------
Removed unnecessary accessors in filter code.
Diffs
-----
src/linux/routing/filter/filter.hpp 7a737e025a87e368304ae466e8c9dbe644cfe4bb
src/linux/routing/filter/internal.hpp 8a48102928b1cfe2bd6ac11ff7c7181a02928e58
src/slave/containerizer/isolators/network/port_mapping.cpp d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f
Diff: https://reviews.apache.org/r/35273/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 35273: Removed unnecessary accessors in filter
code.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35273/#review87320
-----------------------------------------------------------
Ship it!
- Ben Mahler
On June 9, 2015, 10:59 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35273/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 10:59 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unnecessary accessors in filter code.
>
>
> Diffs
> -----
>
> src/linux/routing/filter/action.hpp 410c15ad20ffa694bdb4c4187f1544ef9617ebac
> src/linux/routing/filter/basic.hpp f1999bf81cbb55b6cc0c64767588be3cb110816c
> src/linux/routing/filter/basic.cpp 937e8fcf3fb48e329f7f48a0c81a67d731ec2ed7
> src/linux/routing/filter/filter.hpp 7a737e025a87e368304ae466e8c9dbe644cfe4bb
> src/linux/routing/filter/icmp.hpp 9e167b0a5c25336c92f474b9b08a8fd2849ce504
> src/linux/routing/filter/icmp.cpp 12797d741e013099c02d7a7abaaadcb0d7c0c363
> src/linux/routing/filter/internal.hpp 8a48102928b1cfe2bd6ac11ff7c7181a02928e58
> src/linux/routing/filter/ip.hpp b8f52041da4055819c13dc5cc715dad25dd88322
> src/linux/routing/filter/ip.cpp ddce93fb19294544c8321d41cfee162e38a59ebd
> src/slave/containerizer/isolators/network/port_mapping.cpp d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f
> src/tests/routing_tests.cpp 463c2e556488b18388d4e741cf584644016cec59
>
> Diff: https://reviews.apache.org/r/35273/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 35273: Removed unnecessary accessors in filter
code.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35273/#review87342
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35271, 35272, 35273]
All tests passed.
- Mesos ReviewBot
On June 9, 2015, 10:59 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35273/
> -----------------------------------------------------------
>
> (Updated June 9, 2015, 10:59 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removed unnecessary accessors in filter code.
>
>
> Diffs
> -----
>
> src/linux/routing/filter/action.hpp 410c15ad20ffa694bdb4c4187f1544ef9617ebac
> src/linux/routing/filter/basic.hpp f1999bf81cbb55b6cc0c64767588be3cb110816c
> src/linux/routing/filter/basic.cpp 937e8fcf3fb48e329f7f48a0c81a67d731ec2ed7
> src/linux/routing/filter/filter.hpp 7a737e025a87e368304ae466e8c9dbe644cfe4bb
> src/linux/routing/filter/icmp.hpp 9e167b0a5c25336c92f474b9b08a8fd2849ce504
> src/linux/routing/filter/icmp.cpp 12797d741e013099c02d7a7abaaadcb0d7c0c363
> src/linux/routing/filter/internal.hpp 8a48102928b1cfe2bd6ac11ff7c7181a02928e58
> src/linux/routing/filter/ip.hpp b8f52041da4055819c13dc5cc715dad25dd88322
> src/linux/routing/filter/ip.cpp ddce93fb19294544c8321d41cfee162e38a59ebd
> src/slave/containerizer/isolators/network/port_mapping.cpp d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f
> src/tests/routing_tests.cpp 463c2e556488b18388d4e741cf584644016cec59
>
> Diff: https://reviews.apache.org/r/35273/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 35273: Removed unnecessary accessors in filter
code.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35273/
-----------------------------------------------------------
(Updated June 9, 2015, 10:59 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Updated.
Repository: mesos
Description
-------
Removed unnecessary accessors in filter code.
Diffs (updated)
-----
src/linux/routing/filter/action.hpp 410c15ad20ffa694bdb4c4187f1544ef9617ebac
src/linux/routing/filter/basic.hpp f1999bf81cbb55b6cc0c64767588be3cb110816c
src/linux/routing/filter/basic.cpp 937e8fcf3fb48e329f7f48a0c81a67d731ec2ed7
src/linux/routing/filter/filter.hpp 7a737e025a87e368304ae466e8c9dbe644cfe4bb
src/linux/routing/filter/icmp.hpp 9e167b0a5c25336c92f474b9b08a8fd2849ce504
src/linux/routing/filter/icmp.cpp 12797d741e013099c02d7a7abaaadcb0d7c0c363
src/linux/routing/filter/internal.hpp 8a48102928b1cfe2bd6ac11ff7c7181a02928e58
src/linux/routing/filter/ip.hpp b8f52041da4055819c13dc5cc715dad25dd88322
src/linux/routing/filter/ip.cpp ddce93fb19294544c8321d41cfee162e38a59ebd
src/slave/containerizer/isolators/network/port_mapping.cpp d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f
src/tests/routing_tests.cpp 463c2e556488b18388d4e741cf584644016cec59
Diff: https://reviews.apache.org/r/35273/diff/
Testing
-------
make check
Thanks,
Jie Yu