You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/06/15 13:16:02 UTC

[GitHub] [knox] pzampino commented on pull request #345: KNOX-2377 - Address potential loss of token state

pzampino commented on pull request #345:
URL: https://github.com/apache/knox/pull/345#issuecomment-644128164


   > In addition to my previous comments I'd also suggest another change:
   > in `org.apache.knox.gateway.services.token.impl.AliasBasedTokenStateService.stop()` you may persist all entries in `unpersistedState` after shutting down the scheduler to provide one more final round of token persistence.
   
   Yes, this is a good suggestion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org