You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2017/11/23 07:54:15 UTC
Re: OFBiz & gradlew-wrapper.jar
Hi,
It's almost 7 months now and nothing happened at LEGAL-288
So I think we should follow the way Jacopo suggested, and I reported below, before we do the next release
Thanks
Jacques
Le 07/05/2017 à 11:56, Jacques Le Roux a écrit :
> I suggest we wait for the result of LEGAL-288 before taking any decisions.
>
> We already discussed that in PMC private ML 2 weeks ago.
>
> The idea is it's OK for now and hopefully a new Java class will resolve this issue. Else, as Jacopo suggested:
>
> <<we will have to remove [the wrapper] from our future release package and add a step to our build notes:
>
> 1. Extract the archive file to your local directory.
> 2. Download gradle-wrapper.jar and place it in the gradle/wrapper folder.
>>>
>
> Jacques
>
>
> Le 07/05/2017 à 06:42, James Yong a écrit :
>> More info at https://docs.gradle.org/current/userguide/gradle_wrapper.html
>>
>> Regards,
>> James Yong
>>
>> On 2017-05-06 03:59 (+0800), Pierre Smits <pi...@gmail.com> wrote:
>>> HI all,
>>>
>>> While discussing the gradlew-wrapper.jar issue in the Weex release vote
>>> [1], the following was suggested by Anthony Baker:
>>>
>>> You might want to consider using the Bigtop approach for gradlew [1] to
>>> avoid shipping a binary in the source release. The Geode project has been
>>> using this successfully (thanks to Roman for pointing us in this
>>> direction!).
>>>
>>> [1] https://github.com/apache/bigtop/blob/master/gradlew <
>>> https://github.com/apache/bigtop/blob/master/gradlew>
>>>
>>>
>>>
>>> Though I have not evaluated that solution (and compared it against what is
>>> in the code base) it maybe so that such can be applied in OFBiz too.
>>>
>>> [1]
>>> https://lists.apache.org/thread.html/67360a14837b8ea12ef5c70adb0c55f370e711900a9a372cb3ba3f1a@%3Cgeneral.incubator.apache.org%3E
>>>
>>> Best regards,
>>>
>>> Pierre Smits
>>>
>>> ORRTIZ.COM <http://www.orrtiz.com>
>>> OFBiz based solutions & services
>>>
>>> OFBiz Extensions Marketplace
>>> http://oem.ofbizci.net/oci-2/
>>>
>
>
Re: OFBiz & gradlew-wrapper.jar
Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 29/11/2017 à 17:20, Jacques Le Roux a écrit :
> Should we not discuss (and hopefully do) this before the next release?
Forgot to say I created https://issues.apache.org/jira/browse/OFBIZ-10145 for that
>
> Jacques
>
>
> Le 23/11/2017 à 15:30, Jacques Le Roux a écrit :
>> Ha something I missed: we don't bundle the tools with the releases.
>>
>> Should that be an issue? I guess not. Because anyway if one wants to build OFBiz one needs an Internet connection. Hence the extra svn checking out
>> of the tools, once documented, should not be an issue.
>>
>> We could also put the ofbiz-init.sh/bat in the framework and releases, easier for our users.
>>
>> Opinions?
>>
>> Jacques
>>
>>
>> Le 23/11/2017 à 11:46, Jacques Le Roux a écrit :
>>> That's quite a good idea, thanks Nicolas
>>>
>>> +1
>>>
>>> Jacques
>>>
>>>
>>> Le 23/11/2017 à 09:07, Nicolas Malin a écrit :
>>>> I lookup the bigtop gradlew code and it's nice but I'm not sure tat works easily on win$ environment.
>>>>
>>>> I suggest also to follow Jacopo's remark and maybe we (I) can add an bash script util in tools to download gradlew, like
>>>>
>>>> $./tools/ofbiz-init.sh demo
>>>>
>>>> And like this we can add a .bat for other env.
>>>>
>>>> Nicolas
>>>>
>>>> Le 23/11/2017 à 08:54, Jacques Le Roux a écrit :
>>>>> Hi,
>>>>>
>>>>> It's almost 7 months now and nothing happened at LEGAL-288
>>>>>
>>>>> So I think we should follow the way Jacopo suggested, and I reported below, before we do the next release
>>>>>
>>>>> Thanks
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 07/05/2017 à 11:56, Jacques Le Roux a écrit :
>>>>>> I suggest we wait for the result of LEGAL-288 before taking any decisions.
>>>>>>
>>>>>> We already discussed that in PMC private ML 2 weeks ago.
>>>>>>
>>>>>> The idea is it's OK for now and hopefully a new Java class will resolve this issue. Else, as Jacopo suggested:
>>>>>>
>>>>>> <<we will have to remove [the wrapper] from our future release package and add a step to our build notes:
>>>>>>
>>>>>> 1. Extract the archive file to your local directory.
>>>>>> 2. Download gradle-wrapper.jar and place it in the gradle/wrapper folder.
>>>>>>>>
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>>>>> Le 07/05/2017 à 06:42, James Yong a écrit :
>>>>>>> More info at https://docs.gradle.org/current/userguide/gradle_wrapper.html
>>>>>>>
>>>>>>> Regards,
>>>>>>> James Yong
>>>>>>>
>>>>>>> On 2017-05-06 03:59 (+0800), Pierre Smits <pi...@gmail.com> wrote:
>>>>>>>> HI all,
>>>>>>>>
>>>>>>>> While discussing the gradlew-wrapper.jar issue in the Weex release vote
>>>>>>>> [1], the following was suggested by Anthony Baker:
>>>>>>>>
>>>>>>>> You might want to consider using the Bigtop approach for gradlew [1] to
>>>>>>>> avoid shipping a binary in the source release. The Geode project has been
>>>>>>>> using this successfully (thanks to Roman for pointing us in this
>>>>>>>> direction!).
>>>>>>>>
>>>>>>>> [1] https://github.com/apache/bigtop/blob/master/gradlew <
>>>>>>>> https://github.com/apache/bigtop/blob/master/gradlew>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> Though I have not evaluated that solution (and compared it against what is
>>>>>>>> in the code base) it maybe so that such can be applied in OFBiz too.
>>>>>>>>
>>>>>>>> [1]
>>>>>>>> https://lists.apache.org/thread.html/67360a14837b8ea12ef5c70adb0c55f370e711900a9a372cb3ba3f1a@%3Cgeneral.incubator.apache.org%3E
>>>>>>>>
>>>>>>>> Best regards,
>>>>>>>>
>>>>>>>> Pierre Smits
>>>>>>>>
>>>>>>>> ORRTIZ.COM <http://www.orrtiz.com>
>>>>>>>> OFBiz based solutions & services
>>>>>>>>
>>>>>>>> OFBiz Extensions Marketplace
>>>>>>>> http://oem.ofbizci.net/oci-2/
>>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>
>
>
Re: OFBiz & gradlew-wrapper.jar
Posted by Jacques Le Roux <ja...@les7arts.com>.
Should we not discuss (and hopefully do) this before the next release?
Jacques
Le 23/11/2017 à 15:30, Jacques Le Roux a écrit :
> Ha something I missed: we don't bundle the tools with the releases.
>
> Should that be an issue? I guess not. Because anyway if one wants to build OFBiz one needs an Internet connection. Hence the extra svn checking out
> of the tools, once documented, should not be an issue.
>
> We could also put the ofbiz-init.sh/bat in the framework and releases, easier for our users.
>
> Opinions?
>
> Jacques
>
>
> Le 23/11/2017 à 11:46, Jacques Le Roux a écrit :
>> That's quite a good idea, thanks Nicolas
>>
>> +1
>>
>> Jacques
>>
>>
>> Le 23/11/2017 à 09:07, Nicolas Malin a écrit :
>>> I lookup the bigtop gradlew code and it's nice but I'm not sure tat works easily on win$ environment.
>>>
>>> I suggest also to follow Jacopo's remark and maybe we (I) can add an bash script util in tools to download gradlew, like
>>>
>>> $./tools/ofbiz-init.sh demo
>>>
>>> And like this we can add a .bat for other env.
>>>
>>> Nicolas
>>>
>>> Le 23/11/2017 à 08:54, Jacques Le Roux a écrit :
>>>> Hi,
>>>>
>>>> It's almost 7 months now and nothing happened at LEGAL-288
>>>>
>>>> So I think we should follow the way Jacopo suggested, and I reported below, before we do the next release
>>>>
>>>> Thanks
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 07/05/2017 à 11:56, Jacques Le Roux a écrit :
>>>>> I suggest we wait for the result of LEGAL-288 before taking any decisions.
>>>>>
>>>>> We already discussed that in PMC private ML 2 weeks ago.
>>>>>
>>>>> The idea is it's OK for now and hopefully a new Java class will resolve this issue. Else, as Jacopo suggested:
>>>>>
>>>>> <<we will have to remove [the wrapper] from our future release package and add a step to our build notes:
>>>>>
>>>>> 1. Extract the archive file to your local directory.
>>>>> 2. Download gradle-wrapper.jar and place it in the gradle/wrapper folder.
>>>>>>>
>>>>>
>>>>> Jacques
>>>>>
>>>>>
>>>>> Le 07/05/2017 à 06:42, James Yong a écrit :
>>>>>> More info at https://docs.gradle.org/current/userguide/gradle_wrapper.html
>>>>>>
>>>>>> Regards,
>>>>>> James Yong
>>>>>>
>>>>>> On 2017-05-06 03:59 (+0800), Pierre Smits <pi...@gmail.com> wrote:
>>>>>>> HI all,
>>>>>>>
>>>>>>> While discussing the gradlew-wrapper.jar issue in the Weex release vote
>>>>>>> [1], the following was suggested by Anthony Baker:
>>>>>>>
>>>>>>> You might want to consider using the Bigtop approach for gradlew [1] to
>>>>>>> avoid shipping a binary in the source release. The Geode project has been
>>>>>>> using this successfully (thanks to Roman for pointing us in this
>>>>>>> direction!).
>>>>>>>
>>>>>>> [1] https://github.com/apache/bigtop/blob/master/gradlew <
>>>>>>> https://github.com/apache/bigtop/blob/master/gradlew>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Though I have not evaluated that solution (and compared it against what is
>>>>>>> in the code base) it maybe so that such can be applied in OFBiz too.
>>>>>>>
>>>>>>> [1]
>>>>>>> https://lists.apache.org/thread.html/67360a14837b8ea12ef5c70adb0c55f370e711900a9a372cb3ba3f1a@%3Cgeneral.incubator.apache.org%3E
>>>>>>>
>>>>>>> Best regards,
>>>>>>>
>>>>>>> Pierre Smits
>>>>>>>
>>>>>>> ORRTIZ.COM <http://www.orrtiz.com>
>>>>>>> OFBiz based solutions & services
>>>>>>>
>>>>>>> OFBiz Extensions Marketplace
>>>>>>> http://oem.ofbizci.net/oci-2/
>>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>
>
Re: OFBiz & gradlew-wrapper.jar
Posted by Jacques Le Roux <ja...@les7arts.com>.
Ha something I missed: we don't bundle the tools with the releases.
Should that be an issue? I guess not. Because anyway if one wants to build OFBiz one needs an Internet connection. Hence the extra svn checking out of
the tools, once documented, should not be an issue.
We could also put the ofbiz-init.sh/bat in the framework and releases, easier for our users.
Opinions?
Jacques
Le 23/11/2017 à 11:46, Jacques Le Roux a écrit :
> That's quite a good idea, thanks Nicolas
>
> +1
>
> Jacques
>
>
> Le 23/11/2017 à 09:07, Nicolas Malin a écrit :
>> I lookup the bigtop gradlew code and it's nice but I'm not sure tat works easily on win$ environment.
>>
>> I suggest also to follow Jacopo's remark and maybe we (I) can add an bash script util in tools to download gradlew, like
>>
>> $./tools/ofbiz-init.sh demo
>>
>> And like this we can add a .bat for other env.
>>
>> Nicolas
>>
>> Le 23/11/2017 à 08:54, Jacques Le Roux a écrit :
>>> Hi,
>>>
>>> It's almost 7 months now and nothing happened at LEGAL-288
>>>
>>> So I think we should follow the way Jacopo suggested, and I reported below, before we do the next release
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>> Le 07/05/2017 à 11:56, Jacques Le Roux a écrit :
>>>> I suggest we wait for the result of LEGAL-288 before taking any decisions.
>>>>
>>>> We already discussed that in PMC private ML 2 weeks ago.
>>>>
>>>> The idea is it's OK for now and hopefully a new Java class will resolve this issue. Else, as Jacopo suggested:
>>>>
>>>> <<we will have to remove [the wrapper] from our future release package and add a step to our build notes:
>>>>
>>>> 1. Extract the archive file to your local directory.
>>>> 2. Download gradle-wrapper.jar and place it in the gradle/wrapper folder.
>>>>>>
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 07/05/2017 à 06:42, James Yong a écrit :
>>>>> More info at https://docs.gradle.org/current/userguide/gradle_wrapper.html
>>>>>
>>>>> Regards,
>>>>> James Yong
>>>>>
>>>>> On 2017-05-06 03:59 (+0800), Pierre Smits <pi...@gmail.com> wrote:
>>>>>> HI all,
>>>>>>
>>>>>> While discussing the gradlew-wrapper.jar issue in the Weex release vote
>>>>>> [1], the following was suggested by Anthony Baker:
>>>>>>
>>>>>> You might want to consider using the Bigtop approach for gradlew [1] to
>>>>>> avoid shipping a binary in the source release. The Geode project has been
>>>>>> using this successfully (thanks to Roman for pointing us in this
>>>>>> direction!).
>>>>>>
>>>>>> [1] https://github.com/apache/bigtop/blob/master/gradlew <
>>>>>> https://github.com/apache/bigtop/blob/master/gradlew>
>>>>>>
>>>>>>
>>>>>>
>>>>>> Though I have not evaluated that solution (and compared it against what is
>>>>>> in the code base) it maybe so that such can be applied in OFBiz too.
>>>>>>
>>>>>> [1]
>>>>>> https://lists.apache.org/thread.html/67360a14837b8ea12ef5c70adb0c55f370e711900a9a372cb3ba3f1a@%3Cgeneral.incubator.apache.org%3E
>>>>>>
>>>>>> Best regards,
>>>>>>
>>>>>> Pierre Smits
>>>>>>
>>>>>> ORRTIZ.COM <http://www.orrtiz.com>
>>>>>> OFBiz based solutions & services
>>>>>>
>>>>>> OFBiz Extensions Marketplace
>>>>>> http://oem.ofbizci.net/oci-2/
>>>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>
Re: OFBiz & gradlew-wrapper.jar
Posted by Jacques Le Roux <ja...@les7arts.com>.
That's quite a good idea, thanks Nicolas
+1
Jacques
Le 23/11/2017 à 09:07, Nicolas Malin a écrit :
> I lookup the bigtop gradlew code and it's nice but I'm not sure tat works easily on win$ environment.
>
> I suggest also to follow Jacopo's remark and maybe we (I) can add an bash script util in tools to download gradlew, like
>
> $./tools/ofbiz-init.sh demo
>
> And like this we can add a .bat for other env.
>
> Nicolas
>
> Le 23/11/2017 à 08:54, Jacques Le Roux a écrit :
>> Hi,
>>
>> It's almost 7 months now and nothing happened at LEGAL-288
>>
>> So I think we should follow the way Jacopo suggested, and I reported below, before we do the next release
>>
>> Thanks
>>
>> Jacques
>>
>>
>> Le 07/05/2017 à 11:56, Jacques Le Roux a écrit :
>>> I suggest we wait for the result of LEGAL-288 before taking any decisions.
>>>
>>> We already discussed that in PMC private ML 2 weeks ago.
>>>
>>> The idea is it's OK for now and hopefully a new Java class will resolve this issue. Else, as Jacopo suggested:
>>>
>>> <<we will have to remove [the wrapper] from our future release package and add a step to our build notes:
>>>
>>> 1. Extract the archive file to your local directory.
>>> 2. Download gradle-wrapper.jar and place it in the gradle/wrapper folder.
>>>>>
>>>
>>> Jacques
>>>
>>>
>>> Le 07/05/2017 à 06:42, James Yong a écrit :
>>>> More info at https://docs.gradle.org/current/userguide/gradle_wrapper.html
>>>>
>>>> Regards,
>>>> James Yong
>>>>
>>>> On 2017-05-06 03:59 (+0800), Pierre Smits <pi...@gmail.com> wrote:
>>>>> HI all,
>>>>>
>>>>> While discussing the gradlew-wrapper.jar issue in the Weex release vote
>>>>> [1], the following was suggested by Anthony Baker:
>>>>>
>>>>> You might want to consider using the Bigtop approach for gradlew [1] to
>>>>> avoid shipping a binary in the source release. The Geode project has been
>>>>> using this successfully (thanks to Roman for pointing us in this
>>>>> direction!).
>>>>>
>>>>> [1] https://github.com/apache/bigtop/blob/master/gradlew <
>>>>> https://github.com/apache/bigtop/blob/master/gradlew>
>>>>>
>>>>>
>>>>>
>>>>> Though I have not evaluated that solution (and compared it against what is
>>>>> in the code base) it maybe so that such can be applied in OFBiz too.
>>>>>
>>>>> [1]
>>>>> https://lists.apache.org/thread.html/67360a14837b8ea12ef5c70adb0c55f370e711900a9a372cb3ba3f1a@%3Cgeneral.incubator.apache.org%3E
>>>>>
>>>>> Best regards,
>>>>>
>>>>> Pierre Smits
>>>>>
>>>>> ORRTIZ.COM <http://www.orrtiz.com>
>>>>> OFBiz based solutions & services
>>>>>
>>>>> OFBiz Extensions Marketplace
>>>>> http://oem.ofbizci.net/oci-2/
>>>>>
>>>
>>>
>>
>>
>
>
Re: OFBiz & gradlew-wrapper.jar
Posted by Nicolas Malin <ni...@nereide.fr>.
I lookup the bigtop gradlew code and it's nice but I'm not sure tat
works easily on win$ environment.
I suggest also to follow Jacopo's remark and maybe we (I) can add an
bash script util in tools to download gradlew, like
$./tools/ofbiz-init.sh demo
And like this we can add a .bat for other env.
Nicolas
Le 23/11/2017 à 08:54, Jacques Le Roux a écrit :
> Hi,
>
> It's almost 7 months now and nothing happened at LEGAL-288
>
> So I think we should follow the way Jacopo suggested, and I reported
> below, before we do the next release
>
> Thanks
>
> Jacques
>
>
> Le 07/05/2017 à 11:56, Jacques Le Roux a écrit :
>> I suggest we wait for the result of LEGAL-288 before taking any
>> decisions.
>>
>> We already discussed that in PMC private ML 2 weeks ago.
>>
>> The idea is it's OK for now and hopefully a new Java class will
>> resolve this issue. Else, as Jacopo suggested:
>>
>> <<we will have to remove [the wrapper] from our future release
>> package and add a step to our build notes:
>>
>> 1. Extract the archive file to your local directory.
>> 2. Download gradle-wrapper.jar and place it in the gradle/wrapper
>> folder.
>>>>
>>
>> Jacques
>>
>>
>> Le 07/05/2017 à 06:42, James Yong a écrit :
>>> More info at
>>> https://docs.gradle.org/current/userguide/gradle_wrapper.html
>>>
>>> Regards,
>>> James Yong
>>>
>>> On 2017-05-06 03:59 (+0800), Pierre Smits <pi...@gmail.com>
>>> wrote:
>>>> HI all,
>>>>
>>>> While discussing the gradlew-wrapper.jar issue in the Weex release
>>>> vote
>>>> [1], the following was suggested by Anthony Baker:
>>>>
>>>> You might want to consider using the Bigtop approach for gradlew
>>>> [1] to
>>>> avoid shipping a binary in the source release. The Geode project
>>>> has been
>>>> using this successfully (thanks to Roman for pointing us in this
>>>> direction!).
>>>>
>>>> [1] https://github.com/apache/bigtop/blob/master/gradlew <
>>>> https://github.com/apache/bigtop/blob/master/gradlew>
>>>>
>>>>
>>>>
>>>> Though I have not evaluated that solution (and compared it against
>>>> what is
>>>> in the code base) it maybe so that such can be applied in OFBiz too.
>>>>
>>>> [1]
>>>> https://lists.apache.org/thread.html/67360a14837b8ea12ef5c70adb0c55f370e711900a9a372cb3ba3f1a@%3Cgeneral.incubator.apache.org%3E
>>>>
>>>>
>>>> Best regards,
>>>>
>>>> Pierre Smits
>>>>
>>>> ORRTIZ.COM <http://www.orrtiz.com>
>>>> OFBiz based solutions & services
>>>>
>>>> OFBiz Extensions Marketplace
>>>> http://oem.ofbizci.net/oci-2/
>>>>
>>
>>
>
>