You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/12/17 20:05:00 UTC
[jira] [Commented] (AIRFLOW-5532) Missed imagePullSecrets from pod
created from k8s executor
[ https://issues.apache.org/jira/browse/AIRFLOW-5532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16998534#comment-16998534 ]
ASF GitHub Bot commented on AIRFLOW-5532:
-----------------------------------------
dimberman commented on pull request #6166: [AIRFLOW-5532] Fix imagePullSecrets in pod created from k8s executor
URL: https://github.com/apache/airflow/pull/6166
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Missed imagePullSecrets from pod created from k8s executor
> ----------------------------------------------------------
>
> Key: AIRFLOW-5532
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5532
> Project: Apache Airflow
> Issue Type: Bug
> Components: executor-kubernetes
> Affects Versions: 2.0.0
> Environment: container image apache/airflow:master-python3.7-ci-slim which appears to be v2.0.0-dev
> Reporter: Ke Zhu
> Assignee: Ke Zhu
> Priority: Major
>
> I used container image built based on *apache/airflow:master-python3.7-ci-slim* with k8s executor configured in airflow.cfg. all config options under section [kubernetes] and [kubernetes_secrets] are recognized successfully except option _image_pull_secrets_.
>
> Then I inspected the code at [https://github.com/apache/airflow/blob/47801057989046dfcf7b424ce54afee103803815/airflow/kubernetes/worker_configuration.py#L367-L387] where {{image_pull_secrets}} is NOT specified at all when constructing an object of {{PodGenerator}}. When reviewing further, I've noticed that the method {{WorkerConfiguration._get_image_pull_secrets()}} is not used at all. Which should be used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)