You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/07 03:57:14 UTC

[GitHub] [spark] yaooqinn opened a new pull request #32465: [SPARK-35331][SQL] Attributes become unknown in RepartitionByExpression after aliased

yaooqinn opened a new pull request #32465:
URL: https://github.com/apache/spark/pull/32465


   
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error message, please read the guideline first:
        https://spark.apache.org/error-message-guidelines.html
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   This PR makes the below case work well. 
   
   ```sql
   select a b from values(1) t(a) distribute by a;
   ```
   
   ```logtalk
   == Parsed Logical Plan ==
   'RepartitionByExpression ['a]
   +- 'Project ['a AS b#42]
      +- 'SubqueryAlias t
         +- 'UnresolvedInlineTable [a], [List(1)]
   
   == Analyzed Logical Plan ==
   org.apache.spark.sql.AnalysisException: cannot resolve 'a' given input columns: [b]; line 1 pos 62;
   'RepartitionByExpression ['a]
   +- Project [a#48 AS b#42]
      +- SubqueryAlias t
         +- LocalRelation [a#48]
   ```
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   bugfix
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   yes, the original attributes can be used in `distribute by` / `cluster by` and hints like `/*+ REPARTITION(3, c) */`
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   new tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834191119






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835037373


   Thank you for adding a test, @yaooqinn .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32465: [SPARK-35331][SQL] Attributes become unknown in RepartitionByExpression after aliased

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834067906






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835102677


   > Hi, @yaooqinn .
   > As you mentioned, this is not a regression and didn't work before. I believe this should be merged as a new improvement to Apache Spark 3.2.0.
   
   OK~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835289401






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835069495






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32465: [SPARK-35331][SQL] Attributes become unknown in RepartitionByExpression after aliased

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834068232






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835193650


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138273/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835297838


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42810/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #32465: [SPARK-35331][SQL] Attributes become unknown in RepartitionByExpression after aliased

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834097618


   > distribute by and cluster by clauses should behave the same as sort by and group by?
   
   Then the plan should be
   ```
   Project
     Repartition
       TableScan
   ``` 
   
   Is this the case today?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834191116






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan removed a comment on pull request #32465: [SPARK-35331][SQL] Attributes become unknown in RepartitionByExpression after aliased

Posted by GitBox <gi...@apache.org>.
cloud-fan removed a comment on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834097618


   > distribute by and cluster by clauses should behave the same as sort by and group by?
   
   Then the plan should be
   ```
   Project
     Repartition
       TableScan
   ``` 
   
   Is this the case today?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835263700


   **[Test build #138288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138288/testReport)** for PR 32465 at commit [`5163262`](https://github.com/apache/spark/commit/51632625e9fb3f09800112fe121de1dcae1dacee).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835328307


   Merged to master. Thank you, @yaooqinn and @cloud-fan .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835102400


   > Thank you for adding a test, @yaooqinn .
   
   It's my pleasure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835297838


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42810/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835263700


   **[Test build #138288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138288/testReport)** for PR 32465 at commit [`5163262`](https://github.com/apache/spark/commit/51632625e9fb3f09800112fe121de1dcae1dacee).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835193650


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138273/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835069530


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42795/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun closed pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #32465:
URL: https://github.com/apache/spark/pull/32465


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834048943


   **[Test build #138234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138234/testReport)** for PR 32465 at commit [`03ed3a5`](https://github.com/apache/spark/commit/03ed3a5a665adecd7a49d22242506ed1df96aa0f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835069530


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42795/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32465: [SPARK-35331][SQL] Attributes become unknown in RepartitionByExpression after aliased

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834065404






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835030515


   **[Test build #138273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138273/testReport)** for PR 32465 at commit [`2ce0fb6`](https://github.com/apache/spark/commit/2ce0fb690ea3123233a8714402367ddc12346907).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834170936


   **[Test build #138231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138231/testReport)** for PR 32465 at commit [`0c711e3`](https://github.com/apache/spark/commit/0c711e3a081dc644c3a2d3c47207046eb4457ee1).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835396079


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138288/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32465: [SPARK-35331][SQL] Attributes become unknown in RepartitionByExpression after aliased

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834046574


   **[Test build #138231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138231/testReport)** for PR 32465 at commit [`0c711e3`](https://github.com/apache/spark/commit/0c711e3a081dc644c3a2d3c47207046eb4457ee1).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32465: [SPARK-35331][SQL] Attributes become unknown in RepartitionByExpression after aliased

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834068232






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835390809


   **[Test build #138288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138288/testReport)** for PR 32465 at commit [`5163262`](https://github.com/apache/spark/commit/51632625e9fb3f09800112fe121de1dcae1dacee).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on pull request #32465: [SPARK-35331][SQL] Attributes become unknown in RepartitionByExpression after aliased

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834079593


   > is this a regression?
   
   this is not a regression, but hive supports it.
   
   > It seems to me that this should fail, as it's similar to `sql("select a b from values(1) t(a)").repartitionBy("a")`
   
   For resolving attributes,  `distribute by` and `cluster by`  clauses should behave the same as  `sort by` and `group by`?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32465: [SPARK-35331][SQL] Attributes become unknown in RepartitionByExpression after aliased

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834048943


   **[Test build #138234 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138234/testReport)** for PR 32465 at commit [`03ed3a5`](https://github.com/apache/spark/commit/03ed3a5a665adecd7a49d22242506ed1df96aa0f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a change in pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #32465:
URL: https://github.com/apache/spark/pull/32465#discussion_r628574013



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
##########
@@ -4100,6 +4100,17 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with AdaptiveSpark
       }
     }
   }
+
+  test("SPARK-35331: Fix resolving original expression in RepartitionByExpression after aliased") {

Review comment:
       If you don't mind, could you add a test case for HINT explicitly?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] yaooqinn commented on pull request #32465: [SPARK-35331][SQL] Attributes become unknown in RepartitionByExpression after aliased

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834050531


   cc @cloud-fan @maropu @HyukjinKwon thanks for reviewing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834046574


   **[Test build #138231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138231/testReport)** for PR 32465 at commit [`0c711e3`](https://github.com/apache/spark/commit/0c711e3a081dc644c3a2d3c47207046eb4457ee1).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834183373


   **[Test build #138234 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138234/testReport)** for PR 32465 at commit [`03ed3a5`](https://github.com/apache/spark/commit/03ed3a5a665adecd7a49d22242506ed1df96aa0f).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835189993


   **[Test build #138273 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138273/testReport)** for PR 32465 at commit [`2ce0fb6`](https://github.com/apache/spark/commit/2ce0fb690ea3123233a8714402367ddc12346907).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] cloud-fan commented on pull request #32465: [SPARK-35331][SQL] Attributes become unknown in RepartitionByExpression after aliased

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-834065842


   is this a regression? It seems to me that this should fail, as it's similar to `sql("select a b from values(1) t(a)").repartitionBy("a")`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32465: [SPARK-35331][SQL] Support resolving missing attrs for distribute/cluster by/repartition hint

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32465:
URL: https://github.com/apache/spark/pull/32465#issuecomment-835030515


   **[Test build #138273 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138273/testReport)** for PR 32465 at commit [`2ce0fb6`](https://github.com/apache/spark/commit/2ce0fb690ea3123233a8714402367ddc12346907).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org