You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HappenLee (via GitHub)" <gi...@apache.org> on 2023/06/27 04:18:55 UTC
[GitHub] [doris] HappenLee opened a new pull request, #21226: [Opt](scan) opt the scanner schedule logic
HappenLee opened a new pull request, #21226:
URL: https://github.com/apache/doris/pull/21226
## Proposed changes
Opt scanner schedule logic， delete useless profile timer
before: 50ms
after: 15ms
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21226: [Opt](scan) opt the scanner schedule logic
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21226:
URL: https://github.com/apache/doris/pull/21226#issuecomment-1612501246
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #21226: [Opt](scan) opt the scanner schedule logic
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #21226:
URL: https://github.com/apache/doris/pull/21226#discussion_r1246157359
##########
be/src/vec/exec/scan/pip_scanner_context.h:
##########
@@ -152,23 +152,10 @@ class PipScannerContext : public vectorized::ScannerContext {
}
bool has_enough_space_in_blocks_queue() const override {
- return _current_used_bytes < _max_bytes_in_queue / 2 * _num_parallel_instances;
+ return _current_used_bytes < _max_bytes_in_queue * _num_parallel_instances;
Review Comment:
_max_bytes_in_queue is the scan_queue_mem_limit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee closed pull request #21226: [Opt](exec) opt the performance of date parquet convert by date dict
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee closed pull request #21226: [Opt](exec) opt the performance of date parquet convert by date dict
URL: https://github.com/apache/doris/pull/21226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21226: [Opt](scan) opt the scanner schedule logic
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21226:
URL: https://github.com/apache/doris/pull/21226#issuecomment-1608774366
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on pull request #21226: [Opt](scan) opt the scanner schedule logic
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #21226:
URL: https://github.com/apache/doris/pull/21226#issuecomment-1608770325
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] wangbo commented on a diff in pull request #21226: [Opt](scan) opt the scanner schedule logic
Posted by "wangbo (via GitHub)" <gi...@apache.org>.
wangbo commented on code in PR #21226:
URL: https://github.com/apache/doris/pull/21226#discussion_r1243188593
##########
be/src/vec/exec/scan/pip_scanner_context.h:
##########
@@ -152,23 +152,10 @@ class PipScannerContext : public vectorized::ScannerContext {
}
bool has_enough_space_in_blocks_queue() const override {
- return _current_used_bytes < _max_bytes_in_queue / 2 * _num_parallel_instances;
+ return _current_used_bytes < _max_bytes_in_queue * _num_parallel_instances;
Review Comment:
why not using scan_queue_mem_limit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #21226: [Opt](exec) opt the performance of date parquet convert by date dict
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #21226:
URL: https://github.com/apache/doris/pull/21226#issuecomment-1657202787
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org