[GitHub] [guacamole-client] necouchman commented on a change in pull request #495: GUACAMOLE-770: Support for clearing TOTP data

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #495: GUACAMOLE-770: Support for clearing TOTP data
URL: https://github.com/apache/guacamole-client/pull/495#discussion_r403255038
 
 

 ##########
 File path: extensions/guacamole-auth-totp/src/main/java/org/apache/guacamole/auth/totp/user/TOTPUser.java
 ##########
 @@ -66,14 +81,8 @@ public User getUndecorated() {
     public Map<String, String> getAttributes() {
 
         // Create independent, mutable copy of attributes
-        Map<String, String> attributes =
-                new HashMap<String, String>(super.getAttributes());
+        Map<String, String> attributes = new HashMap<>(super.getAttributes());
 
-        // Do not expose any TOTP-related attributes outside this extension
-        attributes.remove(TOTP_KEY_SECRET_ATTRIBUTE_NAME);
-        attributes.remove(TOTP_KEY_CONFIRMED_ATTRIBUTE_NAME);
 
 Review comment:
   Good point.  So this is going to require some more....creativity...to figure out a good way to reset it without actually pulling the value through...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services