You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:36:28 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request #1984: Fixing core build because of recent changes in camel master
JiriOndrusek opened a new pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984
Fixing build problems because of canges in camel-master (https://github.com/apache/camel/commit/75d61761b225d0fd92d16d4b3e3345b6f5dd36e7, https://github.com/apache/camel/commit/68cd5afe733c383c6c862bda1fa65244cf6dfa9a)
Linked to https://issues.apache.org/jira/browse/CAMEL-15784
As I'm not 100% sure about fix of `BaseServiceResolver`, I'd suggest to wait for tests (it is camel-master)
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#issuecomment-722378896
Let me merge this manually. There's some stuff on the master branch that will conflict with this change so that needs resolving too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#issuecomment-721621602
I was able to fix it by adding dependency into extension/microrofile-fault-tolerance:
> <dependency>
> <groupId>org.apache.camel</groupId>
> <artifactId>camel-resilience4j</artifactId>
> </dependency>
and by registering service:
> @BuildStep
NativeImageResourceBuildItem initResources() {
return new NativeImageResourceBuildItem(
"META-INF/services/org/apache/camel/model/CircuitBreakerDefinition");
}
But I'm not sure if this is correct solution, WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#issuecomment-722372820
@davsclaus I think that PR could be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#discussion_r518043426
##########
File path: extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelProcessor.java
##########
@@ -346,4 +347,10 @@ void unremovableBeans(BuildProducer<AdditionalBeanBuildItem> beanProducer) {
.map(CamelRoutesBuilderClassBuildItem::new)
.collect(Collectors.toList());
}
+
+ @BuildStep
+ NativeImageResourceBuildItem initResources() {
+ return new NativeImageResourceBuildItem(
+ "META-INF/services/org/apache/camel/bean-processor-factory");
Review comment:
I've created issue https://github.com/apache/camel-quarkus/issues/1995
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#discussion_r517210504
##########
File path: extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/FastCamelContext.java
##########
@@ -344,10 +345,11 @@ protected HeadersMapFactory createHeadersMapFactory() {
@Override
protected BeanProxyFactory createBeanProxyFactory() {
- return new BaseServiceResolver<>(BeanProxyFactory.FACTORY, BeanProxyFactory.class)
- .resolve(getCamelContextReference())
- .orElseThrow(() -> new IllegalArgumentException("Cannot find BeanProxyFactory on classpath. "
- + "Add camel-bean to classpath."));
+ return new BaseServiceResolver<>(BeanProxyFactory.FACTORY, BeanProxyFactory.class,
+ getFactoryFinder(FactoryFinder.DEFAULT_PATH))
Review comment:
oh, I'll fix it, thanks for the advice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#discussion_r517353349
##########
File path: extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/FastCamelContext.java
##########
@@ -344,10 +345,11 @@ protected HeadersMapFactory createHeadersMapFactory() {
@Override
protected BeanProxyFactory createBeanProxyFactory() {
- return new BaseServiceResolver<>(BeanProxyFactory.FACTORY, BeanProxyFactory.class)
- .resolve(getCamelContextReference())
- .orElseThrow(() -> new IllegalArgumentException("Cannot find BeanProxyFactory on classpath. "
- + "Add camel-bean to classpath."));
+ return new BaseServiceResolver<>(BeanProxyFactory.FACTORY, BeanProxyFactory.class,
+ getFactoryFinder(FactoryFinder.DEFAULT_PATH))
Review comment:
@davsclaus I've tried to use `getBootstrapFactoryFinder` but it caused failures like:
>
>Caused by: org.apache.camel.FailedToCreateRouteException: Failed to create route route3 at: >>> Bean[org.apache.camel.quarkus.component.bean.CamelRoute$MyBean] <<< in route: Route(route3)[From[direct:method] -> [Bean[org.apache.camel.... because of Cannot find BeanProcessorFactory on classpath. Add camel-bean to classpath.
at org.apache.camel.reifier.RouteReifier.doCreateRoute(RouteReifier.java:222)
at org.apache.camel.reifier.RouteReifier.createRoute(RouteReifier.java:66)
at org.apache.camel.quarkus.core.FastCamelContext.startRouteDefinitions(FastCamelContext.java:882)
at org.apache.camel.quarkus.core.FastCamelContext.startRouteDefinitions(FastCamelContext.java:619)
at org.apache.camel.impl.engine.AbstractCamelContext.doInit(AbstractCamelContext.java:2633)
at org.apache.camel.quarkus.core.FastCamelContext.doInit(FastCamelContext.java:505)
at org.apache.camel.support.service.BaseService.init(BaseService.java:83)
at org.apache.camel.impl.engine.AbstractCamelContext.init(AbstractCamelContext.java:2405)
at org.apache.camel.support.service.BaseService.start(BaseService.java:111)
at org.apache.camel.impl.engine.AbstractCamelContext.start(AbstractCamelContext.java:2422)
at org.apache.camel.quarkus.core.CamelContextRuntime.start(CamelContextRuntime.java:57)
at org.apache.camel.quarkus.core.CamelBootstrapRecorder.start(CamelBootstrapRecorder.java:45)
... 9 more
Caused by: java.lang.IllegalArgumentException: Cannot find BeanProcessorFactory on classpath. Add camel-bean to classpath.
at org.apache.camel.quarkus.core.FastCamelContext.lambda$createBeanProcessorFactory$2(FastCamelContext.java:369)
at java.util.Optional.orElseThrow(Optional.java:408)
at org.apache.camel.quarkus.core.FastCamelContext.createBeanProcessorFactory(FastCamelContext.java:369)
at org.apache.camel.impl.engine.AbstractCamelContext.getBeanProcessorFactory(AbstractCamelContext.java:4290)
at org.apache.camel.reifier.BeanReifier.createProcessor(BeanReifier.java:41)
at org.apache.camel.reifier.ProcessorReifier.makeProcessor(ProcessorReifier.java:756)
at org.apache.camel.reifier.ProcessorReifier.addRoutes(ProcessorReifier.java:494)
at org.apache.camel.reifier.RouteReifier.doCreateRoute(RouteReifier.java:220)
... 20 more
Original value (` getFactoryFinder(FactoryFinder.DEFAULT_PATH)`) works.
So for now I've kept ` getFactoryFinder(FactoryFinder.DEFAULT_PATH)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#issuecomment-721623687
That should be this JAR
https://github.com/apache/camel/tree/master/components/camel-microprofile-fault-tolerance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#discussion_r517873312
##########
File path: extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelProcessor.java
##########
@@ -346,4 +347,10 @@ void unremovableBeans(BuildProducer<AdditionalBeanBuildItem> beanProducer) {
.map(CamelRoutesBuilderClassBuildItem::new)
.collect(Collectors.toList());
}
+
+ @BuildStep
+ NativeImageResourceBuildItem initResources() {
+ return new NativeImageResourceBuildItem(
+ "META-INF/services/org/apache/camel/bean-processor-factory");
Review comment:
btw, I think it is fine to have this and open an issue for further improvements
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#discussion_r517422487
##########
File path: extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelProcessor.java
##########
@@ -346,4 +347,10 @@ void unremovableBeans(BuildProducer<AdditionalBeanBuildItem> beanProducer) {
.map(CamelRoutesBuilderClassBuildItem::new)
.collect(Collectors.toList());
}
+
+ @BuildStep
+ NativeImageResourceBuildItem initResources() {
+ return new NativeImageResourceBuildItem(
+ "META-INF/services/org/apache/camel/bean-processor-factory");
Review comment:
@davsclaus I've returned `getBootstrapFactoryFinder`. To make it work (I've tested it successfully with a few integration tests locally) , I had to add this resource int camelProcessor. This solution does not seems correct to me. @lburgazzoli May I ask you for help? (I see see you in annotation in this class)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#issuecomment-722433544
Thanks @JiriOndrusek I merged the fixes to the `camel-master` branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#issuecomment-721744893
This is the code in camel 3.7
```
@Override
protected BeanProcessorFactory createBeanProcessorFactory() {
return new BaseServiceResolver<>(BeanProcessorFactory.FACTORY, BeanProcessorFactory.class, getBootstrapFactoryFinder())
.resolve(getCamelContextReference())
.orElseThrow(() -> new IllegalArgumentException(
"Cannot find BeanProcessorFactory on classpath. "
+ "Add camel-bean to classpath."));
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#issuecomment-721634291
@davsclaus thanks, the dependency was not required. I'll fix PR in a moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#discussion_r517873312
##########
File path: extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelProcessor.java
##########
@@ -346,4 +347,10 @@ void unremovableBeans(BuildProducer<AdditionalBeanBuildItem> beanProducer) {
.map(CamelRoutesBuilderClassBuildItem::new)
.collect(Collectors.toList());
}
+
+ @BuildStep
+ NativeImageResourceBuildItem initResources() {
+ return new NativeImageResourceBuildItem(
+ "META-INF/services/org/apache/camel/bean-processor-factory");
Review comment:
btw, I think it is fine to have this and open an issue for further investigations
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton closed pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
jamesnetherton closed pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#issuecomment-721610640
@ppalaga @jamesnetherton may I ask for help with this test failure?
Problem is caused by the fact, that `BootstrapFactoryFinder` can not instantiate `FaultToleranceProcessor`
which is caused probably by the fact that either resource `META-INF/services/org/apache/camel/model/CircuitBreakerDefinition` is missing or reflective registration for `org.apache.camel.component.resilience4j.ResilienceProcessorFactory` is missing.
Fact is, that this code returns null in native - https://github.com/apache/camel/blob/master/core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/DefaultFactoryFinder.java#L110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#discussion_r517445985
##########
File path: extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/FastCamelContext.java
##########
@@ -344,10 +345,11 @@ protected HeadersMapFactory createHeadersMapFactory() {
@Override
protected BeanProxyFactory createBeanProxyFactory() {
- return new BaseServiceResolver<>(BeanProxyFactory.FACTORY, BeanProxyFactory.class)
- .resolve(getCamelContextReference())
- .orElseThrow(() -> new IllegalArgumentException("Cannot find BeanProxyFactory on classpath. "
- + "Add camel-bean to classpath."));
+ return new BaseServiceResolver<>(BeanProxyFactory.FACTORY, BeanProxyFactory.class,
+ getFactoryFinder(FactoryFinder.DEFAULT_PATH))
Review comment:
I've returned to `getBootstrapFactoryFinder`, resolving
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on a change in pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#discussion_r517209261
##########
File path: extensions-core/core/runtime/src/main/java/org/apache/camel/quarkus/core/FastCamelContext.java
##########
@@ -344,10 +345,11 @@ protected HeadersMapFactory createHeadersMapFactory() {
@Override
protected BeanProxyFactory createBeanProxyFactory() {
- return new BaseServiceResolver<>(BeanProxyFactory.FACTORY, BeanProxyFactory.class)
- .resolve(getCamelContextReference())
- .orElseThrow(() -> new IllegalArgumentException("Cannot find BeanProxyFactory on classpath. "
- + "Add camel-bean to classpath."));
+ return new BaseServiceResolver<>(BeanProxyFactory.FACTORY, BeanProxyFactory.class,
+ getFactoryFinder(FactoryFinder.DEFAULT_PATH))
Review comment:
That should be getBootstrapFactoryFinder for all these kinds where they are resolved once during bootstapping. The same for the other places where you changed.
Thanks for fixing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#discussion_r517863225
##########
File path: extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelProcessor.java
##########
@@ -346,4 +347,10 @@ void unremovableBeans(BuildProducer<AdditionalBeanBuildItem> beanProducer) {
.map(CamelRoutesBuilderClassBuildItem::new)
.collect(Collectors.toList());
}
+
+ @BuildStep
+ NativeImageResourceBuildItem initResources() {
+ return new NativeImageResourceBuildItem(
+ "META-INF/services/org/apache/camel/bean-processor-factory");
Review comment:
@lburgazzoli yes, I've noticed that, therefore I'm still thinking that my change is unnecessary, but it fixes problem. But I'm not sure why it is required...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a change in pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
JiriOndrusek commented on a change in pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#discussion_r517445503
##########
File path: extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelProcessor.java
##########
@@ -346,4 +347,10 @@ void unremovableBeans(BuildProducer<AdditionalBeanBuildItem> beanProducer) {
.map(CamelRoutesBuilderClassBuildItem::new)
.collect(Collectors.toList());
}
+
+ @BuildStep
+ NativeImageResourceBuildItem initResources() {
+ return new NativeImageResourceBuildItem(
+ "META-INF/services/org/apache/camel/bean-processor-factory");
Review comment:
great, thanks for confirmation, let see, if all tests are green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#discussion_r517448828
##########
File path: extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelProcessor.java
##########
@@ -346,4 +347,10 @@ void unremovableBeans(BuildProducer<AdditionalBeanBuildItem> beanProducer) {
.map(CamelRoutesBuilderClassBuildItem::new)
.collect(Collectors.toList());
}
+
+ @BuildStep
+ NativeImageResourceBuildItem initResources() {
+ return new NativeImageResourceBuildItem(
+ "META-INF/services/org/apache/camel/bean-processor-factory");
Review comment:
afaik those files are scanned and the related classes are added to the FastFactoryFinder so it should not be required to include the resource, see: https://github.com/apache/camel-quarkus/blob/master/extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelProcessor.java#L136-L159
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] davsclaus commented on a change in pull request #1984: Fixing core build because of recent changes in camel master
Posted by GitBox <gi...@apache.org>.
davsclaus commented on a change in pull request #1984:
URL: https://github.com/apache/camel-quarkus/pull/1984#discussion_r517441795
##########
File path: extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelProcessor.java
##########
@@ -346,4 +347,10 @@ void unremovableBeans(BuildProducer<AdditionalBeanBuildItem> beanProducer) {
.map(CamelRoutesBuilderClassBuildItem::new)
.collect(Collectors.toList());
}
+
+ @BuildStep
+ NativeImageResourceBuildItem initResources() {
+ return new NativeImageResourceBuildItem(
+ "META-INF/services/org/apache/camel/bean-processor-factory");
Review comment:
Oh that seems correct as there are a bunch of files in those folders for various Camel components that are discovered via classpath/factory-finder and so quarkus needs to ensure those meta files are included.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org